Index: firmware/App/Controllers/Valves.c =================================================================== diff -u -r49a4a0ea2ccfcc6b583330d4aad064d9176697f4 -ra72cc92cae2b043fadc8ed9a1d065cfb403185a0 --- firmware/App/Controllers/Valves.c (.../Valves.c) (revision 49a4a0ea2ccfcc6b583330d4aad064d9176697f4) +++ firmware/App/Controllers/Valves.c (.../Valves.c) (revision a72cc92cae2b043fadc8ed9a1d065cfb403185a0) @@ -170,7 +170,7 @@ { VALVE_POSITION_T commandedPosition; ///< Valve commanded position enum VALVE_POSITION_T currentPosition; ///< Valve current position enum - VALVE_POSITION_T pendingCommandedPosition; ///< Valve pending position enum + VALVE_POSITION_T pendingCommandedPosition; ///< Valve pending position enum OVERRIDE_S32_T currentPositionInCounts; ///< Valve current position in counts S16 targetPositionInCounts; ///< Valve target position in counts BOOL hasTransitionBeenRequested; ///< Valve transition request flag @@ -334,7 +334,6 @@ // All the other positions are valid if ( ( position != VALVE_POSITION_NOT_IN_POSITION ) && ( valve < NUM_OF_VALVES ) ) { - //valvesStatus[ valve ].commandedPosition = position; TODO remove valvesStatus[ valve ].pendingCommandedPosition = position; valvesStatus[ valve ].hasTransitionBeenRequested = TRUE; result = TRUE; @@ -846,15 +845,12 @@ { // The valve is in range. Set the current position to the commanded position valvesStatus[ valve ].currentPosition = commandedPositionEnum; - // Set the transition request to false as it has been serviced - //valvesStatus[ valve ].hasTransitionBeenRequested = FALSE; TODO remove // If we are in Pos B, enable current relaxation if ( commandedPositionEnum == VALVE_POSITION_B_OPEN ) { // Enable current relaxation setFPGAValveSetPoint( valve, currentPosition, TRUE ); - //valvesStatus[ valve ].hasTransitionBeenRequested = TRUE; TODO remove } // Go back to Idle state