Index: firmware/App/Services/SystemCommMessages.c =================================================================== diff -u -rdbcbd145954ef52510ac929a412e0dba42f0941b -ra42f849450c65801f2d45ca9085af81a1f11269d --- firmware/App/Services/SystemCommMessages.c (.../SystemCommMessages.c) (revision dbcbd145954ef52510ac929a412e0dba42f0941b) +++ firmware/App/Services/SystemCommMessages.c (.../SystemCommMessages.c) (revision a42f849450c65801f2d45ca9085af81a1f11269d) @@ -2414,9 +2414,9 @@ * @brief * The handleHomeHDValve function handles a request to home an HD valve * @details - * Inputs : none - * Outputs : message handled - * @param message : a pointer to the message to handle + * Inputs: none + * Outputs: message handled + * @param message: a pointer to the message to handle * @return none *************************************************************************/ void handleHomeHDValve( MESSAGE_T *message ) @@ -2432,7 +2432,6 @@ result = TRUE; } - // respond to request sendTestAckResponseMsg( (MSG_ID_T)message->hdr.msgID, result ); } @@ -2442,16 +2441,16 @@ * The handleTestHDValvesBroadcastIntervalOverrideRequest function handles \n * a request to override the broadcast interval for HD valves data. * @details - * Inputs : none - * Outputs : message handled - * @param message : a pointer to the message to handle + * Inputs: none + * Outputs: message handled + * @param message: a pointer to the message to handle * @return none *************************************************************************/ void handleTestHDValvesBroadcastIntervalOverrideRequest( MESSAGE_T *message ) { TEST_OVERRIDE_ARRAY_PAYLOAD_T payload; - BOOL result = FALSE; + BOOL result = FALSE; // verify payload length if ( sizeof(TEST_OVERRIDE_ARRAY_PAYLOAD_T) == message->hdr.payloadLen ) { @@ -2492,7 +2491,6 @@ result = TRUE; } - // respond to request sendTestAckResponseMsg( (MSG_ID_T)message->hdr.msgID, result ); } @@ -2502,16 +2500,16 @@ * The handleSetHDValvePositionOverrideRequest function handles a request to * override the position of a valve * @details - * Inputs : none - * Outputs : message handled - * @param message : a pointer to the message to handle + * Inputs: none + * Outputs: message handled + * @param message: a pointer to the message to handle * @return none *************************************************************************/ void handleSetHDValvePositionOverrideRequest( MESSAGE_T *message ) { TEST_OVERRIDE_ARRAY_PAYLOAD_T payload; - BOOL result = 0; + BOOL result = FALSE; // verify payload length if ( sizeof(TEST_OVERRIDE_ARRAY_PAYLOAD_T) == message->hdr.payloadLen ) { @@ -2535,20 +2533,21 @@ * The handleSetHDValvePWMOverrideRequest function handles a request to * override the PWM of a valve * @details - * Inputs : none - * Outputs : message handled - * @param message : a pointer to the message to handle + * Inputs: none + * Outputs: message handled + * @param message: a pointer to the message to handle * @return none *************************************************************************/ void handleSetHDValvePWMOverrideRequest( MESSAGE_T *message ) { OVERRIDE_VALVES_PWM_DIR_SET_PAYLOAD_T payload; - BOOL result = 0; - /* verify payload length */ + + BOOL result = FALSE; + // verify payload length if ( sizeof(OVERRIDE_VALVES_PWM_DIR_SET_PAYLOAD_T) == message->hdr.payloadLen ) { memcpy( &payload, message->payload, sizeof(OVERRIDE_VALVES_PWM_DIR_SET_PAYLOAD_T) ); - if ( 0 == payload.reset ) + if ( FALSE == payload.reset ) { result = testSetValvePWMOverride( payload.valve, payload.pwm, payload.direction ); } @@ -2557,7 +2556,7 @@ result = testResetValvePWMOverride( payload.valve ); } } - /* respond to request */ + // respond to request sendTestAckResponseMsg( (MSG_ID_T)message->hdr.msgID, result ); } #endif