Index: results/cppcheckError.csv =================================================================== diff -u -r1c80d60fe6a95297a8a8033a3c7eade53e72779a -rbd37de9f5836bbb46d90ee639cc60e6375614f1b --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 1c80d60fe6a95297a8a8033a3c7eade53e72779a) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision bd37de9f5836bbb46d90ee639cc60e6375614f1b) @@ -1,64 +1,79 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Controllers/RTC.c,1140,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/App/Controllers/RTC.c,655,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced. -hdfirmware/firmware/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,278,style,unusedFunction,The function 'activateAlarm1Data' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,301,style,unusedFunction,The function 'activateAlarm2Data' is never used. -hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,230,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,847,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,831,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,60,style,unusedFunction,The function 'execDialysis' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,389,style,unusedFunction,The function 'execPresOcclTest' is never used. -hdfirmware/firmware/App/Modes/TreatmentStop.c,62,style,unusedFunction,The function 'execTreatmentStop' is never used. -hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. -hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. -hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,206,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,359,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,212,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,162,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,177,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,815,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,202,style,unusedFunction,The function 'execSystemCommRx' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,518,style,unusedFunction,The function 'getDataFromRAM' is never used. -hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. -hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. -hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,167,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,482,style,unusedFunction,The function 'getRTCRAMState' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,497,style,unusedFunction,The function 'getRTCRAMStatus' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,371,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,335,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,151,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,273,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,231,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,436,style,unusedFunction,The function 'readFromRAM' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,184,style,unusedFunction,The function 'setDialInPumpTargetFlowRate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,143,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,112,style,unusedFunction,The function 'setPressureLimits' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,247,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,248,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,48,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. -hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,47,style,unusedFunction,The function 'transitionToDialysis' is never used. -hdfirmware/firmware/App/Modes/TreatmentStop.c,48,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,233,style,unusedFunction,The function 'setRTCTimestamp' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,246,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,247,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,48,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. -hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,388,style,unusedFunction,The function 'writeToRAM' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,790,style,unreadVariable,Variable 'flowStPt' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,792,style,unreadVariable,Variable 'measRotSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,793,style,unreadVariable,Variable 'measSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,794,style,unreadVariable,Variable 'measMCSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,795,style,unreadVariable,Variable 'measMCCurr' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,796,style,unreadVariable,Variable 'pumpPWMPctDutyCycle' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,309,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,359,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePreTreat.c,80,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatment.c,741,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. +hdfirmware/firmware/App/Services/Interrupts.c,175,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1312,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1526,style,variableScope,The scope of the variable 'quotient' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1527,style,variableScope,The scope of the variable 'modulus' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'i' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/Utilities.c,212,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. +hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. +hdfirmware/firmware/App/Drivers/InternalADC.c,115,style,unusedFunction,The function 'adcNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,172,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/FWCommon/PersistentAlarm.c,94,style,unusedFunction,The function 'checkPersistentAlarm' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,616,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,525,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,315,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,361,style,unusedFunction,The function 'edgeNotification' is never used. +hdfirmware/firmware/App/Controllers/AirTrap.c,207,style,unusedFunction,The function 'execAirTrapMonitorPriming' is never used. +hdfirmware/firmware/App/Controllers/AirTrap.c,441,style,unusedFunction,The function 'execAirTrapTest' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,371,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,1222,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,724,style,unusedFunction,The function 'getBootloaderFlag' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,352,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,298,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,337,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,322,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,1193,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getDisinfectionDate' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1130,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1162,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1194,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,332,style,unusedFunction,The function 'getMfgData' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,425,style,unusedFunction,The function 'getServiceDate' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,669,style,unusedFunction,The function 'getTreatmentParameterS32' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,518,style,unusedFunction,The function 'getTreatmentTime' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,327,style,unusedFunction,The function 'getValvePosition' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,555,style,unusedFunction,The function 'getWaterConsumption' is never used. +hdfirmware/firmware/FWCommon/PersistentAlarm.c,60,style,unusedFunction,The function 'initPersistentAlarm' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,460,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,476,style,unusedFunction,The function 'isAlarmRecoverable' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,202,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,215,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Drivers/Comm.c,263,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,76,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,237,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,95,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'readLogData' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,117,style,unusedFunction,The function 'rtiNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,245,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,703,style,unusedFunction,The function 'setBootloaderFlag' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,408,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,570,style,unusedFunction,The function 'setDisinfectionDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'setMfgData' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,147,style,unusedFunction,The function 'setOcclusionThreshold' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,117,style,unusedFunction,The function 'setPressureLimits' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,400,style,unusedFunction,The function 'setServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,494,style,unusedFunction,The function 'setTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,532,style,unusedFunction,The function 'setWaterConsumption' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,447,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)