Index: results/cppcheckError.csv =================================================================== diff -u -r1c80d60fe6a95297a8a8033a3c7eade53e72779a -rf9890311898663a704692870ffb53d43cea0d20b --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 1c80d60fe6a95297a8a8033a3c7eade53e72779a) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision f9890311898663a704692870ffb53d43cea0d20b) @@ -1,8 +1,8 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Controllers/RTC.c,1140,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/App/Controllers/RTC.c,655,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. hdfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1197,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,695,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. hdfirmware/firmware/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,278,style,unusedFunction,The function 'activateAlarm1Data' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,301,style,unusedFunction,The function 'activateAlarm2Data' is never used. @@ -15,50 +15,33 @@ hdfirmware/firmware/App/Modes/Dialysis.c,60,style,unusedFunction,The function 'execDialysis' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,389,style,unusedFunction,The function 'execPresOcclTest' is never used. hdfirmware/firmware/App/Modes/TreatmentStop.c,62,style,unusedFunction,The function 'execTreatmentStop' is never used. +hdfirmware/firmware/FWCommon/RTC.c,558,style,unusedFunction,The function 'getDataFromRAM' is never used. hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. hdfirmware/firmware/App/Services/PIControllers.c,206,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/FWCommon/RTC.c,522,style,unusedFunction,The function 'getRTCRAMState' is never used. +hdfirmware/firmware/FWCommon/RTC.c,537,style,unusedFunction,The function 'getRTCRAMStatus' is never used. +hdfirmware/firmware/FWCommon/RTC.c,411,style,unusedFunction,The function 'getRTCTimestamp' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,359,style,unusedFunction,The function 'isAlarmActive' is never used. hdfirmware/firmware/App/Services/SystemComm.c,212,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,162,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,177,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,815,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,202,style,unusedFunction,The function 'execSystemCommRx' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,518,style,unusedFunction,The function 'getDataFromRAM' is never used. -hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. -hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. -hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,167,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,482,style,unusedFunction,The function 'getRTCRAMState' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,497,style,unusedFunction,The function 'getRTCRAMStatus' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,371,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,335,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,151,style,unusedFunction,The function 'isDGCommunicating' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTCompleted' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used. hdfirmware/firmware/App/Drivers/Comm.c,273,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. hdfirmware/firmware/App/Services/SystemComm.c,231,style,unusedFunction,The function 'isUICommunicating' is never used. hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,436,style,unusedFunction,The function 'readFromRAM' is never used. +hdfirmware/firmware/FWCommon/RTC.c,476,style,unusedFunction,The function 'readFromRAM' is never used. hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. hdfirmware/firmware/App/Controllers/DialInFlow.c,184,style,unusedFunction,The function 'setDialInPumpTargetFlowRate' is never used. hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,143,style,unusedFunction,The function 'setOcclusionThreshold' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,112,style,unusedFunction,The function 'setPressureLimits' is never used. hdfirmware/firmware/App/Controllers/BloodFlow.c,247,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. hdfirmware/firmware/App/Controllers/DialInFlow.c,248,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,48,style,unusedFunction,The function 'taskGeneral' is never used. +hdfirmware/firmware/App/Tasks/TaskGeneral.c,49,style,unusedFunction,The function 'taskGeneral' is never used. hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. hdfirmware/firmware/App/Modes/Dialysis.c,47,style,unusedFunction,The function 'transitionToDialysis' is never used. hdfirmware/firmware/App/Modes/TreatmentStop.c,48,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,233,style,unusedFunction,The function 'setRTCTimestamp' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,246,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,247,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,48,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used. -hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Controllers/RTC.c,388,style,unusedFunction,The function 'writeToRAM' is never used. +hdfirmware/firmware/FWCommon/RTC.c,428,style,unusedFunction,The function 'writeToRAM' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)