Index: results/cppcheckError.csv =================================================================== diff -u -r21c2cb5c9ca2e97127884c8f041fc7b04205de61 -r270d3c64e17c324cdc52eadbc1a76ddc1decee86 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 21c2cb5c9ca2e97127884c8f041fc7b04205de61) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 270d3c64e17c324cdc52eadbc1a76ddc1decee86) @@ -1,11 +1,19 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Modes/ModeOpParams.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePostTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePrescription.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Services/Interrupts.c,140,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1157,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,811,style,unreadVariable,Variable 'flowStPt' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,813,style,unreadVariable,Variable 'measRotSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,814,style,unreadVariable,Variable 'measSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unreadVariable,Variable 'measMCSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,816,style,unreadVariable,Variable 'measMCCurr' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,817,style,unreadVariable,Variable 'pumpPWMPctDutyCycle' is assigned a value that is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,99,style,unusedVariable,Unused variable: dir +hdfirmware/firmware/App/Modes/Dialysis.c,273,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,324,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePreTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatment.c,558,style,unreadVariable,Variable 'oldUFRate' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,85,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Services/Interrupts.c,147,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1272,style,unreadVariable,Variable 'result' is assigned a value that is never used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1529,style,variableScope,The scope of the variable 'quotient' can be reduced. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'modulus' can be reduced. @@ -16,59 +24,54 @@ hdfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. hdfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,54,style,unusedFunction,The function 'activateSafetyShutdown' is never used. hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,136,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,115,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,382,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,331,style,unusedFunction,The function 'cmdSetDGActiveReservoir' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,284,style,unusedFunction,The function 'cmdSetDGDialysateTargetTemps' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,368,style,unusedFunction,The function 'cmdStartDGDrain' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,353,style,unusedFunction,The function 'cmdStartDGFill' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,315,style,unusedFunction,The function 'cmdStopDG' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,267,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,876,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,860,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,374,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,143,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,122,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,641,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,559,style,unusedFunction,The function 'cmdStartDGTrimmerHeater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,544,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,574,style,unusedFunction,The function 'cmdStopDGTrimmerHeater' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,274,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,321,style,unusedFunction,The function 'edgeNotification' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,1171,style,unusedFunction,The function 'execBloodFlowTest' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,1071,style,unusedFunction,The function 'execDialInFlowTest' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,387,style,unusedFunction,The function 'execPresOcclTest' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,714,style,unusedFunction,The function 'getBootloaderFlag' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,356,style,unusedFunction,The function 'getCalibrationData' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,159,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,85,style,unusedFunction,The function 'getDGOpMode' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,102,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,143,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,127,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,361,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,304,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,345,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,329,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,584,style,unusedFunction,The function 'getDisinfectionDate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1115,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1149,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1183,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1027,style,unusedFunction,The function 'getFPGAStatus' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'getMfgData' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,210,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,193,style,unusedFunction,The function 'getPIControllerSignals' is never used. hdfirmware/firmware/FWCommon/RTC.c,410,style,unusedFunction,The function 'getRTCTimestamp' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,405,style,unusedFunction,The function 'getServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,502,style,unusedFunction,The function 'getTreatmentTime' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,542,style,unusedFunction,The function 'getWaterConsumption' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,72,style,unusedFunction,The function 'initDGInterface' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,379,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,225,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,182,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,197,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,430,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,175,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,190,style,unusedFunction,The function 'isPOSTPassed' is never used. hdfirmware/firmware/App/Drivers/Comm.c,289,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,244,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,65,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,78,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,248,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,72,style,unusedFunction,The function 'phantomInterrupt' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,452,style,unusedFunction,The function 'readLogData' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,79,style,unusedFunction,The function 'rtiNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,198,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,86,style,unusedFunction,The function 'rtiNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,205,style,unusedFunction,The function 'sciNotification' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,691,style,unusedFunction,The function 'setBootloaderFlag' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'setCalibrationData' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,195,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,420,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'setDisinfectionDate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,853,style,unusedFunction,The function 'setFPGAControl' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,293,style,unusedFunction,The function 'setMfgData' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,140,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,109,style,unusedFunction,The function 'setPressureLimits' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,151,style,unusedFunction,The function 'setOcclusionThreshold' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,120,style,unusedFunction,The function 'setPressureLimits' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,379,style,unusedFunction,The function 'setServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,476,style,unusedFunction,The function 'setTreatmentTime' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,517,style,unusedFunction,The function 'setWaterConsumption' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,250,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,251,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialOutFlow.c,286,style,unusedFunction,The function 'signalDialOutPumpHardStop' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,428,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)