Index: results/cppcheckError.csv =================================================================== diff -u -r270d3c64e17c324cdc52eadbc1a76ddc1decee86 -r361e8cae2edec18e5ba1a26690788b5c30ce4833 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 270d3c64e17c324cdc52eadbc1a76ddc1decee86) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 361e8cae2edec18e5ba1a26690788b5c30ce4833) @@ -1,77 +1,98 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Controllers/BloodFlow.c,811,style,unreadVariable,Variable 'flowStPt' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,813,style,unreadVariable,Variable 'measRotSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,814,style,unreadVariable,Variable 'measSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unreadVariable,Variable 'measMCSpd' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,816,style,unreadVariable,Variable 'measMCCurr' is assigned a value that is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,817,style,unreadVariable,Variable 'pumpPWMPctDutyCycle' is assigned a value that is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,99,style,unusedVariable,Unused variable: dir -hdfirmware/firmware/App/Modes/Dialysis.c,273,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,324,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePostTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,86,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatment.c,558,style,unreadVariable,Variable 'oldUFRate' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,85,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Services/Interrupts.c,147,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1272,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,815,style,unreadVariable,Variable 'flowStPt' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,817,style,unreadVariable,Variable 'measRotSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,818,style,unreadVariable,Variable 'measSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,819,style,unreadVariable,Variable 'measMCSpd' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,820,style,unreadVariable,Variable 'measMCCurr' is assigned a value that is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,821,style,unreadVariable,Variable 'pumpPWMPctDutyCycle' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,274,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,325,style,unreadVariable,Variable 'rejectReason' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,87,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePreTreat.c,87,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,131,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Services/Interrupts.c,180,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1325,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1149,error,uninitvar,Uninitialized variable: valveData +hdfirmware/firmware/App/Services/SystemCommMessages.c,2390,error,uninitvar,Uninitialized variable: result +hdfirmware/firmware/App/Services/SystemCommMessages.c,2416,error,uninitvar,Uninitialized variable: result hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1529,style,variableScope,The scope of the variable 'quotient' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'modulus' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1533,style,variableScope,The scope of the variable 'i' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/FWCommon/RTC.c,769,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,770,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1560,style,variableScope,The scope of the variable 'quotient' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1561,style,variableScope,The scope of the variable 'modulus' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1564,style,variableScope,The scope of the variable 'i' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1204,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,778,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,779,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,701,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/Utilities.c,214,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. -hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,143,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,122,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,641,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,559,style,unusedFunction,The function 'cmdStartDGTrimmerHeater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,544,style,unusedFunction,The function 'cmdStopDG' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,574,style,unusedFunction,The function 'cmdStopDGTrimmerHeater' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,274,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,321,style,unusedFunction,The function 'edgeNotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,1171,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,1071,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,387,style,unusedFunction,The function 'execPresOcclTest' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,714,style,unusedFunction,The function 'getBootloaderFlag' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,356,style,unusedFunction,The function 'getCalibrationData' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,361,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,304,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,345,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,329,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,584,style,unusedFunction,The function 'getDisinfectionDate' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1115,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1149,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1183,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. -hdfirmware/firmware/App/Services/FPGA.c,1027,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,311,style,unusedFunction,The function 'getMfgData' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,193,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/FWCommon/RTC.c,410,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,405,style,unusedFunction,The function 'getServiceDate' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,502,style,unusedFunction,The function 'getTreatmentTime' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,542,style,unusedFunction,The function 'getWaterConsumption' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,430,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,175,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,190,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,289,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,78,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,248,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,72,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,452,style,unusedFunction,The function 'readLogData' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,86,style,unusedFunction,The function 'rtiNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,205,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,691,style,unusedFunction,The function 'setBootloaderFlag' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'setCalibrationData' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,420,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'setDisinfectionDate' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,293,style,unusedFunction,The function 'setMfgData' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,151,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,120,style,unusedFunction,The function 'setPressureLimits' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,379,style,unusedFunction,The function 'setServiceDate' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,476,style,unusedFunction,The function 'setTreatmentTime' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,517,style,unusedFunction,The function 'setWaterConsumption' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,428,style,unusedFunction,The function 'writeLogData' is never used. +hdfirmware/firmware/App/Drivers/InternalADC.c,114,style,unusedFunction,The function 'adcNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,177,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,156,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,642,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,560,style,unusedFunction,The function 'cmdStartDGTrimmerHeater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,545,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,575,style,unusedFunction,The function 'cmdStopDGTrimmerHeater' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,322,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,369,style,unusedFunction,The function 'edgeNotification' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1359,style,unusedFunction,The function 'enableFPGAValvesBypassControl' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,388,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/FWCommon/Accel.c,647,style,unusedFunction,The function 'getAccelCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,1258,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,728,style,unusedFunction,The function 'getBootloaderFlag' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,362,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,305,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,346,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,330,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,1229,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,594,style,unusedFunction,The function 'getDisinfectionDate' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1136,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1170,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1204,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'getMfgData' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,271,style,unusedFunction,The function 'getOrigArterialPressureHighLimit_mmHg' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,266,style,unusedFunction,The function 'getOrigArterialPressureLowLimit_mmHg' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,251,style,unusedFunction,The function 'getOrigBloodFlowRate_mL_min' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,256,style,unusedFunction,The function 'getOrigDialysateFlowRate_mL_min' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,261,style,unusedFunction,The function 'getOrigTreatmentDuration_min' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,286,style,unusedFunction,The function 'getOrigUFVolume_L' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,281,style,unusedFunction,The function 'getOrigVenousPressureHighLimit_mmHg' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,276,style,unusedFunction,The function 'getOrigVenousPressureLowLimit_mmHg' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,194,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/FWCommon/RTC.c,419,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,415,style,unusedFunction,The function 'getServiceDate' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,232,style,unusedFunction,The function 'getTreatmentParameterF32' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,213,style,unusedFunction,The function 'getTreatmentParameterU32' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,512,style,unusedFunction,The function 'getTreatmentTime' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,226,style,unusedFunction,The function 'getValvePosition' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,552,style,unusedFunction,The function 'getWaterConsumption' is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,2496,style,unusedFunction,The function 'handleSetHDValvePosition' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,174,style,unusedFunction,The function 'handleWaitForUI2ConfirmState' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,167,style,unusedFunction,The function 'handleWaitForUI2SendState' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,453,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,209,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,224,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Drivers/Comm.c,290,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,79,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,242,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,97,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,462,style,unusedFunction,The function 'readLogData' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,120,style,unusedFunction,The function 'rtiNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,251,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,705,style,unusedFunction,The function 'setBootloaderFlag' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,421,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,568,style,unusedFunction,The function 'setDisinfectionDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,297,style,unusedFunction,The function 'setMfgData' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,152,style,unusedFunction,The function 'setOcclusionThreshold' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,121,style,unusedFunction,The function 'setPressureLimits' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,389,style,unusedFunction,The function 'setServiceDate' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,197,style,unusedFunction,The function 'setTreatmentParameterF32' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,181,style,unusedFunction,The function 'setTreatmentParameterU32' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,486,style,unusedFunction,The function 'setTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,527,style,unusedFunction,The function 'setWaterConsumption' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,1020,style,unusedFunction,The function 'testResetValvesDataPublishInterval' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,1075,style,unusedFunction,The function 'testResetValvesPositionOverride' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,995,style,unusedFunction,The function 'testSetValvesDataPublishInterval' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,1045,style,unusedFunction,The function 'testSetValvesPositionOverride' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,438,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)