Index: results/cppcheckError.csv =================================================================== diff -u -r766708fceb0bdf1af8c7897df29d4f5036bfd3db -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 766708fceb0bdf1af8c7897df29d4f5036bfd3db) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -1,12 +1,10 @@ File, Line No., Severity, Issue, Description hdfirmware/firmware/App/Modes/ModeFault.c,72,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModePostTreat.c,71,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,78,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModeTreatment.c,882,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,384,style,redundantAssignment,Variable 'accepted' is reassigned a value before the old one has been used. hdfirmware/firmware/App/Services/Interrupts.c,175,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,4000,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1412,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,3994,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1567,style,variableScope,The scope of the variable 'modulus' can be reduced. @@ -21,37 +19,38 @@ hdfirmware/firmware/App/Drivers/InternalADC.c,115,style,unusedFunction,The function 'adcNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,172,style,unusedFunction,The function 'canErrorNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,668,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,572,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,834,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,738,style,unusedFunction,The function 'cmdStopDG' is never used. hdfirmware/firmware/App/Services/Interrupts.c,315,style,unusedFunction,The function 'dmaGroupANotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,361,style,unusedFunction,The function 'edgeNotification' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,207,style,unusedFunction,The function 'execAirTrapMonitorPriming' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,441,style,unusedFunction,The function 'execAirTrapTest' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,152,style,unusedFunction,The function 'execPreTreatmentReservoirMgmt' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,539,style,unusedFunction,The function 'execPresOcclTest' is never used. hdfirmware/firmware/FWCommon/Accel.c,674,style,unusedFunction,The function 'getAccelCalibration' is never used. hdfirmware/firmware/App/Controllers/BloodFlow.c,1340,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. hdfirmware/firmware/App/Controllers/BloodFlow.c,400,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,537,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,399,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,345,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,384,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,369,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,451,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,397,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,436,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,421,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. hdfirmware/firmware/App/Controllers/DialInFlow.c,1302,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. hdfirmware/firmware/App/Services/FPGA.c,1169,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. hdfirmware/firmware/App/Services/FPGA.c,1201,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. hdfirmware/firmware/App/Services/FPGA.c,1233,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,466,style,unusedFunction,The function 'getLoadCellWeightInGrams' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. hdfirmware/firmware/App/Services/PIControllers.c,229,style,unusedFunction,The function 'getPIControllerSignals' is never used. hdfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. -hdfirmware/firmware/App/Controllers/Valves.c,343,style,unusedFunction,The function 'getValvePosition' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,346,style,unusedFunction,The function 'getValvePosition' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. hdfirmware/firmware/FWCommon/Utilities.c,418,style,unusedFunction,The function 'hexStrToDec' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,522,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,184,style,unusedFunction,The function 'initPreTreatmentReservoirMgmt' is never used. +hdfirmware/firmware/App/Modes/Prime.c,83,style,unusedFunction,The function 'initPrime' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,137,style,unusedFunction,The function 'isCartridgeLoaded' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,212,style,unusedFunction,The function 'isPOSTCompleted' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'isPOSTPassed' is never used. @@ -64,13 +63,11 @@ hdfirmware/firmware/App/Services/Interrupts.c,245,style,unusedFunction,The function 'sciNotification' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,566,style,unusedFunction,The function 'setAlarmAudioVolume' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'setBootloaderFlag' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,455,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,580,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'setDisinfectionDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,323,style,unusedFunction,The function 'setMfgData' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,440,style,unusedFunction,The function 'setServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,534,style,unusedFunction,The function 'setTreatmentTime' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,572,style,unusedFunction,The function 'setWaterConsumption' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,756,style,unusedFunction,The function 'testResetAlarmStatusPublishIntervalOverride' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,731,style,unusedFunction,The function 'testSetAlarmStatusPublishIntervalOverride' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,487,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)