Index: results/cppcheckError.csv =================================================================== diff -u -re279d75471594eb29740b9df8cb2d35358df3a7d -r3c45b8930e1bbd1ff5757ec6d9e37e3d7a464fc3 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision e279d75471594eb29740b9df8cb2d35358df3a7d) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 3c45b8930e1bbd1ff5757ec6d9e37e3d7a464fc3) @@ -3,63 +3,66 @@ hdfirmware/firmware/App/Modes/ModePostTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModePreTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModePrescription.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatment.c,144,style,unusedVariable,Unused variable: elapsedTreatmentTimeInSecs -hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/Interrupts.c,139,style,variableScope,The scope of the variable 'debugStr' can be reduced. hdfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,368,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,360,style,unreadVariable,Variable 'result' is assigned a value that is never used. hdfirmware/firmware/FWCommon/FlashDriver/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,998,warning,nullPointer,Possible null pointer dereference: data -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1094,style,variableScope,The scope of the variable 'quotient' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1095,style,variableScope,The scope of the variable 'modulus' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1098,style,variableScope,The scope of the variable 'i' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,147,style,unusedStructMember,struct member 'WATER_CONSUPTION_T::waterConsumption' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,693,style,unreadVariable,Variable 'calcCRC' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,694,style,unreadVariable,Variable 'CRC' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/RTC.c,1194,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/FWCommon/RTC.c,764,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,765,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'quotient' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1531,style,variableScope,The scope of the variable 'modulus' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1534,style,variableScope,The scope of the variable 'i' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1203,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,776,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,777,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,698,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. hdfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,283,style,unusedFunction,The function 'activateAlarm1Data' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,306,style,unusedFunction,The function 'activateAlarm2Data' is never used. +hdfirmware/firmware/FWCommon/FlashDriver/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. hdfirmware/firmware/App/Drivers/SafetyShutdown.c,53,style,unusedFunction,The function 'activateSafetyShutdown' is never used. hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,227,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,879,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,863,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'execNVDataMgmt' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,408,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,135,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,114,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,266,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,876,style,unusedFunction,The function 'execBloodFlowTest' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,860,style,unusedFunction,The function 'execDialInFlowTest' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,729,style,unusedFunction,The function 'execNVDataMgmt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,607,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,376,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,715,style,unusedFunction,The function 'getBootloaderFlag' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,357,style,unusedFunction,The function 'getCalibrationData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,585,style,unusedFunction,The function 'getDisinfectionDate' is never used. hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,298,style,unusedFunction,The function 'getMfgData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,312,style,unusedFunction,The function 'getMfgData' is never used. hdfirmware/firmware/App/Services/PIControllers.c,210,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/FWCommon/RTC.c,409,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,243,style,unusedFunction,The function 'initNVDataMgmt' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,364,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,228,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,169,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,184,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/FWCommon/RTC.c,416,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,406,style,unusedFunction,The function 'getServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,503,style,unusedFunction,The function 'getTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,543,style,unusedFunction,The function 'getWaterConsumption' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,374,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,225,style,unusedFunction,The function 'isDGCommunicating' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,172,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,187,style,unusedFunction,The function 'isPOSTPassed' is never used. hdfirmware/firmware/App/Drivers/Comm.c,289,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,247,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,244,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,64,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,453,style,unusedFunction,The function 'readLogData' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,78,style,unusedFunction,The function 'rtiNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,197,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,719,style,unusedFunction,The function 'sendDialysateTempTargetsToDG' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,692,style,unusedFunction,The function 'setBootloaderFlag' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,337,style,unusedFunction,The function 'setCalibrationData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,559,style,unusedFunction,The function 'setDisinfectionDate' is never used. hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,385,style,unusedFunction,The function 'setLitersOfFilteredWater' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,269,style,unusedFunction,The function 'setMfgData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,294,style,unusedFunction,The function 'setMfgData' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,142,style,unusedFunction,The function 'setOcclusionThreshold' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,111,style,unusedFunction,The function 'setPressureLimits' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,361,style,unusedFunction,The function 'setTreatmentTime' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,253,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,254,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,380,style,unusedFunction,The function 'setServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,477,style,unusedFunction,The function 'setTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,518,style,unusedFunction,The function 'setWaterConsumption' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,250,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,251,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. hdfirmware/firmware/App/Controllers/DialOutFlow.c,286,style,unusedFunction,The function 'signalDialOutPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,50,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,37,style,unusedFunction,The function 'taskPriority' is never used. -hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,116,style,unusedFunction,The function 'transitionToDialysis' is never used. +hdfirmware/firmware/App/Modes/Dialysis.c,117,style,unusedFunction,The function 'transitionToDialysis' is never used. hdfirmware/firmware/App/Modes/TreatmentStop.c,53,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,313,style,unusedFunction,The function 'writeLogData' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,429,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)