Index: results/cppcheckError.csv =================================================================== diff -u -re279d75471594eb29740b9df8cb2d35358df3a7d -r55eba4147c8b6eb6ad5f87579f3133802ad876dc --- results/cppcheckError.csv (.../cppcheckError.csv) (revision e279d75471594eb29740b9df8cb2d35358df3a7d) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 55eba4147c8b6eb6ad5f87579f3133802ad876dc) @@ -1,65 +1,71 @@ File, Line No., Severity, Issue, Description -hdfirmware/firmware/App/Modes/ModeOpParams.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePostTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. +hdfirmware/firmware/App/Modes/ModePostTreat.c,74,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModePreTreat.c,81,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePrescription.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModeTreatment.c,144,style,unusedVariable,Unused variable: elapsedTreatmentTimeInSecs -hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/PIControllers.c,81,style,variableScope,The scope of the variable 'controller' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,368,style,unreadVariable,Variable 'result' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/FlashDriver/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,998,warning,nullPointer,Possible null pointer dereference: data -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1094,style,variableScope,The scope of the variable 'quotient' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1095,style,variableScope,The scope of the variable 'modulus' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,1098,style,variableScope,The scope of the variable 'i' can be reduced. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,147,style,unusedStructMember,struct member 'WATER_CONSUPTION_T::waterConsumption' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,693,style,unreadVariable,Variable 'calcCRC' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,694,style,unreadVariable,Variable 'CRC' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/RTC.c,1194,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/FWCommon/RTC.c,764,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,765,style,variableScope,The scope of the variable 'decimalLow' can be reduced. -hdfirmware/firmware/FWCommon/RTC.c,692,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. -hdfirmware/firmware/FWCommon/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,283,style,unusedFunction,The function 'activateAlarm1Data' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,306,style,unusedFunction,The function 'activateAlarm2Data' is never used. -hdfirmware/firmware/App/Drivers/SafetyShutdown.c,53,style,unusedFunction,The function 'activateSafetyShutdown' is never used. -hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,227,style,unusedFunction,The function 'dmaGroupANotification' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,879,style,unusedFunction,The function 'execBloodFlowTest' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,863,style,unusedFunction,The function 'execDialInFlowTest' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'execNVDataMgmt' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,408,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,376,style,unusedFunction,The function 'execPresOcclTest' is never used. -hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used. -hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used. -hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,298,style,unusedFunction,The function 'getMfgData' is never used. -hdfirmware/firmware/App/Services/PIControllers.c,210,style,unusedFunction,The function 'getPIControllerSignals' is never used. -hdfirmware/firmware/FWCommon/RTC.c,409,style,unusedFunction,The function 'getRTCTimestamp' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,243,style,unusedFunction,The function 'initNVDataMgmt' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,364,style,unusedFunction,The function 'isAlarmActive' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,228,style,unusedFunction,The function 'isDGCommunicating' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,169,style,unusedFunction,The function 'isPOSTCompleted' is never used. -hdfirmware/firmware/App/Modes/ModeInitPOST.c,184,style,unusedFunction,The function 'isPOSTPassed' is never used. -hdfirmware/firmware/App/Drivers/Comm.c,289,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. -hdfirmware/firmware/App/Services/SystemComm.c,247,style,unusedFunction,The function 'isUICommunicating' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used. -hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used. -hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,385,style,unusedFunction,The function 'setLitersOfFilteredWater' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,269,style,unusedFunction,The function 'setMfgData' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,142,style,unusedFunction,The function 'setOcclusionThreshold' is never used. -hdfirmware/firmware/App/Controllers/PresOccl.c,111,style,unusedFunction,The function 'setPressureLimits' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,361,style,unusedFunction,The function 'setTreatmentTime' is never used. -hdfirmware/firmware/App/Controllers/BloodFlow.c,253,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialInFlow.c,254,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used. -hdfirmware/firmware/App/Controllers/DialOutFlow.c,286,style,unusedFunction,The function 'signalDialOutPumpHardStop' is never used. -hdfirmware/firmware/App/Tasks/TaskGeneral.c,50,style,unusedFunction,The function 'taskGeneral' is never used. -hdfirmware/firmware/App/Tasks/TaskPriority.c,37,style,unusedFunction,The function 'taskPriority' is never used. -hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used. -hdfirmware/firmware/App/Modes/Dialysis.c,116,style,unusedFunction,The function 'transitionToDialysis' is never used. -hdfirmware/firmware/App/Modes/TreatmentStop.c,53,style,unusedFunction,The function 'transitionToTreatmentStop' is never used. -hdfirmware/firmware/FWCommon/NVDataMgmt.c,313,style,unusedFunction,The function 'writeLogData' is never used. +hdfirmware/firmware/App/Modes/ModeTreatment.c,733,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. +hdfirmware/firmware/App/Services/Interrupts.c,175,style,variableScope,The scope of the variable 'debugStr' can be reduced. +hdfirmware/firmware/App/Services/SystemCommMessages.c,1306,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1526,style,variableScope,The scope of the variable 'quotient' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1527,style,variableScope,The scope of the variable 'modulus' can be reduced. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'i' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. +hdfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. +hdfirmware/firmware/FWCommon/RTC.c,706,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used. +hdfirmware/firmware/FWCommon/Utilities.c,246,style,variableScope,The scope of the variable 'timeInMS' can be reduced. +hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used. +hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used. +hdfirmware/firmware/App/Drivers/InternalADC.c,115,style,unusedFunction,The function 'adcNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,172,style,unusedFunction,The function 'canErrorNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,619,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,528,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,315,style,unusedFunction,The function 'dmaGroupANotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,361,style,unusedFunction,The function 'edgeNotification' is never used. +hdfirmware/firmware/App/Controllers/AirTrap.c,207,style,unusedFunction,The function 'execAirTrapMonitorPriming' is never used. +hdfirmware/firmware/App/Controllers/AirTrap.c,441,style,unusedFunction,The function 'execAirTrapTest' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,340,style,unusedFunction,The function 'execPresOcclTest' is never used. +hdfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,1350,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. +hdfirmware/firmware/App/Controllers/BloodFlow.c,394,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,724,style,unusedFunction,The function 'getBootloaderFlag' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,490,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,355,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,301,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,340,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,325,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DialInFlow.c,1296,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getDisinfectionDate' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1131,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1163,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Services/FPGA.c,1195,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,332,style,unusedFunction,The function 'getMfgData' is never used. +hdfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used. +hdfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,425,style,unusedFunction,The function 'getServiceDate' is never used. +hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,701,style,unusedFunction,The function 'getTreatmentParameterS32' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,518,style,unusedFunction,The function 'getTreatmentTime' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,343,style,unusedFunction,The function 'getValvePosition' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,555,style,unusedFunction,The function 'getWaterConsumption' is never used. +hdfirmware/firmware/FWCommon/Utilities.c,418,style,unusedFunction,The function 'hexStrToDec' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,475,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Services/AlarmMgmt.c,504,style,unusedFunction,The function 'isAlarmRecoverable' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,202,style,unusedFunction,The function 'isPOSTCompleted' is never used. +hdfirmware/firmware/App/Modes/ModeInitPOST.c,215,style,unusedFunction,The function 'isPOSTPassed' is never used. +hdfirmware/firmware/App/Drivers/Comm.c,263,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. +hdfirmware/firmware/App/Drivers/SafetyShutdown.c,76,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. +hdfirmware/firmware/App/Services/SystemComm.c,237,style,unusedFunction,The function 'isUICommunicating' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,95,style,unusedFunction,The function 'phantomInterrupt' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'readLogData' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,117,style,unusedFunction,The function 'rtiNotification' is never used. +hdfirmware/firmware/App/Services/Interrupts.c,245,style,unusedFunction,The function 'sciNotification' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,703,style,unusedFunction,The function 'setBootloaderFlag' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,411,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,570,style,unusedFunction,The function 'setDisinfectionDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'setMfgData' is never used. +hdfirmware/firmware/App/Controllers/PresOccl.c,114,style,unusedFunction,The function 'setOcclusionThreshold' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,400,style,unusedFunction,The function 'setServiceDate' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,494,style,unusedFunction,The function 'setTreatmentTime' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,532,style,unusedFunction,The function 'setWaterConsumption' is never used. +hdfirmware/firmware/FWCommon/NVDataMgmt.c,447,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)