Index: results/cppcheckError.csv
===================================================================
diff -u -rf9890311898663a704692870ffb53d43cea0d20b -r4d078410778e8253c7bc40cd0b425c7b751f52e4
--- results/cppcheckError.csv	(.../cppcheckError.csv)	(revision f9890311898663a704692870ffb53d43cea0d20b)
+++ results/cppcheckError.csv	(.../cppcheckError.csv)	(revision 4d078410778e8253c7bc40cd0b425c7b751f52e4)
@@ -1,47 +1,68 @@
 File, Line No., Severity, Issue, Description
-hdfirmware/firmware/App/Services/Interrupts.c,100,style,variableScope,The scope of the variable 'debugStr' can be reduced.
-hdfirmware/firmware/App/Services/PIControllers.c,77,style,variableScope,The scope of the variable 'controller' can be reduced.
-hdfirmware/firmware/FWCommon/RTC.c,1197,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used.
-hdfirmware/firmware/FWCommon/RTC.c,695,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used.
-hdfirmware/firmware/irqDispatch_c.c,75,style,unusedFunction,The function 'C_irqDispatch' is never used.
-hdfirmware/firmware/App/Services/AlarmMgmt.c,278,style,unusedFunction,The function 'activateAlarm1Data' is never used.
-hdfirmware/firmware/App/Services/AlarmMgmt.c,301,style,unusedFunction,The function 'activateAlarm2Data' is never used.
-hdfirmware/firmware/App/Drivers/InternalADC.c,112,style,unusedFunction,The function 'adcNotification' is never used.
-hdfirmware/firmware/App/Services/Interrupts.c,96,style,unusedFunction,The function 'canErrorNotification' is never used.
-hdfirmware/firmware/App/Services/Interrupts.c,75,style,unusedFunction,The function 'canMessageNotification' is never used.
-hdfirmware/firmware/App/Services/Interrupts.c,230,style,unusedFunction,The function 'dmaGroupANotification' is never used.
-hdfirmware/firmware/App/Controllers/BloodFlow.c,847,style,unusedFunction,The function 'execBloodFlowTest' is never used.
-hdfirmware/firmware/App/Controllers/DialInFlow.c,831,style,unusedFunction,The function 'execDialInFlowTest' is never used.
-hdfirmware/firmware/App/Modes/Dialysis.c,60,style,unusedFunction,The function 'execDialysis' is never used.
-hdfirmware/firmware/App/Controllers/PresOccl.c,389,style,unusedFunction,The function 'execPresOcclTest' is never used.
-hdfirmware/firmware/App/Modes/TreatmentStop.c,62,style,unusedFunction,The function 'execTreatmentStop' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,558,style,unusedFunction,The function 'getDataFromRAM' is never used.
-hdfirmware/firmware/App/Services/FPGA.c,839,style,unusedFunction,The function 'getFPGAId' is never used.
-hdfirmware/firmware/App/Services/FPGA.c,854,style,unusedFunction,The function 'getFPGARev' is never used.
-hdfirmware/firmware/App/Services/FPGA.c,869,style,unusedFunction,The function 'getFPGAStatus' is never used.
-hdfirmware/firmware/App/Services/PIControllers.c,206,style,unusedFunction,The function 'getPIControllerSignals' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,522,style,unusedFunction,The function 'getRTCRAMState' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,537,style,unusedFunction,The function 'getRTCRAMStatus' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,411,style,unusedFunction,The function 'getRTCTimestamp' is never used.
-hdfirmware/firmware/App/Services/AlarmMgmt.c,359,style,unusedFunction,The function 'isAlarmActive' is never used.
-hdfirmware/firmware/App/Services/SystemComm.c,212,style,unusedFunction,The function 'isDGCommunicating' is never used.
-hdfirmware/firmware/App/Modes/ModeInitPOST.c,170,style,unusedFunction,The function 'isPOSTCompleted' is never used.
-hdfirmware/firmware/App/Modes/ModeInitPOST.c,185,style,unusedFunction,The function 'isPOSTPassed' is never used.
-hdfirmware/firmware/App/Drivers/Comm.c,273,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used.
-hdfirmware/firmware/App/Services/SystemComm.c,231,style,unusedFunction,The function 'isUICommunicating' is never used.
-hdfirmware/firmware/App/Services/Interrupts.c,60,style,unusedFunction,The function 'phantomInterrupt' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,476,style,unusedFunction,The function 'readFromRAM' is never used.
-hdfirmware/firmware/App/Services/Interrupts.c,158,style,unusedFunction,The function 'sciNotification' is never used.
-hdfirmware/firmware/App/Controllers/DialInFlow.c,184,style,unusedFunction,The function 'setDialInPumpTargetFlowRate' is never used.
-hdfirmware/firmware/App/Services/FPGA.c,883,style,unusedFunction,The function 'setFPGAControl' is never used.
-hdfirmware/firmware/App/Controllers/PresOccl.c,143,style,unusedFunction,The function 'setOcclusionThreshold' is never used.
-hdfirmware/firmware/App/Controllers/PresOccl.c,112,style,unusedFunction,The function 'setPressureLimits' is never used.
-hdfirmware/firmware/App/Controllers/BloodFlow.c,247,style,unusedFunction,The function 'signalBloodPumpHardStop' is never used.
-hdfirmware/firmware/App/Controllers/DialInFlow.c,248,style,unusedFunction,The function 'signalDialInPumpHardStop' is never used.
-hdfirmware/firmware/App/Tasks/TaskGeneral.c,49,style,unusedFunction,The function 'taskGeneral' is never used.
-hdfirmware/firmware/App/Tasks/TaskPriority.c,36,style,unusedFunction,The function 'taskPriority' is never used.
-hdfirmware/firmware/App/Tasks/TaskTimer.c,32,style,unusedFunction,The function 'taskTimer' is never used.
-hdfirmware/firmware/App/Modes/Dialysis.c,47,style,unusedFunction,The function 'transitionToDialysis' is never used.
-hdfirmware/firmware/App/Modes/TreatmentStop.c,48,style,unusedFunction,The function 'transitionToTreatmentStop' is never used.
-hdfirmware/firmware/FWCommon/RTC.c,428,style,unusedFunction,The function 'writeToRAM' is never used.
+hdfirmware/firmware/App/Modes/ModePreTreat.c,82,style,unreadVariable,Variable 'stop' is assigned a value that is never used.
+hdfirmware/firmware/App/Modes/ModeTreatment.c,742,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,180,style,variableScope,The scope of the variable 'debugStr' can be reduced.
+hdfirmware/firmware/App/Services/SystemCommMessages.c,1309,style,unreadVariable,Variable 'result' is assigned a value that is never used.
+hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,1568,style,variableScope,The scope of the variable 'quotient' can be reduced.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,1569,style,variableScope,The scope of the variable 'modulus' can be reduced.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,1572,style,variableScope,The scope of the variable 'i' can be reduced.
+hdfirmware/firmware/FWCommon/RTC.c,1221,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used.
+hdfirmware/firmware/FWCommon/RTC.c,796,style,variableScope,The scope of the variable 'decimalHigh' can be reduced.
+hdfirmware/firmware/FWCommon/RTC.c,797,style,variableScope,The scope of the variable 'decimalLow' can be reduced.
+hdfirmware/firmware/FWCommon/RTC.c,718,style,unreadVariable,Variable 'controlReg2' is assigned a value that is never used.
+hdfirmware/firmware/FWCommon/Utilities.c,246,style,variableScope,The scope of the variable 'timeInMS' can be reduced.
+hdfirmware/firmware/FWCommon/irqDispatch_c.c,76,style,unusedFunction,The function 'C_irqDispatch' is never used.
+hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,68,style,unusedFunction,The function 'Fapi_serviceWatchdogTimer' is never used.
+hdfirmware/firmware/App/Drivers/InternalADC.c,117,style,unusedFunction,The function 'adcNotification' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,177,style,unusedFunction,The function 'canErrorNotification' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,156,style,unusedFunction,The function 'canMessageNotification' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,645,style,unusedFunction,The function 'cmdDGSampleWater' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,548,style,unusedFunction,The function 'cmdStopDG' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,322,style,unusedFunction,The function 'dmaGroupANotification' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,369,style,unusedFunction,The function 'edgeNotification' is never used.
+hdfirmware/firmware/App/Controllers/PresOccl.c,356,style,unusedFunction,The function 'execPresOcclTest' is never used.
+hdfirmware/firmware/FWCommon/Accel.c,680,style,unusedFunction,The function 'getAccelCalibration' is never used.
+hdfirmware/firmware/App/Controllers/BloodFlow.c,1384,style,unusedFunction,The function 'getBloodFlowCalibration' is never used.
+hdfirmware/firmware/App/Controllers/BloodFlow.c,399,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'getBootloaderFlag' is never used.
+hdfirmware/firmware/App/Services/AlarmMgmt.c,489,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,365,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,308,style,unusedFunction,The function 'getDGPressure' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,349,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,333,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used.
+hdfirmware/firmware/App/Controllers/DialInFlow.c,1330,style,unusedFunction,The function 'getDialInFlowCalibration' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,611,style,unusedFunction,The function 'getDisinfectionDate' is never used.
+hdfirmware/firmware/App/Services/FPGA.c,1642,style,unusedFunction,The function 'getFPGAAirTrapLevels' is never used.
+hdfirmware/firmware/App/Services/FPGA.c,1131,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used.
+hdfirmware/firmware/App/Services/FPGA.c,1163,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used.
+hdfirmware/firmware/App/Services/FPGA.c,1195,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,336,style,unusedFunction,The function 'getMfgData' is never used.
+hdfirmware/firmware/App/Services/PIControllers.c,192,style,unusedFunction,The function 'getPIControllerSignals' is never used.
+hdfirmware/firmware/FWCommon/RTC.c,427,style,unusedFunction,The function 'getRTCTimestamp' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,433,style,unusedFunction,The function 'getServiceDate' is never used.
+hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,719,style,unusedFunction,The function 'getTreatmentParameterS32' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,530,style,unusedFunction,The function 'getTreatmentTime' is never used.
+hdfirmware/firmware/App/Controllers/Valves.c,324,style,unusedFunction,The function 'getValvePosition' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,569,style,unusedFunction,The function 'getWaterConsumption' is never used.
+hdfirmware/firmware/App/Services/AlarmMgmt.c,474,style,unusedFunction,The function 'isAlarmActive' is never used.
+hdfirmware/firmware/App/Modes/ModeInitPOST.c,205,style,unusedFunction,The function 'isPOSTCompleted' is never used.
+hdfirmware/firmware/App/Modes/ModeInitPOST.c,219,style,unusedFunction,The function 'isPOSTPassed' is never used.
+hdfirmware/firmware/App/Drivers/Comm.c,279,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used.
+hdfirmware/firmware/App/Drivers/SafetyShutdown.c,79,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used.
+hdfirmware/firmware/App/Services/SystemComm.c,242,style,unusedFunction,The function 'isUICommunicating' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,97,style,unusedFunction,The function 'phantomInterrupt' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,481,style,unusedFunction,The function 'readLogData' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,120,style,unusedFunction,The function 'rtiNotification' is never used.
+hdfirmware/firmware/App/Services/Interrupts.c,251,style,unusedFunction,The function 'sciNotification' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,721,style,unusedFunction,The function 'setBootloaderFlag' is never used.
+hdfirmware/firmware/App/Controllers/DGInterface.c,424,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,585,style,unusedFunction,The function 'setDisinfectionDate' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,318,style,unusedFunction,The function 'setMfgData' is never used.
+hdfirmware/firmware/App/Controllers/PresOccl.c,118,style,unusedFunction,The function 'setOcclusionThreshold' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'setServiceDate' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,505,style,unusedFunction,The function 'setTreatmentTime' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,545,style,unusedFunction,The function 'setWaterConsumption' is never used.
+hdfirmware/firmware/App/Modes/ModePreTreat.c,108,style,unusedFunction,The function 'signalUserBeginningTreatment' is never used.
+hdfirmware/firmware/FWCommon/NVDataMgmt.c,456,style,unusedFunction,The function 'writeLogData' is never used.
 ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)