Index: firmware/.launches/HD.launch =================================================================== diff -u -rf4545d449a2a2f9353307a55d2bce9e150591c3d -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- firmware/.launches/HD.launch (.../HD.launch) (revision f4545d449a2a2f9353307a55d2bce9e150591c3d) +++ firmware/.launches/HD.launch (.../HD.launch) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -7,6 +7,7 @@ + @@ -21,11 +22,14 @@ + + + Index: firmware/App/Controllers/Valves.c =================================================================== diff -u -r766708fceb0bdf1af8c7897df29d4f5036bfd3db -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- firmware/App/Controllers/Valves.c (.../Valves.c) (revision 766708fceb0bdf1af8c7897df29d4f5036bfd3db) +++ firmware/App/Controllers/Valves.c (.../Valves.c) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -19,12 +19,15 @@ #include "reg_het.h" #include "gio.h" -#include "Valves.h" #include "FPGA.h" -#include "Timers.h" -#include "TaskPriority.h" +#include "SafetyShutdown.h" #include "SystemCommMessages.h" +#include "TaskPriority.h" +#include "Timers.h" +#include "Valves.h" + + /** * @addtogroup Valves * @{ @@ -821,7 +824,9 @@ // If we are in Pos B, enable current relaxation if ( commandedPositionEnum == VALVE_POSITION_B_OPEN ) { + // Enable current relaxation setFPGAValveSetPoint( valve, currentPosition, TRUE ); + valvesStatus[ valve ].hasTransitionBeenRequested = TRUE; } // Go back to Idle state @@ -836,6 +841,11 @@ #ifndef DISABLE_VALVE_ALARMS SET_ALARM_WITH_1_U32_DATA( ALARM_ID_HD_VALVE_TRANSITION_TIMEOUT, (U32)valve ); #endif + // If the valve transition timeout is active and the valve's commanded positions is position C, activate safety shutdown + if ( isAlarmActive( ALARM_ID_HD_VALVE_TRANSITION_TIMEOUT ) && valvesStatus[ valve ].commandedPosition == VALVE_POSITION_C_CLOSE ) + { + activateSafetyShutdown(); + } } // Check if the valve is close to the temporary target position and if it is, assign the next target position else if ( abs( currentPosition - targetPosition ) < MAX_DEVIATION_FROM_TARGET_IN_COUNTS ) Index: results/Build_Status_Report.csv =================================================================== diff -u -raf02c3139b58ff98e2beb38704955d748e30ea35 -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision af02c3139b58ff98e2beb38704955d748e30ea35) +++ results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -1,36 +1,43 @@ Running Project, hdfirmware -Date, Mon Jan 4 13:01:58 PST 2021 +Date, Thu Jan 14 14:54:31 PST 2021 VectorCAST Pass/Fail Status, Failed The following test(s) failed: VectorCAST_MinGW_C_LinuxTestSuite_ACCEL_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_management_report.html +VectorCAST_MinGW_C_LinuxTestSuite_DIALYSIS_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_ACCEL_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_management_report.html +VectorCAST_MinGW_C_LinuxTestSuite_INT_DGINTERFACE_management_report.html +VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALOUTFLOW_management_report.html +VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALYSIS_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENTPARAMS_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_SYSTEMCOMMMESSAGES_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_INT_UTILITIES_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMM_management_report.html VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMMMESSAGES_management_report.html +VectorCAST_MinGW_C_LinuxTestSuite_VALVES_management_report.html Unit Test Coverage, Failed The following test(s) failed: VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENT_management_report.html,Statement_Cov(%):,86,Branch_Cov(%):,93,Pairs_Cov(%):,98 VectorCAST_MinGW_C_LinuxTestSuite_AIRTRAP_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,98,Pairs_Cov(%):,100 -VectorCAST_MinGW_C_LinuxTestSuite_DGINTERFACE_management_report.html,Statement_Cov(%):,99,Branch_Cov(%):,95,Pairs_Cov(%):,91 -VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_management_report.html,Statement_Cov(%):,75,Branch_Cov(%):,71,Pairs_Cov(%):,59 +VectorCAST_MinGW_C_LinuxTestSuite_DGINTERFACE_management_report.html,Statement_Cov(%):,74,Branch_Cov(%):,67,Pairs_Cov(%):,65 +VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_management_report.html,Statement_Cov(%):,73,Branch_Cov(%):,70,Pairs_Cov(%):,57 VectorCAST_MinGW_C_LinuxTestSuite_OPERATIONMODES_management_report.html,Statement_Cov(%):,78,Branch_Cov(%):,85,Pairs_Cov(%):,100 VectorCAST_MinGW_C_LinuxTestSuite_DIALINFLOW_management_report.html,Statement_Cov(%):,99,Branch_Cov(%):,98,Pairs_Cov(%):,96 -VectorCAST_MinGW_C_LinuxTestSuite_VALVES_management_report.html,Statement_Cov(%):,100,Branch_Cov(%):,99,Pairs_Cov(%):,96 +VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_management_report.html,Statement_Cov(%):,98,Branch_Cov(%):,97,Pairs_Cov(%):,92 +VectorCAST_MinGW_C_LinuxTestSuite_VALVES_management_report.html,Statement_Cov(%):,99,Branch_Cov(%):,98,Pairs_Cov(%):,93 VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMM_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,98,Pairs_Cov(%):,98 +VectorCAST_MinGW_C_LinuxTestSuite_PICONTROLLERS_management_report.html,Statement_Cov(%):,95,Branch_Cov(%):,89,Pairs_Cov(%):,80 VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENTPARAMS_management_report.html,Statement_Cov(%):,95,Branch_Cov(%):,96,Pairs_Cov(%):,97 VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_management_report.html,Statement_Cov(%):,99,Branch_Cov(%):,98,Pairs_Cov(%):,96 VectorCAST_MinGW_C_LinuxTestSuite_ACCEL_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,99,Pairs_Cov(%):,97 -VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMMMESSAGES_management_report.html,Statement_Cov(%):,94,Branch_Cov(%):,95,Pairs_Cov(%):,94 -VectorCAST_MinGW_C_LinuxTestSuite_DIALYSIS_management_report.html,Statement_Cov(%):,100,Branch_Cov(%):,99,Pairs_Cov(%):,98 +VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMMMESSAGES_management_report.html,Statement_Cov(%):,94,Branch_Cov(%):,95,Pairs_Cov(%):,93 +VectorCAST_MinGW_C_LinuxTestSuite_DIALYSIS_management_report.html,Statement_Cov(%):,99,Branch_Cov(%):,98,Pairs_Cov(%):,96 VectorCAST_MinGW_C_LinuxTestSuite_FPGA_management_report.html,Statement_Cov(%):,96,Branch_Cov(%):,95,Pairs_Cov(%):,91 Unit Test Manual Cases @@ -54,7 +61,7 @@ VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENTPARAMS_management_report.html,Coverage(%):,91 VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_management_report.html,Coverage(%):,75 VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_management_report.html,Coverage(%):,44 -VectorCAST_MinGW_C_LinuxTestSuite_INT_DGINTERFACE_management_report.html,Coverage(%):,89 +VectorCAST_MinGW_C_LinuxTestSuite_INT_DGINTERFACE_management_report.html,Coverage(%):,74 VectorCAST_MinGW_C_LinuxTestSuite_INT_AIRTRAP_management_report.html,Coverage(%):,90 VectorCAST_MinGW_C_LinuxTestSuite_INT_FPGA_management_report.html,Coverage(%):,98 @@ -182,6 +189,7 @@ TaskPriority, Missing Unit Test and Integration Test ModeInitPOST, Missing Unit Test and Integration Test TreatmentStop, Missing Unit Test and Integration Test +Prime, Missing Unit Test and Integration Test ModeStandby, Missing Unit Test and Integration Test ModeService, Missing Unit Test and Integration Test ModePreTreat, Missing Unit Test and Integration Test Fisheye: Tag 766708fceb0bdf1af8c7897df29d4f5036bfd3db refers to a dead (removed) revision in file `results/VectorCAST.log'. Fisheye: No comparison available. Pass `N' to diff? Index: results/cppcheck.log =================================================================== diff -u -raf02c3139b58ff98e2beb38704955d748e30ea35 -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- results/cppcheck.log (.../cppcheck.log) (revision af02c3139b58ff98e2beb38704955d748e30ea35) +++ results/cppcheck.log (.../cppcheck.log) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -1,117 +1,119 @@ Checking hdfirmware/firmware/App/Controllers/AirTrap.c ... -1/46 files checked 2% done +1/47 files checked 2% done Checking hdfirmware/firmware/App/Controllers/AlarmLamp.c ... -2/46 files checked 4% done +2/47 files checked 4% done Checking hdfirmware/firmware/App/Controllers/BloodFlow.c ... Checking hdfirmware/firmware/App/Controllers/BloodFlow.c: RAW_FLOW_SENSOR_DATA... -3/46 files checked 6% done +3/47 files checked 6% done Checking hdfirmware/firmware/App/Controllers/Buttons.c ... Checking hdfirmware/firmware/App/Controllers/Buttons.c: SIMULATE_UI... -4/46 files checked 8% done +4/47 files checked 8% done Checking hdfirmware/firmware/App/Controllers/DGInterface.c ... Checking hdfirmware/firmware/App/Controllers/DGInterface.c: V1_5_SYSTEM... -5/46 files checked 10% done +5/47 files checked 10% done Checking hdfirmware/firmware/App/Controllers/DialInFlow.c ... Checking hdfirmware/firmware/App/Controllers/DialInFlow.c: RAW_FLOW_SENSOR_DATA... -6/46 files checked 12% done +6/47 files checked 12% done Checking hdfirmware/firmware/App/Controllers/DialOutFlow.c ... -7/46 files checked 14% done +7/47 files checked 14% done Checking hdfirmware/firmware/App/Controllers/PresOccl.c ... -8/46 files checked 17% done +8/47 files checked 16% done Checking hdfirmware/firmware/App/Controllers/Valves.c ... Checking hdfirmware/firmware/App/Controllers/Valves.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Controllers/Valves.c: TST_3WAY_VALVES_ALWAYS_OPEN... -9/46 files checked 19% done +9/47 files checked 18% done Checking hdfirmware/firmware/App/Drivers/CPLD.c ... -10/46 files checked 21% done +10/47 files checked 20% done Checking hdfirmware/firmware/App/Drivers/Comm.c ... Checking hdfirmware/firmware/App/Drivers/Comm.c: DEBUG_ENABLED... -11/46 files checked 23% done +11/47 files checked 23% done Checking hdfirmware/firmware/App/Drivers/InternalADC.c ... -12/46 files checked 25% done +12/47 files checked 25% done Checking hdfirmware/firmware/App/Drivers/SafetyShutdown.c ... -13/46 files checked 27% done +13/47 files checked 27% done Checking hdfirmware/firmware/App/Modes/Dialysis.c ... Checking hdfirmware/firmware/App/Modes/Dialysis.c: RUN_PUMPS_OPEN_LOOP... -14/46 files checked 29% done +14/47 files checked 29% done Checking hdfirmware/firmware/App/Modes/ModeFault.c ... Checking hdfirmware/firmware/App/Modes/ModeFault.c: EMC_TEST_BUILD... -15/46 files checked 32% done +15/47 files checked 31% done Checking hdfirmware/firmware/App/Modes/ModeInitPOST.c ... Checking hdfirmware/firmware/App/Modes/ModeInitPOST.c: DISABLE_ACCELS... Checking hdfirmware/firmware/App/Modes/ModeInitPOST.c: SKIP_POST... -16/46 files checked 34% done +16/47 files checked 33% done Checking hdfirmware/firmware/App/Modes/ModePostTreat.c ... -17/46 files checked 36% done +17/47 files checked 35% done Checking hdfirmware/firmware/App/Modes/ModePreTreat.c ... -18/46 files checked 38% done +18/47 files checked 37% done Checking hdfirmware/firmware/App/Modes/ModeService.c ... -19/46 files checked 40% done +19/47 files checked 39% done Checking hdfirmware/firmware/App/Modes/ModeStandby.c ... Checking hdfirmware/firmware/App/Modes/ModeStandby.c: EMC_TEST_BUILD... Checking hdfirmware/firmware/App/Modes/ModeStandby.c: EMC_TEST_BUILD;RUN_WITHOUT_DG... Checking hdfirmware/firmware/App/Modes/ModeStandby.c: RUN_WITHOUT_DG... -20/46 files checked 42% done +20/47 files checked 41% done Checking hdfirmware/firmware/App/Modes/ModeTreatment.c ... -21/46 files checked 44% done +21/47 files checked 43% done Checking hdfirmware/firmware/App/Modes/ModeTreatmentParams.c ... -22/46 files checked 47% done +22/47 files checked 46% done Checking hdfirmware/firmware/App/Modes/OperationModes.c ... -23/46 files checked 49% done +23/47 files checked 48% done +Checking hdfirmware/firmware/App/Modes/Prime.c ... +24/47 files checked 50% done Checking hdfirmware/firmware/App/Modes/TreatmentStop.c ... -24/46 files checked 51% done +25/47 files checked 52% done Checking hdfirmware/firmware/App/Services/AlarmMgmt.c ... Checking hdfirmware/firmware/App/Services/AlarmMgmt.c: ALARMS_DEBUG;DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/AlarmMgmt.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/AlarmMgmt.c: EMC_TEST_BUILD... -25/46 files checked 53% done +26/47 files checked 54% done Checking hdfirmware/firmware/App/Services/CommBuffers.c ... Checking hdfirmware/firmware/App/Services/CommBuffers.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/CommBuffers.c: EMC_TEST_BUILD... -26/46 files checked 55% done +27/47 files checked 56% done Checking hdfirmware/firmware/App/Services/FPGA.c ... Checking hdfirmware/firmware/App/Services/FPGA.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/FPGA.c: EMC_TEST_BUILD... Checking hdfirmware/firmware/App/Services/FPGA.c: READ_FPGA_ASYNC_DATA... -27/46 files checked 57% done +28/47 files checked 58% done Checking hdfirmware/firmware/App/Services/Interrupts.c ... Checking hdfirmware/firmware/App/Services/Interrupts.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/Interrupts.c: EMC_TEST_BUILD... -28/46 files checked 59% done +29/47 files checked 60% done Checking hdfirmware/firmware/App/Services/MsgQueues.c ... -29/46 files checked 62% done +30/47 files checked 62% done Checking hdfirmware/firmware/App/Services/PIControllers.c ... Checking hdfirmware/firmware/App/Services/PIControllers.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/PIControllers.c: EMC_TEST_BUILD... -30/46 files checked 64% done +31/47 files checked 64% done Checking hdfirmware/firmware/App/Services/SystemComm.c ... Checking hdfirmware/firmware/App/Services/SystemComm.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/SystemComm.c: EMC_TEST_BUILD... -31/46 files checked 66% done +32/47 files checked 66% done Checking hdfirmware/firmware/App/Services/SystemCommMessages.c ... Checking hdfirmware/firmware/App/Services/SystemCommMessages.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/SystemCommMessages.c: EMC_TEST_BUILD... -32/46 files checked 68% done +33/47 files checked 69% done Checking hdfirmware/firmware/App/Services/WatchdogMgmt.c ... Checking hdfirmware/firmware/App/Services/WatchdogMgmt.c: DEBUG_ENABLED... Checking hdfirmware/firmware/App/Services/WatchdogMgmt.c: EMC_TEST_BUILD... -33/46 files checked 70% done +34/47 files checked 71% done Checking hdfirmware/firmware/App/Tasks/TaskBG.c ... -34/46 files checked 72% done +35/47 files checked 73% done Checking hdfirmware/firmware/App/Tasks/TaskGeneral.c ... Checking hdfirmware/firmware/App/Tasks/TaskGeneral.c: TASK_TIMING_OUTPUT_ENABLED... -35/46 files checked 74% done +36/47 files checked 75% done Checking hdfirmware/firmware/App/Tasks/TaskPriority.c ... Checking hdfirmware/firmware/App/Tasks/TaskPriority.c: TASK_TIMING_OUTPUT_ENABLED... -36/46 files checked 76% done +37/47 files checked 77% done Checking hdfirmware/firmware/App/Tasks/TaskTimer.c ... Checking hdfirmware/firmware/App/Tasks/TaskTimer.c: TASK_TIMING_OUTPUT_ENABLED... -37/46 files checked 79% done +38/47 files checked 79% done Checking hdfirmware/firmware/FWCommon/Accel.c ... Checking hdfirmware/firmware/FWCommon/Accel.c: _DG_... Checking hdfirmware/firmware/FWCommon/Accel.c: _HD_... Checking hdfirmware/firmware/FWCommon/Accel.c: _VECTORCAST_... -38/46 files checked 81% done +39/47 files checked 81% done Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c ... Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: CPU_BYTE_ORDER... Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: F021... @@ -124,33 +126,33 @@ Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: _LITTLE_ENDIAN;__little_endian__... Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: __ARMCC_VERSION... Checking hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c: __GNUC__... -39/46 files checked 83% done +40/47 files checked 83% done Checking hdfirmware/firmware/FWCommon/NVDataMgmt.c ... Checking hdfirmware/firmware/FWCommon/NVDataMgmt.c: _DG_... Checking hdfirmware/firmware/FWCommon/NVDataMgmt.c: _HD_... Checking hdfirmware/firmware/FWCommon/NVDataMgmt.c: _VECTORCAST_... -40/46 files checked 85% done +41/47 files checked 85% done Checking hdfirmware/firmware/FWCommon/PersistentAlarm.c ... Checking hdfirmware/firmware/FWCommon/PersistentAlarm.c: _DG_... Checking hdfirmware/firmware/FWCommon/PersistentAlarm.c: _HD_... Checking hdfirmware/firmware/FWCommon/PersistentAlarm.c: _VECTORCAST_... -41/46 files checked 87% done +42/47 files checked 87% done Checking hdfirmware/firmware/FWCommon/RTC.c ... Checking hdfirmware/firmware/FWCommon/RTC.c: _DG_... Checking hdfirmware/firmware/FWCommon/RTC.c: _VECTORCAST_... -42/46 files checked 89% done +43/47 files checked 90% done Checking hdfirmware/firmware/FWCommon/Timers.c ... Checking hdfirmware/firmware/FWCommon/Timers.c: _VECTORCAST_... -43/46 files checked 91% done +44/47 files checked 92% done Checking hdfirmware/firmware/FWCommon/Utilities.c ... Checking hdfirmware/firmware/FWCommon/Utilities.c: _DG_... Checking hdfirmware/firmware/FWCommon/Utilities.c: _HD_... Checking hdfirmware/firmware/FWCommon/Utilities.c: _VECTORCAST_... -44/46 files checked 94% done +45/47 files checked 94% done Checking hdfirmware/firmware/FWCommon/irqDispatch_c.c ... Checking hdfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_128CH__... Checking hdfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_96CH__... Checking hdfirmware/firmware/FWCommon/irqDispatch_c.c: __TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__;__TI_VIM_96CH__... -45/46 files checked 96% done +46/47 files checked 96% done Checking hdfirmware/firmware/source/sys_main.c ... -46/46 files checked 100% done +47/47 files checked 100% done Index: results/cppcheckError.csv =================================================================== diff -u -r766708fceb0bdf1af8c7897df29d4f5036bfd3db -rbda2ec522a874f07b4433a31a6a6607c55dadda5 --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 766708fceb0bdf1af8c7897df29d4f5036bfd3db) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision bda2ec522a874f07b4433a31a6a6607c55dadda5) @@ -1,12 +1,10 @@ File, Line No., Severity, Issue, Description hdfirmware/firmware/App/Modes/ModeFault.c,72,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModePostTreat.c,71,style,unreadVariable,Variable 'stop' is assigned a value that is never used. -hdfirmware/firmware/App/Modes/ModePreTreat.c,78,style,unreadVariable,Variable 'stop' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModeTreatment.c,882,style,unreadVariable,Variable 'dialysisState' is assigned a value that is never used. hdfirmware/firmware/App/Modes/ModeTreatmentParams.c,384,style,redundantAssignment,Variable 'accepted' is reassigned a value before the old one has been used. hdfirmware/firmware/App/Services/Interrupts.c,175,style,variableScope,The scope of the variable 'debugStr' can be reduced. -hdfirmware/firmware/App/Services/SystemCommMessages.c,4000,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. -hdfirmware/firmware/App/Services/SystemCommMessages.c,1412,style,unreadVariable,Variable 'result' is assigned a value that is never used. +hdfirmware/firmware/App/Services/SystemCommMessages.c,3994,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. hdfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. hdfirmware/firmware/FWCommon/NVDataMgmt.c,1567,style,variableScope,The scope of the variable 'modulus' can be reduced. @@ -21,37 +19,38 @@ hdfirmware/firmware/App/Drivers/InternalADC.c,115,style,unusedFunction,The function 'adcNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,172,style,unusedFunction,The function 'canErrorNotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,152,style,unusedFunction,The function 'canMessageNotification' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,668,style,unusedFunction,The function 'cmdDGSampleWater' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,572,style,unusedFunction,The function 'cmdStopDG' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,834,style,unusedFunction,The function 'cmdDGSampleWater' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,738,style,unusedFunction,The function 'cmdStopDG' is never used. hdfirmware/firmware/App/Services/Interrupts.c,315,style,unusedFunction,The function 'dmaGroupANotification' is never used. hdfirmware/firmware/App/Services/Interrupts.c,361,style,unusedFunction,The function 'edgeNotification' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,207,style,unusedFunction,The function 'execAirTrapMonitorPriming' is never used. hdfirmware/firmware/App/Controllers/AirTrap.c,441,style,unusedFunction,The function 'execAirTrapTest' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,152,style,unusedFunction,The function 'execPreTreatmentReservoirMgmt' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,539,style,unusedFunction,The function 'execPresOcclTest' is never used. hdfirmware/firmware/FWCommon/Accel.c,674,style,unusedFunction,The function 'getAccelCalibration' is never used. hdfirmware/firmware/App/Controllers/BloodFlow.c,1340,style,unusedFunction,The function 'getBloodFlowCalibration' is never used. hdfirmware/firmware/App/Controllers/BloodFlow.c,400,style,unusedFunction,The function 'getBloodPumpRotorCount' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,537,style,unusedFunction,The function 'getCurrentAlarmStatePriority' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,399,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,345,style,unusedFunction,The function 'getDGPressure' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,384,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,369,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,451,style,unusedFunction,The function 'getDGDrainPumpRPMSetPt' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,397,style,unusedFunction,The function 'getDGPressure' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,436,style,unusedFunction,The function 'getDGROPumpFlowRateMlMin' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,421,style,unusedFunction,The function 'getDGROPumpPressureSetPt' is never used. hdfirmware/firmware/App/Controllers/DialInFlow.c,1302,style,unusedFunction,The function 'getDialInFlowCalibration' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. hdfirmware/firmware/App/Services/FPGA.c,1169,style,unusedFunction,The function 'getFPGABloodPumpHallSensorStatus' is never used. hdfirmware/firmware/App/Services/FPGA.c,1201,style,unusedFunction,The function 'getFPGADialInPumpHallSensorStatus' is never used. hdfirmware/firmware/App/Services/FPGA.c,1233,style,unusedFunction,The function 'getFPGADialOutPumpHallSensorStatus' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,466,style,unusedFunction,The function 'getLoadCellWeightInGrams' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. hdfirmware/firmware/App/Services/PIControllers.c,229,style,unusedFunction,The function 'getPIControllerSignals' is never used. hdfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. -hdfirmware/firmware/App/Controllers/Valves.c,343,style,unusedFunction,The function 'getValvePosition' is never used. +hdfirmware/firmware/App/Controllers/Valves.c,346,style,unusedFunction,The function 'getValvePosition' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. hdfirmware/firmware/FWCommon/Utilities.c,418,style,unusedFunction,The function 'hexStrToDec' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,522,style,unusedFunction,The function 'isAlarmActive' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,184,style,unusedFunction,The function 'initPreTreatmentReservoirMgmt' is never used. +hdfirmware/firmware/App/Modes/Prime.c,83,style,unusedFunction,The function 'initPrime' is never used. hdfirmware/firmware/App/Controllers/PresOccl.c,137,style,unusedFunction,The function 'isCartridgeLoaded' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,212,style,unusedFunction,The function 'isPOSTCompleted' is never used. hdfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'isPOSTPassed' is never used. @@ -64,13 +63,11 @@ hdfirmware/firmware/App/Services/Interrupts.c,245,style,unusedFunction,The function 'sciNotification' is never used. hdfirmware/firmware/App/Services/AlarmMgmt.c,566,style,unusedFunction,The function 'setAlarmAudioVolume' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'setBootloaderFlag' is never used. -hdfirmware/firmware/App/Controllers/DGInterface.c,455,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. +hdfirmware/firmware/App/Controllers/DGInterface.c,580,style,unusedFunction,The function 'setDGDialysateTemperatures' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'setDisinfectionDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,323,style,unusedFunction,The function 'setMfgData' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,440,style,unusedFunction,The function 'setServiceDate' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,534,style,unusedFunction,The function 'setTreatmentTime' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,572,style,unusedFunction,The function 'setWaterConsumption' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,756,style,unusedFunction,The function 'testResetAlarmStatusPublishIntervalOverride' is never used. -hdfirmware/firmware/App/Services/AlarmMgmt.c,731,style,unusedFunction,The function 'testSetAlarmStatusPublishIntervalOverride' is never used. hdfirmware/firmware/FWCommon/NVDataMgmt.c,487,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)