Index: firmware/App/Controllers/Valves.c =================================================================== diff -u -r3fa496b611a3a84c8aaa882a1b27762c6bc0024c -rc96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 --- firmware/App/Controllers/Valves.c (.../Valves.c) (revision 3fa496b611a3a84c8aaa882a1b27762c6bc0024c) +++ firmware/App/Controllers/Valves.c (.../Valves.c) (revision c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7) @@ -1083,7 +1083,7 @@ position &= DISABLE_VALVE_CURRENT_RELAXATION; // If current relaxation is needed, set the MSB to 1 - if ( enableCurrentRelaxation ) + if ( TRUE == enableCurrentRelaxation ) { position |= ENABLE_VALVE_CURRENT_RELAXATION; } Index: results/Build_Status_Report.csv =================================================================== diff -u -rec69350c77cd6738dedb6b25a93b878843de1add -rc96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 --- results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision ec69350c77cd6738dedb6b25a93b878843de1add) +++ results/Build_Status_Report.csv (.../Build_Status_Report.csv) (revision c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7) @@ -1,220 +1,4 @@ -Running Project, hdfirmware -Date, Mon Apr 5 11:28:09 PDT 2021 +Running Project, +Date, Mon Oct 16 20:53:09 PDT 2023 -VectorCAST Pass/Fail Status, Failed -The following test(s) failed: -VectorCAST_MinGW_C_LinuxTestSuite_ACCEL_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_DGINTERFACE_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_DIALOUTFLOW_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_DIALYSIS_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_FPGA_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_ACCEL_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_AIRTRAP_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_BLOODFLOW_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_DGINTERFACE_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALOUTFLOW_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALYSIS_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_FPGA_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENT_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENTPARAMS_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_PRESOCCL_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_SYSTEMCOMMMESSAGES_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_INT_UTILITIES_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENT_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENTPARAMS_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_PICONTROLLERS_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMM_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMMMESSAGES_management_report.html -VectorCAST_MinGW_C_LinuxTestSuite_VALVES_management_report.html - -Unit Test Coverage, Failed -The following test(s) failed: -VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENT_management_report.html,Statement_Cov(%):,70,Branch_Cov(%):,71,Pairs_Cov(%):,72 -VectorCAST_MinGW_C_LinuxTestSuite_AIRTRAP_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,98,Pairs_Cov(%):,100 -VectorCAST_MinGW_C_LinuxTestSuite_DGINTERFACE_management_report.html,Statement_Cov(%):,0,Branch_Cov(%):,0,Pairs_Cov(%):,0 -VectorCAST_MinGW_C_LinuxTestSuite_PRESOCCL_management_report.html,Statement_Cov(%):,75,Branch_Cov(%):,69,Pairs_Cov(%):,57 -VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_management_report.html,Statement_Cov(%):,69,Branch_Cov(%):,64,Pairs_Cov(%):,50 -VectorCAST_MinGW_C_LinuxTestSuite_OPERATIONMODES_management_report.html,Statement_Cov(%):,74,Branch_Cov(%):,75,Pairs_Cov(%):,80 -VectorCAST_MinGW_C_LinuxTestSuite_DIALINFLOW_management_report.html,Statement_Cov(%):,98,Branch_Cov(%):,97,Pairs_Cov(%):,94 -VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_management_report.html,Statement_Cov(%):,98,Branch_Cov(%):,97,Pairs_Cov(%):,92 -VectorCAST_MinGW_C_LinuxTestSuite_VALVES_management_report.html,Statement_Cov(%):,98,Branch_Cov(%):,98,Pairs_Cov(%):,93 -VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMM_management_report.html,Statement_Cov(%):,90,Branch_Cov(%):,94,Pairs_Cov(%):,96 -VectorCAST_MinGW_C_LinuxTestSuite_PICONTROLLERS_management_report.html,Statement_Cov(%):,95,Branch_Cov(%):,87,Pairs_Cov(%):,76 -VectorCAST_MinGW_C_LinuxTestSuite_MODETREATMENTPARAMS_management_report.html,Statement_Cov(%):,93,Branch_Cov(%):,91,Pairs_Cov(%):,86 -VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,97,Pairs_Cov(%):,93 -VectorCAST_MinGW_C_LinuxTestSuite_UTILITIES_management_report.html,Statement_Cov(%):,87,Branch_Cov(%):,82,Pairs_Cov(%):,85 -VectorCAST_MinGW_C_LinuxTestSuite_ACCEL_management_report.html,Statement_Cov(%):,96,Branch_Cov(%):,94,Pairs_Cov(%):,88 -VectorCAST_MinGW_C_LinuxTestSuite_SYSTEMCOMMMESSAGES_management_report.html,Statement_Cov(%):,76,Branch_Cov(%):,80,Pairs_Cov(%):,80 -VectorCAST_MinGW_C_LinuxTestSuite_DIALOUTFLOW_management_report.html,Statement_Cov(%):,97,Branch_Cov(%):,96,Pairs_Cov(%):,94 -VectorCAST_MinGW_C_LinuxTestSuite_DIALYSIS_management_report.html,Statement_Cov(%):,93,Branch_Cov(%):,89,Pairs_Cov(%):,80 -VectorCAST_MinGW_C_LinuxTestSuite_FPGA_management_report.html,Statement_Cov(%):,88,Branch_Cov(%):,75,Pairs_Cov(%):,75 - -Unit Test Manual Cases -Module, Function Name -modetreatment,execTreatmentMode -modetreatment,handleTreatmentDialysisState -alarmlamp,setAlarmLampToPatternStep -dialysis,handleSalineBolusInProgressState - -Integration Test Coverage, Failed -The following test(s) failed: -VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALYSIS_management_report.html,Coverage(%):,87 -VectorCAST_MinGW_C_LinuxTestSuite_INT_SYSTEMCOMMMESSAGES_management_report.html,Coverage(%):,79 -VectorCAST_MinGW_C_LinuxTestSuite_INT_ACCEL_management_report.html,Coverage(%):,95 -VectorCAST_MinGW_C_LinuxTestSuite_INT_UTILITIES_management_report.html,Coverage(%):,76 -VectorCAST_MinGW_C_LinuxTestSuite_INT_PRESOCCL_management_report.html,Coverage(%):,90 -VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENT_management_report.html,Coverage(%):,51 -VectorCAST_MinGW_C_LinuxTestSuite_INT_OPERATIONMODES_management_report.html,Coverage(%):,77 -VectorCAST_MinGW_C_LinuxTestSuite_INT_MODETREATMENTPARAMS_management_report.html,Coverage(%):,91 -VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_management_report.html,Coverage(%):,68 -VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_management_report.html,Coverage(%):,44 -VectorCAST_MinGW_C_LinuxTestSuite_INT_DGINTERFACE_management_report.html,Coverage(%):,54 -VectorCAST_MinGW_C_LinuxTestSuite_INT_DIALINFLOW_management_report.html,Coverage(%):,98 -VectorCAST_MinGW_C_LinuxTestSuite_INT_AIRTRAP_management_report.html,Coverage(%):,90 -VectorCAST_MinGW_C_LinuxTestSuite_INT_FPGA_management_report.html,Coverage(%):,71 -VectorCAST_MinGW_C_LinuxTestSuite_INT_BLOODFLOW_management_report.html,Coverage(%):,98 - -Integration Test Manual Cases -Module, Function Name -dialysis,handleDialysisSalineBolusState -dialysis,handleUFStartState -dialysis,handleUFPausedState -dialysis,handleSalineBolusIdleState -dialysis,handleSalineBolusWait4Pumps2Stop -dialysis,handleSalineBolusInProgressState -systemcommmessages,broadcastAccelData -systemcommmessages,broadcastHDOperationMode -nvdatamgmt,setMfgData -nvdatamgmt,getMfgData -nvdatamgmt,setCalibrationData -nvdatamgmt,getCalibrationData -nvdatamgmt,testResetCalibrationData -nvdatamgmt,setServiceDate -nvdatamgmt,getServiceDate -nvdatamgmt,writeLogData -nvdatamgmt,readLogData -nvdatamgmt,setTreatmentTime -nvdatamgmt,getTreatmentTime -nvdatamgmt,setWaterConsumption -nvdatamgmt,getWaterConsumption -nvdatamgmt,setDisinfectionDate -nvdatamgmt,getDisinfectionDate -nvdatamgmt,setBootloaderFlag -nvdatamgmt,getBootloaderFlag -nvdatamgmt,setMemoryOpsStruct -nvdatamgmt,prepareWriteLogJobAndGetStartAddress -nvdatamgmt,prepareReadLogJobAndGetStartAddress -nvdatamgmt,enqueue -nvdatamgmt,isQueueFull -nvdatamgmt,getAvailableQueueCount -nvdatamgmt,enqueueBank7Sector0Records -nvdatamgmt,eraseDataLogSectors -accel,getAccelCalibration -utilities,hexStrToDec -presoccl,isCartridgeLoaded -presoccl,handlePresOcclInitState -safetyshutdown,isSafetyShutdownActivated -modetreatment,handleTreatmentDialysisState -modetreatment,handleTreatmentStopState -cpld,setCPLDLampBlue -modetreatmentparams,handleWaitForUI2SendState -modetreatmentparams,setTreatmentParameterS32 -modetreatmentparams,setTreatmentParameterF32 -modetreatmentparams,getTreatmentParameterU32 -modetreatmentparams,getTreatmentParameterS32 -modetreatmentparams,getTreatmentParameterF32 -dialoutflow,signalDialOutPumpHardStop -dialoutflow,signalDialOutPumpRotorHallSensor -dialoutflow,homeDialOutPump -dialoutflow,handleDialOutPumpControlToTargetState -alarmmgmt,isAlarmActive -alarmmgmt,getCurrentAlarmStatePriority -alarmmgmt,isAlarmRecoverable -alarmmgmt,resetAlarmPriorityFIFO -systemcomm,isDGCommunicating -systemcomm,isUICommunicating -systemcomm,clearCANXmitBuffers -systemcomm,checkTooManyBadMsgCRCs -systemcomm,matchACKtoPendingACKList -valves,getValvePosition -valves,getValveAirTrapStatus -dginterface,getDGPressure -dginterface,getDGROPumpPressureSetPt -dginterface,getDGROPumpFlowRateMlMin -dginterface,getDGDrainPumpRPMSetPt -dginterface,setDGDialysateTemperatures -dginterface,cmdSetDGDialysateTargetTemps -dginterface,cmdStartDG -dginterface,cmdStopDG -dginterface,cmdStopDGTrimmerHeater -dginterface,cmdSetDGActiveReservoir -dginterface,cmdDGSampleWater -dialinflow,signalDialInPumpHardStop -dialinflow,signalDialInPumpRotorHallSensor -dialinflow,homeDialInPump -dialinflow,handleDialInPumpRampingUpState -dialinflow,handleDialInPumpRampingDownState -dialinflow,handleDialInPumpControlToTargetState -dialinflow,getTargetDialInFlowRate -dialinflow,execDialInFlowTest -dialinflow,getDialInFlowCalibration -airtrap,startAirTrapControl -airtrap,handleAirTrapValveClosedState -airtrap,handleAirTrapValveOpenState -fpga,handleFPGAReceiveHeaderState -fpga,handleFPGAWriteAllActuatorsState -fpga,handleFPGAReceiveAllSensorsState -fpga,setupDMAForWriteCmd -fpga,startDMAWriteCmd -fpga,setupDMAForWriteResp -fpga,startDMAReceiptOfWriteResp -fpga,getFPGABloodPumpHallSensorStatus -fpga,getFPGADialInPumpHallSensorStatus -fpga,getFPGADialOutPumpHallSensorStatus -bloodflow,signalBloodPumpHardStop -bloodflow,homeBloodPump -bloodflow,getBloodPumpRotorCount -bloodflow,handleBloodPumpRampingUpState -bloodflow,handleBloodPumpRampingDownState -bloodflow,handleBloodPumpControlToTargetState -bloodflow,execBloodFlowTest -bloodflow,getBloodFlowCalibration -rtc,getRTCTimestamp - -List of Untested Modules -InternalADC, Missing Unit Test and Integration Test -Comm, Missing Integration Test -SyringePump, Missing Unit Test and Integration Test -FluidLeak, Missing Unit Test and Integration Test -Interrupts, Missing Integration Test -PIControllers, Missing Integration Test -TaskTimer, Missing Unit Test and Integration Test -TaskBG, Missing Unit Test and Integration Test -TaskGeneral, Missing Unit Test and Integration Test -TaskPriority, Missing Unit Test and Integration Test -ModeInitPOST, Missing Unit Test and Integration Test -TreatmentStop, Missing Unit Test and Integration Test -PreTreatmentRecirc, Missing Unit Test and Integration Test -TreatmentRecirc, Missing Unit Test and Integration Test -BloodPrime, Missing Unit Test and Integration Test -Prime, Missing Unit Test and Integration Test -ModeStandby, Missing Unit Test and Integration Test -TreatmentEnd, Missing Unit Test and Integration Test -ModeService, Missing Unit Test and Integration Test -ModePreTreat, Missing Unit Test and Integration Test -ModeFault, Missing Unit Test and Integration Test -Rinseback, Missing Unit Test and Integration Test -SelfTests, Missing Unit Test and Integration Test -ModePostTreat, Missing Unit Test and Integration Test -irqDispatch_c, Missing Unit Test and Integration Test -PersistentAlarm, Missing Unit Test and Integration Test - -CppCheck, Passed -Cppcheck No. of Warnings, 1 - Fisheye: Tag c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 refers to a dead (removed) revision in file `results/VectorCAST.log'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 refers to a dead (removed) revision in file `results/cppcheck.log'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 refers to a dead (removed) revision in file `results/cppcheckError.csv'. Fisheye: No comparison available. Pass `N' to diff?