Index: firmware/App/Controllers/AirTrap.c =================================================================== diff -u -rbb80dbac26147ab08413efa91007f7ffed43c38f -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/AirTrap.c (.../AirTrap.c) (revision bb80dbac26147ab08413efa91007f7ffed43c38f) +++ firmware/App/Controllers/AirTrap.c (.../AirTrap.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -201,20 +201,6 @@ /*********************************************************************//** * @brief - * The execAirTrapMonitorPriming function executes the air trap monitor - * for cartridge priming during pre-treatment mode. - * @details Inputs: airTrapLevels[], airTrapFillAlarmCtr - * @details Outputs: airTrapFillAlarmCtr - * @return none - *************************************************************************/ -void execAirTrapMonitorPriming( void ) -{ - // TODO - Implement when priming sub-mode of pre-treatment mode is implemented. - // ActivateAlarmNoData( ALARM_ID_AIR_TRAP_FILL_DURING_PRIME ); -} - -/*********************************************************************//** - * @brief * The execAirTrapMonitorTreatment function executes the air trap monitor * for treatment mode. * @details Inputs: airTrapLevels[], airTrapFillAlarmCtr Index: firmware/App/Controllers/AirTrap.h =================================================================== diff -u -r78c03fb021407eaf8d17dd0f74f6969443b397ce -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/AirTrap.h (.../AirTrap.h) (revision 78c03fb021407eaf8d17dd0f74f6969443b397ce) +++ firmware/App/Controllers/AirTrap.h (.../AirTrap.h) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -54,7 +54,6 @@ void resetAirTrap( void ); void execAirTrapController( void ); void execAirTrapMonitor( void ); -void execAirTrapMonitorPriming( void ); void execAirTrapMonitorTreatment( void ); void startAirTrapControl( void ); Index: firmware/App/Controllers/BloodFlow.c =================================================================== diff -u -rea24d974f95d6d304746120d61774c196d0fc589 -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/BloodFlow.c (.../BloodFlow.c) (revision ea24d974f95d6d304746120d61774c196d0fc589) +++ firmware/App/Controllers/BloodFlow.c (.../BloodFlow.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -20,10 +20,6 @@ #include "can.h" #include "etpwm.h" -// TODO - Test includes - remove later -#include "DialInFlow.h" -#include "PresOccl.h" - #include "BloodFlow.h" #include "FPGA.h" #include "InternalADC.h" Index: firmware/App/Controllers/DGInterface.c =================================================================== diff -u -r174c9ba02da6790f01ea9141ab1cc1d28388f2f8 -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/DGInterface.c (.../DGInterface.c) (revision 174c9ba02da6790f01ea9141ab1cc1d28388f2f8) +++ firmware/App/Controllers/DGInterface.c (.../DGInterface.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -219,7 +219,7 @@ // Calculate volume used from active reservoir - do not accumulate if saline bolus in progress if ( SALINE_BOLUS_STATE_IN_PROGRESS != getSalineBolusState() ) { - resUseVolumeMl += ( flowRateMlPerMs * msSinceLastVolumeCalc ); // TODO - should this calc be done and kept by Dialysis sub-mode? + resUseVolumeMl += ( flowRateMlPerMs * msSinceLastVolumeCalc ); } resUseTimer = getMSTimerCount(); @@ -521,7 +521,7 @@ } else { - // TODO + // TODO - s/w fault } } @@ -578,7 +578,7 @@ } else { - // TODO + // TODO - s/w fault } } Index: firmware/App/Controllers/PresOccl.c =================================================================== diff -u -racb165deff7036d41bbe12678f35cd9539012838 -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/PresOccl.c (.../PresOccl.c) (revision acb165deff7036d41bbe12678f35cd9539012838) +++ firmware/App/Controllers/PresOccl.c (.../PresOccl.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -63,7 +63,7 @@ #define CARTRIDGE_LOADED_THRESHOLD 5000 ///< Threshold above which a cartridge is considered loaded. #define EMPTY_SALINE_BAG_THRESHOLD_MMHG -300.0 ///< Threshold below which the saline bag is considered empty (in mmHg). TODO - get real threshold from Systems -static const U32 EMPTY_SALINE_BAG_PERSISTENCE = ( 250 / TASK_GENERAL_INTERVAL ); ///< Time that saline bag looks empty before saying it is empty. TODO - use persistent alarm when updated +static const U32 EMPTY_SALINE_BAG_PERSISTENCE = ( 250 / TASK_GENERAL_INTERVAL ); ///< Time that saline bag looks empty before saying it is empty. /// Occlusion sensors minimum pressure reading limit when no cartridge is loaded. #define OCCLUSION_NO_CARTRIDGE_PRESSURE_READING_MIN 2000 /// Occlusion sensors maximum pressure reading limit when cartridge is considered loaded. @@ -327,8 +327,6 @@ *************************************************************************/ static void convertOcclusionPressures( void ) { - // TODO - any filtering required??? - // Occlusion sensor values have no unit - take as is bloodPumpOcclusion.data = (U32)getFPGABloodPumpOcclusion(); dialInPumpOcclusion.data = (U32)getFPGADialInPumpOcclusion(); @@ -433,7 +431,6 @@ U32 diOccl = getMeasuredDialInPumpOcclusion(); U32 doOccl = getMeasuredDialOutPumpOcclusion(); - // TODO - add persistence #ifndef DISABLE_PRESSURE_CHECKS if ( bpOccl > OCCLUSION_THRESHOLD ) { Index: firmware/App/Controllers/SyringePump.c =================================================================== diff -u -rbfa0e8787383e83b19cda450c477b58778513fdf -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Controllers/SyringePump.c (.../SyringePump.c) (revision bfa0e8787383e83b19cda450c477b58778513fdf) +++ firmware/App/Controllers/SyringePump.c (.../SyringePump.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -230,7 +230,7 @@ static BOOL checkOcclusionOrEmpty( BOOL stopPump ); static BOOL checkSyringeRemoved( BOOL stopPump ); static BOOL checkMaxTravel( BOOL stopPump, S32 maxPos ); -static BOOL checkMaxMeasRate( BOOL stopPump, F32 pctMargin ); +static BOOL checkMeasRate( BOOL stopPump, F32 pctMargin ); static BOOL checkVolumeVsSafetyVolume( BOOL stopPump, F32 pctMargin ); static void publishSyringePumpData( void ); @@ -1167,7 +1167,7 @@ stopPump = checkOcclusionOrEmpty( stopPump ); // Check for commanded vs. meas. rate - stopPump = checkMaxMeasRate( stopPump, SYRINGE_PUMP_RATE_CHECK_MARGIN ); + stopPump = checkMeasRate( stopPump, SYRINGE_PUMP_RATE_CHECK_MARGIN ); // Check position > max travel stopPump = checkMaxTravel( stopPump, syringePumpVolumeStartPosition + ( bolusVol * FIVE_PCT_OVER_ALLOWANCE * SYRINGE_ENCODER_COUNTS_PER_ML ) ); @@ -1208,7 +1208,7 @@ stopPump = checkMaxTravel( stopPump, SYRINGE_PUMP_EMPTY_POS + SYRINGE_PUMP_EMPTY_POS_MARGIN ); // Check for commanded vs. meas. rate - stopPump = checkMaxMeasRate( stopPump, SYRINGE_PUMP_RATE_CHECK_MARGIN ); + stopPump = checkMeasRate( stopPump, SYRINGE_PUMP_RATE_CHECK_MARGIN ); // Check volume vs. safety volume stopPump = checkVolumeVsSafetyVolume( stopPump, SYRINGE_PUMP_VOLUME_CHECK_MARGIN ); @@ -1344,16 +1344,15 @@ /*********************************************************************//** * @brief - * The checkMaxMeasRate function checks whether the measured rate is exceeding - * a maximum rate (in mL/hr). This threshold is state dependent so the calling - * function must provide the maximum rate to apply. + * The checkMeasRate function checks whether the measured rate is within a + * given margin of the set rate (in mL/hr). * @details Inputs: syringePumpMeasRate.data, syringePumpSetRate * @details Outputs: alarm triggered if measured and set rates deviate too much * @param stopPump flag passed in by caller indicating whether pump should be stopped * @param pctMargin percent tolerance allowed between set and measured rate * @return TRUE if pump should be stopped, FALSE if not *************************************************************************/ -static BOOL checkMaxMeasRate( BOOL stopPump, F32 pctMargin ) +static BOOL checkMeasRate( BOOL stopPump, F32 pctMargin ) { BOOL result = stopPump; F32 rate = getSyringePumpMeasRate(); Index: firmware/App/Modes/ModeFault.c =================================================================== diff -u -ra2bc96881a5fc3d8f779246b2abebf15a8de9384 -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Modes/ModeFault.c (.../ModeFault.c) (revision a2bc96881a5fc3d8f779246b2abebf15a8de9384) +++ firmware/App/Modes/ModeFault.c (.../ModeFault.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -18,10 +18,12 @@ #include "AlarmLamp.h" #include "BloodFlow.h" #include "Buttons.h" +#include "DGInterface.h" #include "DialInFlow.h" #include "DialOutFlow.h" #include "ModeFault.h" #include "OperationModes.h" +#include "SyringePump.h" #include "Valves.h" /** @@ -42,7 +44,7 @@ *************************************************************************/ void initFaultMode( void ) { - // TODO - anything to do here? + // nothing to do here } /*********************************************************************//** @@ -76,6 +78,9 @@ signalBloodPumpHardStop(); signalDialInPumpHardStop(); signalDialOutPumpHardStop(); + stopSyringePump(); + // Stop trimmer heater + cmdStopDGTrimmerHeater(); // Ensure all valves are in safe position setValveAirTrap( STATE_CLOSED ); setValvePosition( VDI, VALVE_POSITION_C_CLOSE ); @@ -136,7 +141,7 @@ button_state = stop; #endif - return 0; // TODO - return current state + return 0; // Fault mode has no sub-modes } /*********************************************************************//** Index: firmware/App/Modes/ModeStandby.c =================================================================== diff -u -rf4199248340b66e66abbe99599d5d30ce980ea5f -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Modes/ModeStandby.c (.../ModeStandby.c) (revision f4199248340b66e66abbe99599d5d30ce980ea5f) +++ firmware/App/Modes/ModeStandby.c (.../ModeStandby.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -107,18 +107,14 @@ #ifndef RUN_WITHOUT_DG if ( TRUE == stop ) { - activateAlarmNoData( ALARM_ID_TREATMENT_STOPPED_BY_USER ); + activateAlarmNoData( ALARM_ID_TREATMENT_STOPPED_BY_USER ); // TODO - remove alarm? Nothing to stop here. } // State machine to get DG to prep a reservoir so we can start a treatment switch ( currentStandbyState ) { case STANDBY_START_STATE: - // Temporary test code - TODO - remove later - if ( TRUE == isDGCommunicating() ) - { - currentStandbyState = STANDBY_WAIT_FOR_TREATMENT_STATE; - } + currentStandbyState = STANDBY_WAIT_FOR_TREATMENT_STATE; break; case STANDBY_WAIT_FOR_TREATMENT_STATE: @@ -264,7 +260,7 @@ *************************************************************************/ void signalAlarmActionToStandbyMode( ALARM_ACTION_T action ) { - // TODO - implement + // Alarm actions not handled in Standby mode } /**@}*/ Index: firmware/App/Modes/ModeTreatmentParams.c =================================================================== diff -u -r6f9114398c3d37f2b17fff8fdb7f2b2c9bfc6a4b -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Modes/ModeTreatmentParams.c (.../ModeTreatmentParams.c) (revision 6f9114398c3d37f2b17fff8fdb7f2b2c9bfc6a4b) +++ firmware/App/Modes/ModeTreatmentParams.c (.../ModeTreatmentParams.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -336,10 +336,7 @@ // Set all treatment parameters (except UF volume which is not yet received) for ( param = TREATMENT_PARAM_FIRST_UINT; param < TREATMENT_PARAM_UF_VOLUME; param++ ) { - if ( FALSE == setCriticalData( &treatmentParameters[ param ], stagedParams[ param ] ) ) - { - // TODO - should never get here - s/w fault? - } + setCriticalData( &treatmentParameters[ param ], stagedParams[ param ] ); } // Retain original settings for treatment that may be adjusted later during treatment origTreatmentParams.bloodFlowRate_mL_min = getCriticalData( &treatmentParameters[ TREATMENT_PARAM_BLOOD_FLOW ] ).uInt; Index: firmware/App/Modes/Rinseback.c =================================================================== diff -u -rdb22e9d530c5c9d62b02e6dcc72ed96fb67c165a -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Modes/Rinseback.c (.../Rinseback.c) (revision db22e9d530c5c9d62b02e6dcc72ed96fb67c165a) +++ firmware/App/Modes/Rinseback.c (.../Rinseback.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -532,7 +532,7 @@ // Check for empty saline bag if ( TRUE == isSalineBagEmpty() ) { - SET_ALARM_WITH_1_F32_DATA( ALARM_ID_EMPTY_SALINE_BAG, 0.0 ); // TODO - give data supporting empty bag detection + SET_ALARM_WITH_1_F32_DATA( ALARM_ID_EMPTY_SALINE_BAG, getMeasuredArterialPressure() ); setupForRinsebackStopOrPause(); result = RINSEBACK_STOP_STATE; } Index: firmware/App/Services/AlarmMgmt.c =================================================================== diff -u -r49d5fccc324cf982ac4fdd89f7f7accb0bbbfe59 -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Services/AlarmMgmt.c (.../AlarmMgmt.c) (revision 49d5fccc324cf982ac4fdd89f7f7accb0bbbfe59) +++ firmware/App/Services/AlarmMgmt.c (.../AlarmMgmt.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -246,18 +246,6 @@ broadcastAlarmTriggered( (U16)alarm, BLANK_ALARM_DATA, BLANK_ALARM_DATA ); } activateAlarm( alarm ); -#ifdef DEBUG_ENABLED -#ifdef ALARMS_DEBUG - if ( FALSE == alarmIsActive[ alarm ] ) - { - // TODO - temporary debug code - remove later - char debugStr[ 256 ]; - sprintf( debugStr, "ALARM trig:%5d \n", alarm ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } -#endif -#endif } /*********************************************************************//** @@ -279,18 +267,6 @@ broadcastAlarmTriggered( (U16)alarm, alarmData, BLANK_ALARM_DATA ); } activateAlarm( alarm ); -#ifdef DEBUG_ENABLED -#ifdef ALARMS_DEBUG - if ( FALSE == alarmIsActive[ alarm ] ) - { - // TODO - temporary debug code - remove later - char debugStr[ 256 ]; - sprintf( debugStr, "ALARM trig:%5d %8X \n", alarm, alarmData.data.uInt.data ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } -#endif -#endif } /*********************************************************************//** @@ -313,18 +289,6 @@ broadcastAlarmTriggered( (U16)alarm, alarmData1, alarmData2 ); } activateAlarm( alarm ); -#ifdef DEBUG_ENABLED -#ifdef ALARMS_DEBUG - if ( FALSE == alarmIsActive[ alarm ] ) - { - // TODO - temporary debug code - remove later - char debugStr[ 256 ]; - sprintf( debugStr, "ALARM trig:%5d %8X %8X \n", (S32)alarm, alarmData1.data.uInt.data, alarmData2.data.uInt.data ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } -#endif -#endif } /*********************************************************************//** @@ -381,17 +345,6 @@ { resetAlarmPriorityFIFO( ALARM_TABLE[ alarm ].alarmPriority ); } -#ifdef DEBUG_ENABLED -#ifdef ALARMS_DEBUG - { - // TODO - temporary debug code - remove later - char debugStr[ 256 ]; - sprintf( debugStr, "ALARM cleared:%5d \n", alarm ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } -#endif -#endif } } } Index: firmware/App/Services/FPGA.c =================================================================== diff -u -rb01c6571b1ffade6de3e0bf6890de918f4d8b47d -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Services/FPGA.c (.../FPGA.c) (revision b01c6571b1ffade6de3e0bf6890de918f4d8b47d) +++ firmware/App/Services/FPGA.c (.../FPGA.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -104,7 +104,7 @@ } FPGA_HEADER_T; // Read only on FPGA /// Record structure for FPGA continuous priority reads. -typedef struct // TODO - add all sensor readings to this structure per FPGA register map +typedef struct { U08 errorCountProcessor; ///< Reg 256. TBD. U08 errorCountPC; ///< Reg 257. TBD. @@ -192,7 +192,7 @@ } FPGA_SENSORS_T; /// Record structure for FPGA continuous priority writes. -typedef struct // TODO - add all actuator set points to this structure per FPGA register map +typedef struct { U08 fpgaSensorTest; ///< Reg 11. Blood leak and bubble detector sensor test register. U16 fpgaPIDControl; ///< Reg 12. Valve PID enables. @@ -215,7 +215,7 @@ // TODO clean up the struct /// Record structure for FPGA async (as needed) reads. -typedef struct // TODO - add all sensor readings to this structure per FPGA register map +typedef struct { U16 fpgaDieTemp; ///< Reg 512. Internal FPGA die temperature. U16 fpgaADCVccVoltage; ///< Reg 514. Internal FPGA Vcc voltage. @@ -492,8 +492,6 @@ fpgaState = handleFPGAReceiveHeaderState(); break; - // TODO - sensor/ADC init/configuration states - case FPGA_STATE_RCV_ALL_SENSORS: fpgaState = handleFPGAReceiveAllSensorsState(); break; @@ -546,8 +544,6 @@ fpgaState = handleFPGAReadHeaderState(); break; - // TODO - sensor/ADC init/configuration states - case FPGA_STATE_WRITE_ALL_ACTUATORS: fpgaState = handleFPGAWriteAllActuatorsState(); break; Index: firmware/App/Services/Interrupts.c =================================================================== diff -u -r88ee6f3dce69a3dadb012bb8a39c3fd167ba0afd -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Services/Interrupts.c (.../Interrupts.c) (revision 88ee6f3dce69a3dadb012bb8a39c3fd167ba0afd) +++ firmware/App/Services/Interrupts.c (.../Interrupts.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -244,11 +244,6 @@ *************************************************************************/ void sciNotification(sciBASE_t *sci, uint32 flags) { -#ifdef DEBUG_ENABLED - // TODO - temporary debug code - remove later - char debugStr[ 256 ]; -#endif - if ( sci == scilinREG ) { if ( ( flags & SCI_FE_INT ) != 0 ) @@ -260,10 +255,6 @@ { SET_ALARM_WITH_1_U32_DATA( ALARM_ID_HD_SOFTWARE_FAULT, SW_FAULT_ID_FPGA_UART_FRAME_ERROR ) } -#else - sprintf( debugStr, "FPGA UART FR err:%5d \n", sci2FrameErrorCnt ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); #endif } if ( ( flags & SCI_OE_INT ) != 0 ) @@ -275,34 +266,9 @@ { SET_ALARM_WITH_1_U32_DATA( ALARM_ID_HD_SOFTWARE_FAULT, SW_FAULT_ID_FPGA_UART_OVERRUN_ERROR ) } -#else - sprintf( debugStr, "FPGA UART OR err:%5d \n", sci2OverrunErrorCnt ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); #endif } } -#ifdef DEBUG_ENABLED - if ( sci == sciREG ) - { - if ( ( flags & SCI_FE_INT ) != 0 ) - { - sci1FrameErrorCnt++; - clearSCI1CommErrors(); - sprintf( debugStr, "Debug UART FR err:%5d\n", sci1FrameErrorCnt ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } - if ( ( flags & SCI_OE_INT ) != 0 ) - { - sci1OverrunErrorCnt++; - clearSCI1CommErrors(); - sprintf( debugStr, "Debug UART OR err:%5d\n", sci1OverrunErrorCnt ); - sendDebugData( (U08*)debugStr, strlen(debugStr) ); - sendDebugDataToUI( (U08*)debugStr ); - } - } -#endif } /*********************************************************************//** @@ -345,7 +311,7 @@ break; #endif default: - // TODO - ignore? + // TODO - s/w fault break; } } Index: firmware/App/Services/SystemComm.c =================================================================== diff -u -rb01c6571b1ffade6de3e0bf6890de918f4d8b47d -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Services/SystemComm.c (.../SystemComm.c) (revision b01c6571b1ffade6de3e0bf6890de918f4d8b47d) +++ firmware/App/Services/SystemComm.c (.../SystemComm.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -1225,7 +1225,7 @@ break; default: - // TODO - unrecognized message ID received - ignore + // Unrecognized message ID received - ignore break; } @@ -1504,7 +1504,7 @@ break; default: - // TODO - unrecognized message ID received - ignore + // Unrecognized message ID received - ignore break; } } Index: firmware/App/Services/SystemCommMessages.c =================================================================== diff -u -rb01c6571b1ffade6de3e0bf6890de918f4d8b47d -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/App/Services/SystemCommMessages.c (.../SystemCommMessages.c) (revision b01c6571b1ffade6de3e0bf6890de918f4d8b47d) +++ firmware/App/Services/SystemCommMessages.c (.../SystemCommMessages.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -1748,8 +1748,6 @@ memcpy( &payload, message->payload, sizeof(LOAD_CELL_READINGS_PAYLOAD_T) ); setNewLoadCellReadings( payload.res1PrimaryLoadCell, payload.res1BackupLoadCell, payload.res2PrimaryLoadCell, payload.res2BackupLoadCell ); } - // TODO - what to do if invalid payload length? - // TODO - how to know if DG stops sending these? } /*********************************************************************//** @@ -1792,7 +1790,6 @@ memcpy( &payload, message->payload, sizeof(DG_RO_PUMP_DATA_PAYLOAD_T) ); setDGROPumpData( payload.setPtPSI, payload.measFlowRateMlMin ); } - // TODO - what to do if invalid payload length? } /*********************************************************************//** @@ -1813,7 +1810,6 @@ memcpy( &payload, message->payload, sizeof(DG_DRAIN_PUMP_DATA_PAYLOAD_T) ); setDGDrainPumpData( payload.setPtRPM ); } - // TODO - what to do if invalid payload length? } /*********************************************************************//** @@ -1834,7 +1830,6 @@ memcpy( &payload, message->payload, sizeof(DG_PRESSURES_DATA_PAYLOAD_T) ); setDGPressures( payload.roInPSI, payload.roOutPSI, payload.drainInPSI, payload.drainOutPSI ); } - // TODO - what to do if invalid payload length? } /*********************************************************************//** @@ -1855,7 +1850,6 @@ memcpy( &payload, message->payload, sizeof(DG_RESERVOIRS_DATA_PAYLOAD_T) ); setDGReservoirsData( (DG_RESERVOIR_ID_T)payload.resID, payload.setFillToVolumeMl, payload.setDrainToVolumeMl ); } - // TODO - what to do if invalid payload length? } /*********************************************************************//** Index: firmware/source/sys_main.c =================================================================== diff -u -rb01c6571b1ffade6de3e0bf6890de918f4d8b47d -rd3b7ae356aae29c99cb039713a2e120fdbce5a9c --- firmware/source/sys_main.c (.../sys_main.c) (revision b01c6571b1ffade6de3e0bf6890de918f4d8b47d) +++ firmware/source/sys_main.c (.../sys_main.c) (revision d3b7ae356aae29c99cb039713a2e120fdbce5a9c) @@ -150,7 +150,6 @@ etpwmSetCmpA( etpwmREG7, etpwmREG7->TBPRD / 3 ); etpwmStartTBCLK(); canInit(); // CAN1 = CAN, re-purposing CAN2 and CAN3 Rx and Tx pins as GPIO - //canEnableloopback( canREG1, External_Lbk ); // TODO - debug code sciInit(); // SCI1 used for PC serial interface, SCI2 used for FPGA serial interface dmaEnable(); // Enable DMA }