Index: leahi_dialin/fp/modules/permeate_tank.py =================================================================== diff -u -r1c0302ebcb0d4d70249ab0932f43b0143e19a1d9 -r1f2bf6d939eb4033dbedb7d7005494cc12fccbc6 --- leahi_dialin/fp/modules/permeate_tank.py (.../permeate_tank.py) (revision 1c0302ebcb0d4d70249ab0932f43b0143e19a1d9) +++ leahi_dialin/fp/modules/permeate_tank.py (.../permeate_tank.py) (revision 1f2bf6d939eb4033dbedb7d7005494cc12fccbc6) @@ -7,33 +7,35 @@ # # @file permeate_tank.py # -# @author (last) Micahel Garthwaite -# @date (last) 07-Mar-2023 +# @author (last) Zoltan Miskolci +# @date (last) 05-May-2026 # @author (original) Micahel Garthwaite # @date (original) 29-Oct-2020 # ############################################################################ -import struct -from enum import unique + +# Module imports from logging import Logger -from .constants import RESET, NO_RESET -from leahi_dialin.common.msg_defs import MsgIds, MsgFieldPositions -from leahi_dialin.protocols.CAN import DenaliMessage, DenaliChannels -from leahi_dialin.utils.base import AbstractSubSystem, publish, DialinEnum -from leahi_dialin.utils.checks import check_broadcast_interval_override_ms -from leahi_dialin.utils.conversions import integer_to_bytearray, float_to_bytearray +# Project imports +from leahi_dialin.common.constants import NO_RESET +from leahi_dialin.common.generic_defs import DataTypes +from leahi_dialin.common.msg_defs import MsgIds +from leahi_dialin.common.override_templates import cmd_generic_broadcast_interval_override +from leahi_dialin.protocols.CAN import CanMessenger, CanChannels +from leahi_dialin.utils.abstract_classes import AbstractSubSystem +from leahi_dialin.utils.base import publish + class FPPermeateTank(AbstractSubSystem): """ Permeate Tank Filtration Purification (FP) Dialin API sub-class for permeate tank related commands. """ - def __init__(self, can_interface, logger: Logger): + def __init__(self, can_interface: CanMessenger, logger: Logger): """ - @param can_interface: Leahi Can Messenger object """ super().__init__() @@ -42,27 +44,30 @@ self.logger = logger if self.can_interface is not None: - channel_id = DenaliChannels.dd_sync_broadcast_ch_id - msg_id = MsgIds.MSG_ID_FP_PERMEATE_TANK_DATA.value - self.can_interface.register_receiving_publication_function(channel_id, msg_id, - self._handler_permeate_tank_sync) + self.can_interface.register_receiving_publication_function(channel_id = CanChannels.fp_sync_broadcast_ch_id, # Channels.dd_sync_broadcast_ch_id ?? + message_id = MsgIds.MSG_ID_FP_PERMEATE_TANK_DATA.value, + function = self._handler_permeate_tank_sync) - self.permeate_tank_state = 0 - self.permeate_tank_timestamp = 0.0 + self.permeate_tank_timestamp = 0.0 #: The timestamp of the last message + self.permeate_tank_state = 0 #: The Permeate Tank's State value + + @publish(["msg_id_fp_permeate_tank_data", "permeate_tank_state", "permeate_tank_timestamp"]) def _handler_permeate_tank_sync(self, message, timestamp=0.0): """ Handles permeate tank data messages. @param message: published permeate tank data message @return: None """ + msg_list =[] + msg_list.append(('self.permeate_tank_state', DataTypes.U32)) - self.permeate_tank_state = struct.unpack('I', bytearray( - message['message'][MsgFieldPositions.START_POS_FIELD_1:MsgFieldPositions.END_POS_FIELD_1]))[0] - + self.process_into_vars(decoder_list = msg_list, + message = message) self.permeate_tank_timestamp = timestamp + def cmd_permeate_tank_broadcast_interval_override(self, ms: int, reset: int = NO_RESET) -> int: """ Constructs and sends the broadcast time interval override for permeate tank data. @@ -74,25 +79,11 @@ @param reset: (int) 1 to reset a previous override, 0 to override @returns 1 if successful, zero otherwise """ - if not check_broadcast_interval_override_ms(ms): - return False - - reset_value = integer_to_bytearray(reset) - interval_value = integer_to_bytearray(ms) - payload = reset_value + interval_value - - message = DenaliMessage.build_message(channel_id=DenaliChannels.dialin_to_fp_ch_id, - message_id=MsgIds.MSG_ID_FP_PERMEATE_TANK_PUBLISH_INTERVAL_OVERRIDE_REQUEST.value, - payload=payload) - - self.logger.debug("Sending {} ms publish interval to the Permeate Tank module".format(ms)) - # Send message - received_message = self.can_interface.send(message) - - # If there is content in message - if received_message is not None: - # Response payload is OK or not - return received_message['message'][DenaliMessage.PAYLOAD_START_INDEX] - else: - self.logger.debug("Timeout!!!!") - return False \ No newline at end of file + return cmd_generic_broadcast_interval_override( + ms = ms, + reset = reset, + channel_id = CanChannels.dialin_to_fp_ch_id, + msg_id = MsgIds.MSG_ID_FP_PERMEATE_TANK_PUBLISH_INTERVAL_OVERRIDE_REQUEST, + module_name = 'FP Permeate Tank', + logger = self.logger, + can_interface = self.can_interface)