Index: PIControllers.c =================================================================== diff -u -r38a7e5c6f4ecd3f33a54783cfca074af4617053a -rbbe216fe2c07c329d1ff5a3a1b609202006cf87a --- PIControllers.c (.../PIControllers.c) (revision 38a7e5c6f4ecd3f33a54783cfca074af4617053a) +++ PIControllers.c (.../PIControllers.c) (revision bbe216fe2c07c329d1ff5a3a1b609202006cf87a) @@ -7,8 +7,8 @@ * * @file PIControllers.c * -* @author (last) Vinayakam Mani -* @date (last) 14-Apr-2026 +* @author (last) Sameer Kalliadan Poyil +* @date (last) 16-Apr-2026 * * @author (original) Vinayakam Mani * @date (original) 07-Oct-2024 @@ -77,6 +77,8 @@ { 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.1, CONTROLLER_UNIDIRECTIONAL, FALSE, 0.0 }, // PI_CONTROLLER_ID_RO_PUMP_MAX_PRES { 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.5, CONTROLLER_UNIDIRECTIONAL, FALSE, 0.0 }, // PI_CONTROLLER_ID_BOOST_PUMP_FLOW { 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.1, CONTROLLER_UNIDIRECTIONAL, FALSE, 0.0 }, // PI_CONTROLLER_ID_BOOST_PUMP_PRES + { 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 75.0, CONTROLLER_UNIDIRECTIONAL, FALSE, 0.0 }, // PI_CONTROLLER_ID_BICARB_VOL + { 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1000.0, CONTROLLER_UNIDIRECTIONAL, FALSE, 0.0 }, // PI_CONTROLLER_ID_ACID_VOL #endif }; @@ -344,6 +346,52 @@ /*********************************************************************//** * @brief + * The getPIControllerSignals function returns the latest requested signal sample. + * @details \b Inputs: none + * @details \b Outputs: none + * @details \b Alarms: ALARM_ID_XX_SOFTWARE_FAULT when invalid PI controller + * Id is passed. + * @details \b Alarms: ALARM_ID_XX_SOFTWARE_FAULT when invalid PI controller + * signal is passed. + * @param controllerID ID filter number + * @param signalID signal sample ID request + * @return latest sample requested + *************************************************************************/ +PI_CONTROLLER_SIGNALS_DATA getDebugPIControllerSignals( PI_CONTROLLER_ID_T controllerID ) +{ + PI_CONTROLLER_T *controller; + PI_CONTROLLER_SIGNALS_DATA signals; + + if ( controllerID < NUM_OF_PI_CONTROLLERS_IDS ) + { + SET_CONTROLLER( controller, controllerID ); + + signals.controlSignalReference = controller->referenceSignal; + signals.controlSignalMeasured = controller->measuredSignal; + signals.controlSignalError = controller->errorSignal; + signals.controlSignalErrorSum = controller->errorSumBeforeWindUp; + signals.controlSignalErrorSumAfterWindup = controller->errorSum; + signals.controlSignalProportionalOutput = controller->Kp * controller->errorSignal; + signals.controlSignalIntegralOutput = controller->Ki * controller->errorSum; + signals.controlSignalFeedDorwardOutput = controller->feedForward; + signals.controlSingalControl = controller->controlSignal; + } + else + { // Invalid controller given +#ifdef _DD_ + SET_ALARM_WITH_2_U32_DATA( ALARM_ID_DD_SOFTWARE_FAULT, SW_FAULT_ID_PI_CTRL_INVALID_CONTROLLER, (U32)controllerID ) +#elif _TD_ + SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT, SW_FAULT_ID_PI_CTRL_INVALID_CONTROLLER, (U32)controllerID ) +#else + #error "Unsupported platform" +#endif + } + + return signals; +} + +/*********************************************************************//** + * @brief * The setPIControllerFeedForward function sets the latest feed forward value * to the corresponding PI controller. * @details \b Inputs: none