Fisheye on application/resources/fonts https://devapps.diality.us/changelog/application/resources/fonts Recent activity in "application" under directory /resources/fonts UI-DEN-1710-1: closed by Dara Navaei Tue, 28 Jan 2020 10:39:22 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Dara Navaei Closed UI-DEN-1710-1 ]]> UI-DEN-1710-1: started by Dara Navaei Tue, 28 Jan 2020 10:37:14 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Dara Navaei started review UI-DEN-1710-1 ]]> UI-DEN-1710-1: reviewers finished Thu, 23 Jan 2020 14:00:15 -0800 https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 pmontazemi  (deleted user) and Dara Navaei finished reviewing UI-DEN-1710-1 UI-DEN-1710_Acknow ]]> UI-DEN-1710-1: closed by Behrouz NematiPour Thu, 23 Jan 2020 12:47:12 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Behrouz NematiPour Closed UI-DEN-1710-1 ]]> UI-DEN-1710-1: reviewers removed from UI-DEN-1710_Acknow Thu, 23 Jan 2020 12:46:09 -0800 https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Dara Navaei removed Sean Nash from UI-DEN-1710-1 UI-DEN-1710_Acknow ]]> UI-DEN-1710-1: reviewers added to UI-DEN-1710_Acknow Thu, 23 Jan 2020 10:22:34 -0800 https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Dara Navaei added Sean Nash to UI-DEN-1710-1 UI-DEN-1710_Acknow ]]> UI-DEN-1710-1: comment by pmontazemi "RESOLVED." Wed, 22 Jan 2020 10:28:34 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1181 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1181 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-1710-1

RESOLVED.

]]> UI-DEN-1710-1: comment by pmontazemi "RESOLVED." Wed, 22 Jan 2020 10:28:21 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1180 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1180 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-1710-1

RESOLVED.

]]> UI-DEN-1710-1: comment by pmontazemi "RESOLVED." Wed, 22 Jan 2020 10:28:03 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1179 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1179 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-1710-1

RESOLVED.

]]> UI-DEN-1710-1: comment by pmontazemi "RESOLVED." Wed, 22 Jan 2020 10:27:47 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1178 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1178 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-1710-1

RESOLVED.

]]> UI-DEN-1710-1: comment by Behrouz NematiPour "Updated." Wed, 22 Jan 2020 10:24:41 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1/#c1177 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1177 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-1710-1

Updated.

]]> UI-DEN-1710-1: comment by Behrouz NematiPour "They didn't intended to be removed. Commented ..." Wed, 22 Jan 2020 10:24:25 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1/#c1176 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1176 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-1710-1

They didn't intended to be removed.
Commented for a while and forget to revert back.
Updated.

]]> UI-DEN-1710-1: comment by Behrouz NematiPour "modified." Wed, 22 Jan 2020 10:23:39 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1/#c1175 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1175 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-1710-1

modified.

]]> UI-DEN-1710-1: comment by Behrouz NematiPour "OCD? They where not aligned." Wed, 22 Jan 2020 10:08:17 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1/#c1173 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1173 Behrouz NematiPour replied to pmontazemi  (deleted user) in UI-DEN-1710-1

OCD?
They where not aligned.

]]> UI-DEN-1710-1: comment by pmontazemi "What was wrong with the ; at the end of each li..." Wed, 22 Jan 2020 09:43:04 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1167 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1167 pmontazemi  (deleted user) commented on UI-DEN-1710-1

What was wrong with the ; at the end of each line?

]]> UI-DEN-1710-1: comment by pmontazemi "Misspelling in word "application", also what is..." Wed, 22 Jan 2020 09:40:26 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1166 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1166 pmontazemi  (deleted user) commented on UI-DEN-1710-1

Misspelling in word "application", also what is voved?

]]> UI-DEN-1710-1: comment by pmontazemi "Remove commented lines." Wed, 22 Jan 2020 09:37:11 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1165 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1165 pmontazemi  (deleted user) commented on UI-DEN-1710-1

Remove commented lines.

]]> UI-DEN-1710-1: comment by pmontazemi "What is this comment line for?" Wed, 22 Jan 2020 09:36:47 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-1710-1/#c1164 https://devapps.diality.us/cru/UI-DEN-1710-1/#c1164 pmontazemi  (deleted user) commented on UI-DEN-1710-1

What is this comment line for?

]]> UI-DEN-1710-1: started by Behrouz NematiPour Tue, 21 Jan 2020 20:48:44 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-1710-1 https://devapps.diality.us/cru/UI-DEN-1710-1 Behrouz NematiPour started review UI-DEN-1710-1 ]]> UI-DEN-626-1: closed by Dara Navaei Sat, 07 Dec 2019 11:49:30 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei Closed UI-DEN-626-1 ]]> UI-DEN-626-1: reviewers finished Sat, 07 Dec 2019 11:37:35 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Thu, 05 Dec 2019 10:02:56 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 pmontazemi  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Wed, 04 Dec 2019 08:52:51 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 lbaloa  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by lbaloa "RESOLVED" Wed, 04 Dec 2019 08:51:51 -0800 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c450 https://devapps.diality.us/cru/UI-DEN-626-1/#c450 lbaloa  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

RESOLVED

]]> UI-DEN-626-1: comment by pmontazemi "Leo, Resolving the case in not enough, you a..." Fri, 01 Nov 2019 15:34:17 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-626-1/#c187 https://devapps.diality.us/cru/UI-DEN-626-1/#c187 pmontazemi  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

]]> UI-DEN-626-1: comment by Behrouz NematiPour "seems like when I replied the emails were not w..." Mon, 28 Oct 2019 17:47:58 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c169 https://devapps.diality.us/cru/UI-DEN-626-1/#c169 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

seems like when I replied the emails were not working
Just as a reminder.

]]> UI-DEN-626-1: reviewers joined UI-DEN-626_UI Power Off Screen Mon, 28 Oct 2019 16:30:23 -0700 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei joined UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by Behrouz NematiPour "Thanks for the comment. static class member ..." Thu, 24 Oct 2019 10:46:41 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c124 https://devapps.diality.us/cru/UI-DEN-626-1/#c124 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

]]> UI-DEN-626-1: comment by lbaloa "initialize with nullptr for consistency" Thu, 24 Oct 2019 09:14:52 -0700 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c123 https://devapps.diality.us/cru/UI-DEN-626-1/#c123 lbaloa  (deleted user) commented on UI-DEN-626-1

initialize with nullptr for consistency

]]> UI-DEN-626-1: started by Behrouz NematiPour Tue, 22 Oct 2019 18:21:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Behrouz NematiPour started review UI-DEN-626-1 ]]>