Sean Nash

About
  • First commit 24 September 2019
  • Latest commit 09 January 2026
Last Week All Time
Commits: 0 4,044

Reviews

32 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sean Nash is mapped to 34 committers over 12 repositories
Username snash is mapped to:
Today
12 mins ago

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

21 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

27 mins ago

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

28 mins ago

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

29 mins ago

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

31 mins ago

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

35 mins ago

Sean Nash

Do we need to say Value?

Do we need to say Value?

37 mins ago

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

38 mins ago

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

39 mins ago

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

40 mins ago

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

48 mins ago

Sean Nash

I believe conductivity and temperature data will be F32s.

I believe conductivity and temperature data will be F32s.

52 mins ago

Sean Nash

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

56 mins ago

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

1 hr ago

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

1 hr ago

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

1 hr ago

Sean Nash

2 hrs ago

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

6 hrs ago

Sean Nash

Monday 02 Feb
4:00 pm

Sean Nash

2:02 pm

Sean Nash

Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

1:55 pm

Sean Nash

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

1:30 pm

Sean Nash

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
11:03 am

Sean Nash

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

11:01 am

Sean Nash

10:55 am

Sean Nash

Remove blank line.

Remove blank line.

10:55 am

Sean Nash

Add a blank line before return statement.

Add a blank line before return statement.

10:52 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:51 am

Sean Nash

d48PumpSpeed is an input.

d48PumpSpeed is an input.