LEAHI-TD-FIRMWARE-LDT-1415-1 LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

open for 30 hours

Author

Moderator

Reviewers

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 106

leahi-common 0
- File AlarmDefs.h 7 Remove
- File DDDefs.h 0 Remove
- File MsgDefs.h 0 Remove
- File TDDefs.h 0 Remove
leahi-fwcommon 0
- File TestSupport.h 0 Remove
td-firmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File AirPump.c 0 Remove
      - File AirPump.h 0 Remove
      - File AirTrap.c 0 Remove
      - File AirTrap.h 0 Remove
      - File AlarmAudio.c 0 Remove
      - File AlarmAudio.h 0 Remove
      - File AlarmLamp.c 0 Remove
      - File AlarmLamp.h 0 Remove
      - File BloodFlow.c 0 Remove
      - File BloodFlow.h 0 Remove
      - File Ejector.c 0 Remove
      - File Ejector.h 0 Remove
      - File Valves.c 0 Remove
      - File Valves.h 0 Remove
    - Folder Drivers 0
      - File BubbleDetector.c 0 Remove
      - File BubbleDetector.h 0 Remove
      - File EjectorMotor.c 0 Remove
      - File EjectorMotor.h 0 Remove
      - File GLXferPump.c 0 Remove
      - File GLXferPump.h 0 Remove
      - File GPIO.c 0 Remove
      - File GPIO.h 0 Remove
      - File InternalADC.c 0 Remove
      - File InternalADC.h 0 Remove
      - File LevelSensors.c 0 Remove
      - File LevelSensors.h 0 Remove
      - File PAL.c 0 Remove
      - File PAL.h 0 Remove
      - File PeristalticPump.c 0 Remove
      - File PeristalticPump.h 0 Remove
      - File PressureSensor.c 13 Remove
      - File PressureSensor.h 0 Remove
      - File RotaryValve.c 0 Remove
      - File RotaryValve.h 0 Remove
      - File Valve2Way.c 0 Remove
      - File Valve2Way.h 0 Remove
      - File Valve3Way.c 0 Remove
      - File Valve3Way.h 0 Remove
    - Folder Modes 0
      - File ModeFault.c 0 Remove
      - File ModeFault.h 0 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModeInitPOST.h 0 Remove
      - File ModePreTreat.c 0 Remove
      - File ModePreTreat.h 0 Remove
      - File ModeService.c 0 Remove
      - File ModeService.h 0 Remove
      - File ModeStandby.c 0 Remove
      - File ModeStandby.h 0 Remove
      - File ModeTreatment.c 0 Remove
      - File ModeTreatment.h 0 Remove
      - File ModeTxParams.c 0 Remove
      - File ModeTxParams.h 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
      - File StateTxDialysis.c 0 Remove
      - File StateTxDialysis.h 0 Remove
      - File StateTxPaused.c 0 Remove
      - File StateTxPaused.h 0 Remove
    - Folder Monitors 0
      - File Bubbles.c 0 Remove
      - File Bubbles.h 0 Remove
      - File Buttons.c 0 Remove
      - File Buttons.h 0 Remove
      - File Pressures.c 31 Remove
      - File Pressures.h 0 Remove
      - File Switches.c 0 Remove
      - File Switches.h 0 Remove
      - File Temperatures.c 0 Remove
      - File Temperatures.h 0 Remove
      - File Voltages.c 0 Remove
      - File Voltages.h 0 Remove
    - Folder Services 0
      - File AlarmMgmtSWFaults.h 0 Remove
      - File AlarmMgmtTD.c 0 Remove
      - File AlarmMgmtTD.h 0 Remove
      - File CpldInterface.c 0 Remove
      - File CpldInterface.h 0 Remove
      - File DDInterface.c 0 Remove
      - File DDInterface.h 0 Remove
      - File FpgaTD.c 0 Remove
      - File FpgaTD.h 0 Remove
      - File Interrupts.c 0 Remove
      - File Interrupts.h 0 Remove
      - File Messaging.c 0 Remove
      - File Messaging.h 0 Remove
      - File MsgQueues.c 0 Remove
      - File MsgQueues.h 0 Remove
      - File SystemCommTD.c 0 Remove
      - File SystemCommTD.h 0 Remove
    - Folder Tasks 0
      - File TaskBG.c 0 Remove
      - File TaskBG.h 0 Remove
      - File TaskGeneral.c 0 Remove
      - File TaskGeneral.h 0 Remove
      - File TaskPriority.c 0 Remove
      - File TaskPriority.h 0 Remove
      - File TaskTimer.c 0 Remove
      - File TaskTimer.h 0 Remove
    - File TDCommon.h 2 Remove
  - Folder include 0
    - File can.h 0 Remove
  - Folder source 0
    - File adc.c 0 Remove
    - File can.c 0 Remove
  - File TD.dil 0 Remove
  - File checkAlarms.sh 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Vendor - TEL - Varshini Nagabooshanam	Author & Moderator	3h 37m	27	Yes, we do and this is not required here so, I removed
Vendor - TEL - Arpita Srivastava	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Sean Nash	Reviewer - 2% reviewed	1h 44m	26	Shouldn't we be getting these defaults from the TxParams ...
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Daniel Ho	Reviewer - 0% reviewed
Raghu Kallala	Reviewer - 0% reviewed	7m
Dara Navaei	Reviewer - 0% reviewed	20m
Vendor - TEL - Sameer Poyil	Reviewer - 0% reviewed
Vendor - TEL - Jashwant Gantyada	Reviewer - 99% reviewed	1m
Total		5h 51m	53

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-TD-FIRMWARE-LDT-1415-1

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

LEAHI-TD-FIRMWARE-LDT-1415-1 53

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

LEAHI-TD-FIRMWARE-LDT-1415-1 53

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time