Vendor - TEL - Arpita Srivastava

4:34 pm

Vendor - TEL - Arpita Srivastava

More
1e742ba
changed 3 files
LDT-5157-conductivity-sensor-calibration in dd-firmware LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Added FP service and usage records

- -3
- +3
/firmware/App/Services/NVMessagingDD.c
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.c
- -56
- +254
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c
- -8
- +79
/firmware/App/Services/NVRecordsDD.h
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.h

4:34 pm

Vendor - TEL - Arpita Srivastava

More
70e6478
changed 1 file
LDT-5157-conductivity-sensor-calibration in leahi-common LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Added alarms for FP service and usage

- -0
- +8
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2:04 pm

Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-5214-1
finished reviewing

11:33 am

Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-4033-1
finished reviewing

11:32 am

Vendor - TEL - Arpita Srivastava

More
2078ddd
changed 2 files
LDT-5157-conductivity-sensor-calibration in dd-firmware LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Implemented queue to handle get requests

- -476
- +443
/firmware/App/Services/NVMessagingDD.c
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.c
- -2
- +2
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c

11:31 am

Vendor - TEL - Arpita Srivastava

More
cfda869
changed 4 files
LDT-5157-conductivity-sensor-calibration in leahi-fwcommon LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Improved Queue

- -23
- +33
/NVJobQ.c
- History
- Source
- Diff
/NVJobQ.c
- -2
- +2
/NVJobQ.h
- History
- Source
- Diff
/NVJobQ.h
- -8
- +21
/NVMsgQ.c
- History
- Source
- Diff
/NVMsgQ.c
- -3
- +2
/NVMsgQ.h
- History
- Source
- Diff
/NVMsgQ.h

5:04 pm

Vendor - TEL - Arpita Srivastava

More
517909d
changed 1 file
LDT-5157-conductivity-sensor-calibration in dd-firmware LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Implemented a message handler queue for NVM

- -43
- +75
/firmware/App/Services/NVMessagingDD.c
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.c

5:03 pm

Vendor - TEL - Arpita Srivastava

More
ebf3ea1
changed 4 files
LDT-5157-conductivity-sensor-calibration in leahi-fwcommon LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Implemented a message handler queue for NVM

- -5
- +2
/NVJobQ.c
- History
- Source
- Diff
/NVJobQ.c
- -1
- +1
/NVJobQ.h
- History
- Source
- Diff
/NVJobQ.h
- -0
- +170
/NVMsgQ.c
- History
- Source
/NVMsgQ.c
- -0
- +62
/NVMsgQ.h
- History
- Source
/NVMsgQ.h

2:25 pm

Vendor - TEL - Arpita Srivastava

More
6d135d1
changed 4 files
LDT-5157-conductivity-sensor-calibration in dd-firmware LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Added docygen comments

- -0
- +4
/firmware/App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -134
- +300
/firmware/App/Services/NVMessagingDD.c
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.c
- -1
- +1
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c
- -1
- +1
/firmware/App/Services/NVRecordsDD.h
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.h

5:25 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

This was correct. Revert back the inputs and outputs.

5:02 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

This was correct. Rever back the inputs and outputs.

4:54 pm

Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-4063-1
finished reviewing

4:11 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4072-2
commented on review

Why are we changing the rank of an existing alarm?

3:58 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

These new functions should be above the test functions. Please align with the Messaging.c file. It looks correct in the Messaging.c file.

These new functions should be above the test functions.

Please align with the Messaging.c file.
It looks correct in the Messaging.c file.

3:54 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Move this above the test functions.

3:45 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

What is the use case of this header include?

3:33 pm