Vendor - TEL - Arpita Srivastava

LDT-3505: Removed syringe detection override functions

    • -43
    • +0
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +0
    /firmware/App/Controllers/SyringePump.h
LDT-3505: Removed msg id for syringe detection override fucnction

LDT-3505: Removed syringe detection override functions

    • -40
    • +0
    /leahi_dialin/td/modules/syringe_pump.py
LDT-3505: Removed Syringe Detection Checks

    • -106
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.h
please add a comment.

please add a comment.

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

currentAutoEjectState should be input?

currentAutoEjectState should be input?

currentAutoEjectState should be input?

currentAutoEjectState should be input?

add autoEjectTimerCounter to outputs

add autoEjectTimerCounter to outputs

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

add a space between message and )

add a space between message and )

Change // to /// for doxygen to catch it.

Change // to /// for doxygen to catch it.

Can we remove the parameter and switch directly over currentPostTreatmentState?

Can we remove the parameter and switch directly over currentPostTreatmentState?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

LDT-3505: Added msg ids for syringe pump module

LDT-3505: Mapped message ids and message handlers for syringe pump test functions

    • -40
    • +62
    /firmware/App/Controllers/SyringePump.c
    • -6
    • +7
    /firmware/App/Controllers/SyringePump.h
LDT-3505: Added Syringe Pump module in TD

    • -0
    • +794
    /leahi_dialin/td/modules/syringe_pump.py
    • -1
    • +3
    /leahi_dialin/td/treatment_delivery.py
    • -0
    • +243
    /tools/Log_dd_new.py
Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

LDT-3505: Aligned syringe pump function definitions with declarations

    • -494
    • +505
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +2
    /firmware/App/Controllers/SyringePump.h
LDT-3505: Merged latest staging into LDT-3505

LDT-3505: Merged latest staging into LDT-3505

    • -7
    • +7
    /firmware/App/Controllers/SyringePump.c
    • -10
    • +45
    /firmware/App/Modes/ModeTreatment.c