Vendor - TEL - Arpita Srivastava

About
  • First commit 28 October 2025
  • Latest commit 07 May 2026
Last Week All Time
Commits: 7 130

Reviews

12 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Vendor - TEL - Arpita Srivastava is mapped to 12 committers over 7 repositories
Username ven.asrivastava is mapped to:
Thursday 07 May
11:35 am

Vendor - TEL - Arpita Srivastava

LDT-3505: Removed syringe detection override functions

Options
    • -43
    • +0
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +0
    /firmware/App/Controllers/SyringePump.h
    • -6
    • +6
    /firmware/App/Services/FpgaTD.c
    • -1
    • +0
    /firmware/App/Services/Messaging.c
    • -0
    • +2
    /firmware/source/sys_main.c
11:34 am

Vendor - TEL - Arpita Srivastava

LDT-3505: Removed msg id for syringe detection override fucnction

Options
    • -10
    • +9
    /MsgDefs.h
11:33 am

Vendor - TEL - Arpita Srivastava

LDT-3505: Removed syringe detection override functions

Options
    • -10
    • +9
    /leahi_dialin/common/msg_ids.py
    • -40
    • +0
    /leahi_dialin/td/modules/syringe_pump.py
    • -243
    • +0
    /tools/Log_dd_new.py
Wednesday 06 May
5:06 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Removed Syringe Detection Checks

Options
    • -106
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +0
    /firmware/App/Controllers/SyringePump.h
Tuesday 05 May
11:48 am

Vendor - TEL - Arpita Srivastava

please add a comment.

please add a comment.

11:47 am

Vendor - TEL - Arpita Srivastava

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

11:44 am

Vendor - TEL - Arpita Srivastava

currentAutoEjectState should be input?

currentAutoEjectState should be input?

11:42 am

Vendor - TEL - Arpita Srivastava

currentAutoEjectState should be input?

currentAutoEjectState should be input?

11:39 am

Vendor - TEL - Arpita Srivastava

add autoEjectTimerCounter to outputs

add autoEjectTimerCounter to outputs

11:36 am

Vendor - TEL - Arpita Srivastava

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

11:36 am

Vendor - TEL - Arpita Srivastava

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

11:13 am

Vendor - TEL - Arpita Srivastava

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

11:10 am

Vendor - TEL - Arpita Srivastava

11:10 am

Vendor - TEL - Arpita Srivastava

11:09 am

Vendor - TEL - Arpita Srivastava

11:09 am

Vendor - TEL - Arpita Srivastava

10:51 am

Vendor - TEL - Arpita Srivastava

add a space between message and )

add a space between message and )

10:48 am

Vendor - TEL - Arpita Srivastava

Change // to /// for doxygen to catch it.

Change // to /// for doxygen to catch it.

10:31 am

Vendor - TEL - Arpita Srivastava

Can we remove the parameter and switch directly over currentPostTreatmentState?

Can we remove the parameter and switch directly over currentPostTreatmentState?

10:21 am

Vendor - TEL - Arpita Srivastava

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

9:59 am

Vendor - TEL - Arpita Srivastava

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

Monday 04 May
4:47 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Added msg ids for syringe pump module

Options
    • -2
    • +16
    /MsgDefs.h
4:46 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Mapped message ids and message handlers for syringe pump test functions

Options
    • -40
    • +62
    /firmware/App/Controllers/SyringePump.c
    • -6
    • +7
    /firmware/App/Controllers/SyringePump.h
    • -0
    • +15
    /firmware/App/Services/Messaging.c
4:44 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Added Syringe Pump module in TD

Options
    • -0
    • +15
    /leahi_dialin/common/msg_ids.py
    • -1
    • +24
    /leahi_dialin/common/td_defs.py
    • -0
    • +794
    /leahi_dialin/td/modules/syringe_pump.py
    • -1
    • +3
    /leahi_dialin/td/treatment_delivery.py
    • -0
    • +243
    /tools/Log_dd_new.py
9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Friday 01 May
4:40 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Aligned syringe pump function definitions with declarations

Options
    • -494
    • +505
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +2
    /firmware/App/Controllers/SyringePump.h
    • -8
    • +2
    /firmware/App/Tasks/TaskPriority.c
3:18 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Merged latest staging into LDT-3505

Options
    • -2
    • +4
    /PersistentAlarm.h
    • -5
    • +10
    /TestSupport.h
3:17 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Merged latest staging into LDT-3505

Options
    • -7
    • +7
    /firmware/App/Controllers/SyringePump.c
    • -10
    • +45
    /firmware/App/Modes/ModeTreatment.c
    • -7
    • +10
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -3
    • +28
    /firmware/App/Services/FpgaTD.c
    • -2
    • +4
    /firmware/App/Services/FpgaTD.h