leahi-dialin

Clone Tools

Stats

Commits this week: 48
Total Committers: 16
Last Commit: 25 Jun
Commits this week: 48

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

5:03 pm

Zoltan Miskolci

added fp sensor chekup for records

Options
    • -1
    • +3
    /leahi_dialin/dd/modules/records.py
4:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
4:13 pm

Vendor - TEL - Sameer Poyil

4:13 pm

Zoltan Miskolci

4:07 pm

Zoltan Miskolci

3:57 pm

Zoltan Miskolci

Initial Battery module

Options
    • -0
    • +4
    /leahi_dialin/common/msg_ids.py
    • -0
    • +32
    /leahi_dialin/common/td_defs.py
    • -0
    • +1
    /leahi_dialin/common/td_defs_proxy.py
    • -2
    • +0
    /leahi_dialin/td/modules/air_pump.py
    • -2
    • +0
    /leahi_dialin/td/modules/air_trap.py
    • -0
    • +133
    /leahi_dialin/td/modules/battery.py
    • -2
    • +0
    /leahi_dialin/td/modules/bubble_detector.py
    • -2
    • +0
    /leahi_dialin/td/modules/ejector.py
    • -1
    • +1
    /leahi_dialin/td/modules/switches.py
    • -2
    • +0
    /leahi_dialin/td/modules/syringe_pump.py
    • -0
    • +2
    /leahi_dialin/td/treatment_delivery.py
3:55 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-4612-dialysate-composition-dialin-fix-for-mixing-control into develop

Options
    • -0
    • +1
    /leahi_dialin/common/msg_ids.py
3:55 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-4612-dialysate-composition-dialin-fix-for-mixing-control into staging

Options
    • -1
    • +3
    /leahi_dialin/common/msg_ids.py
3:20 pm

Nicholas Ramirez

change to td_powerOff_wARNING

change to td_powerOff_wARNING

3:04 pm

Zoltan Miskolci

updated records

Options
    • -15
    • +21
    /leahi_dialin/dd/modules/records.py
    • -302
    • +22
    /leahi_dialin/td/modules/records.py
2:51 pm

Behrouz NematiPour

1:30 pm

Michael Garthwaite

Merge branch 'LDT-4733-request-add-variables' into develop

Options
    • -2
    • +2
    /leahi_dialin/dd/modules/voltages.py
1:29 pm

Michael Garthwaite

LDt-4733: fixed typo in voltage module

Options
    • -2
    • +2
    /leahi_dialin/dd/modules/voltages.py
11:25 am

Zoltan Miskolci

Updated calibration record fields

Options
    • -0
    • +11
    /leahi_dialin/common/generic_defs.py
    • -4
    • +29
    /leahi_dialin/common/msg_ids.py
11:05 am

Zoltan Miskolci

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

10:45 am

Michael Garthwaite

Merge branch 'LDT-4733-request-add-variables' into develop

Options
    • -3
    • +3
    /leahi_dialin/common/msg_ids.py
    • -9
    • +17
    /leahi_dialin/dd/modules/voltages.py
10:41 am

Michael Garthwaite

LDT-4733: voltage monitoring updates.

Options
    • -1
    • +9
    /leahi_dialin/common/dd_defs.py
    • -9
    • +17
    /leahi_dialin/dd/modules/voltages.py
8:47 am

Dara Navaei

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Wednesday 24 Jun
9:23 pm

Vinayakam Mani

9:14 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review commend

Options
    • -2
    • +2
    /leahi_dialin/dd/modules/mixing_cntrl.py
4:20 pm

Zoltan Miskolci

updated process functions debug part

Options
    • -11
    • +16
    /leahi_dialin/utils/abstract_classes.py
4:10 pm

Zoltan Miskolci

changed index to U08

Options
    • -4
    • +4
    /leahi_dialin/dd/modules/records.py
4:08 pm

Zoltan Miskolci

- Updated institutional record and system record handler

Options
    • -22
    • +22
    /leahi_dialin/dd/modules/records.py
    • -11
    • +13
    /leahi_dialin/utils/abstract_classes.py
2:56 pm

Vinayakam Mani

Update the name.

Update the name.

2:46 pm

Zoltan Miskolci

expected structure

Options
    • -2
    • +2
    /leahi_dialin/td/modules/alarms.py
2:39 pm

Vendor - TEL - Sameer Poyil