Raghu Kallala

ROPump is repeated

ROPump is repeated

RECOVERY_STATES

RECOVERY_STATES

LDT-3603 added condition to reset and start sub mode in signal function

    • -1
    • +1
    /firmware/App/Modes/FPModes/FPOperationModes.c
LDt-3749 WIP initial draft for DD set sub mode request

LDt-3749 WIP initial draft for DD set sub mode request

    • -0
    • +67
    /firmware/App/Modes/ModeGenDialysate.c
    • -0
    • +2
    /firmware/App/Modes/ModeGenDialysate.h
    • -0
    • +56
    /firmware/App/Modes/ModePostGenDialysate.c
    • -0
    • +61
    /firmware/App/Modes/ModePreGenDialysate.c
    • -0
    • +2
    /firmware/App/Modes/ModePreGenDialysate.h
    • -5
    • +165
    /firmware/App/Modes/OperationModes.c
update params

update params

Intentional?

Intentional?

update the header and field comments in later commits

update the header and field comments in later commits

LDT-3603 changed code to return false when pause state is requested.

pressure limit will be unsigned int not signed int with LDT-473..beta CR Add a TODO to update once the 473 is ready to merge

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

Are these print statements add for debugging? If not, is this allowed

Are these print statements add for debugging?
If not, is this allowed

typo, PUMP_ON_STATE

typo, PUMP_ON_STATE

LDT-3603 addressed review comments and added missing code

    • -0
    • +62
    /firmware/App/Modes/FPModes/FPModeFault.c
    • -1
    • +4
    /firmware/App/Modes/FPModes/FPModeFault.h
    • -0
    • +52
    /firmware/App/Modes/FPModes/FPModeStandby.c
    • -88
    • +103
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -48
    • +55
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -2
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeate.h
That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

Updated

Updated

Updated

Updated

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

LDT-3603 fixed typo in comments

    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
LDT-3603 moved declaration to top of the scope

    • -2
    • +5
    /firmware/App/Modes/FPModes/FPOperationModes.c
LDT-3603 added validate before making a request call in dialin test handler

    • -53
    • +111
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -3
    • +1
    /firmware/App/Modes/FPModes/FPOperationModes.h
    • -4
    • +21
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -0
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.h