Raghu Kallala

About
  • First commit 11 June 2025
  • Latest commit 09 December 2025
Last Week All Time
Commits: 11 131

Reviews

16 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Raghu Kallala is mapped to 9 committers over 5 repositories
Username rkallala is mapped to:
Thursday 11 Dec
8:23 am

Raghu Kallala

Add a 1 second persistence on this alarm

Add a 1 second persistence on this alarm

7:26 am

Raghu Kallala

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

7:24 am

Raghu Kallala

Need to remove this handler

Need to remove this handler

7:22 am

Raghu Kallala

Add blank line before return statement

Add blank line before return statement

7:21 am

Raghu Kallala

Remove handlePreGenPDefInletWaterState

Remove handlePreGenPDefInletWaterState

7:20 am

Raghu Kallala

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

7:19 am

Raghu Kallala

Call this in both Pre Gen: Verify Water and Gen Permeate

Call this in both Pre Gen: Verify Water and Gen Permeate

7:17 am

Raghu Kallala

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

7:15 am

Raghu Kallala

Put quadratic and linear terms in parentheses.

Put quadratic and linear terms in parentheses.

Tuesday 09 Dec
11:40 am

Raghu Kallala

Fixed indentation

Options
    • -5
    • +5
    /firmware/App/Controllers/ROPump.c
    • -1
    • +0
    /firmware/App/Modes/FPModes/FlushConcentrate.c
11:25 am

Raghu Kallala

11:12 am

Raghu Kallala

Resolved merge conflicts

Options
    • -19
    • +65
    /firmware/App/Controllers/PermeateTank.c
    • -26
    • +57
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Drivers/FluidPump.c
    • -2
    • +3
    /firmware/App/Modes/FPModes/FPModeFault.c
    • -0
    • +2
    /firmware/App/Modes/FPModes/FPModeStandby.c
    • -4
    • +4
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -23
    • +35
    /firmware/App/Modes/FPModes/FlushConcentrate.c
    • -19
    • +17
    /firmware/App/Modes/FPModes/FlushFilter.c
    • -10
    • +37
    /firmware/App/Modes/FPModes/FlushPermeate.c
    • -53
    • +176
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -1
    • +5
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
    • -7
    • +23
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -0
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +202
    /firmware/App/Monitors/Conductivity.c
  16. … 5 more files in changeset.
10:59 am

Raghu Kallala

LDT-2936 merge into staging

Options
    • -9
    • +12
    /AlarmDefs.h
    • -0
    • +3
    /MsgDefs.h
10:59 am

Raghu Kallala

LDT-2936 merge into staging

Options
    • -5
    • +5
    /PIControllers.c
10:32 am

Raghu Kallala

LDT-2936 fixed macro naming

Options
    • -1
    • +1
    /firmware/App/Controllers/PermeateTank.c
10:30 am

Raghu Kallala

LDT-2936 fixed macro naming

Options
    • -3
    • +3
    /firmware/App/Controllers/PermeateTank.c
10:29 am

Raghu Kallala

Resolved

Resolved

10:29 am

Raghu Kallala

LDT-2936 fixed the macro comments

Options
    • -1
    • +1
    /firmware/App/Modes/FPModes/FlushPermeate.c
10:03 am

Raghu Kallala

Fixed the ordering

Fixed the ordering

9:56 am

Raghu Kallala

LDT-2936 fixed alarm order and removed waitForTankFill from concentrate flush states

Options
    • -1
    • +1
    /AlarmDefs.h
    • -1
    • +0
    /FPDefs.h
8:36 am

Raghu Kallala

Merge branch 'LDT-2936-iofp---update-m12-and-boost-pum' of bitbucket.org:diality-cloud/dd-firmware into LDT-2936-iofp---update-m12-and-boost-pum

Options
    • -9
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
8:36 am

Raghu Kallala

LDT-2936 fixed permeate overfill issue and added tank controls to verify state

Options
    • -2
    • +2
    /firmware/App/Controllers/PermeateTank.c
    • -50
    • +23
    /firmware/App/Modes/FPModes/FlushConcentrate.c
    • -0
    • +1
    /firmware/App/Modes/FPModes/FlushFilter.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/FlushPermeate.c
    • -0
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
    • -0
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
Friday 05 Dec
9:54 am

Raghu Kallala

LDT-2936 Updated tank full/fill timeout alarms logic

Options
    • -17
    • +63
    /firmware/App/Controllers/PermeateTank.c
Thursday 04 Dec
10:30 am

Raghu Kallala

LDT-2936 address review comments to add spacing in if statements

Options
    • -3
    • +4
    /firmware/App/Modes/FPModes/FlushPermeate.c
    • -2
    • +0
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -7
    • +7
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.h
10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

Fixed.

10:11 am

Raghu Kallala

Fixed.

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

Fixed. thanks