leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove extra blank line.

Remove extra blank line.

It is your comment, so please resolve it.

It is your comment, so please resolve it.

Merge branch 'staging' into develop

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

LDT-2004-3 drybicart updates

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

Remove blank line.

Remove blank line.

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

LDT-3343 added test config to run DD alone

LDT-2004-3 Dry bicart feature updates

fixed it

fixed it

fixed it

fixed it

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Merge branch 'LDT-1415-pressures-monitoring-td' into develop

Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

Yes, Updated

Yes, Updated