Vinayakam Mani

6:47 pm

Vinayakam Mani

More
b76210a
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 resolving merge conflicts

- -15
- +96
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

6:30 pm

Vinayakam Mani

More
9d2242e
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 beta2 heatloss model update

- -15
- +96
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

3:42 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3103-3
joined review

3:41 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-3
commented on review

the else part here, should handle greater than Qd: 300?

3:38 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-3
commented on review

Get this logic into another function and call the function here.

3:33 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-3
commented on review

Is this supposed to be difference in pressure, not the spent dial pressure?

12:33 pm

Vinayakam Mani

More
b003e0e
changed 2 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware

LDT-3352 resolving merge conflicts

- -8
- +8
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +29
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

12:25 pm

Vinayakam Mani

More
d31e9b4
changed 3 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 heater control update

- -5
- +8
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +29
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -0
- +1
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

12:01 pm

Vinayakam Mani

More
60db050
changed 6 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 resolving merge conflicts

- -1
- +4
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -27
- +136
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -6
- +3
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -11
- +117
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -5
- +15
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -3
- +4
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h

11:50 am

Vinayakam Mani

More
9f0396c
changed 0 files
LDT-3352-dd---revisit-d3-level-control-l in leahi-fwcommon

LDT-3352 latest from staging

11:26 am

Vinayakam Mani

More
2554891
changed 2 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 udpated per latest staging common

- -2
- +2
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -1
- +1
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

12:13 pm

Vinayakam Mani

More
4053bb8
changed 6 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware

LDT-3352 resolving merge conflicts

- -60
- +136
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -0
- +3
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -8
- +113
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -5
- +55
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -0
- +2
/firmware/App/Monitors/Temperature.h
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.h
- -0
- +1
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h

11:48 am

Vinayakam Mani

More
c6962f9
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in leahi-fwcommon LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 heater control update

- -5
- +44
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

11:40 am

Vinayakam Mani

More
0c14c0f
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 heater control update

- -2
- +0
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

11:39 am

Vinayakam Mani

More
5c9c26f
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in leahi-fwcommon LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 dialysate temp control update

- -5
- +3
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

11:23 am

Vinayakam Mani

More
4541d91
changed 2 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3352 heater control update

- -25
- +15
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -2
- +1
/firmware/App/Controllers/Heaters.h
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.h

10:45 am

Vinayakam Mani

More
2610908
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop in dd-firmware LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 heater control update

- -2
- +7
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

10:03 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3628-1
commented on review

4 bytes reg.

10:02 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3628-1
commented on review

4 byte reg.

9:52 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3628-1
commented on review

Remove typecast.

2:47 pm

Vinayakam Mani

More
LEAHI-TD-FIRMWARE-LDT-3600-1
finished reviewing

1:45 pm

Vinayakam Mani

More
Re: LEAHI-TD-FIRMWARE-LDT-3600-1
commented on review

Can we remove the empty lines after if / else if blocks in this function?

1:43 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3103-1
started review

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed

1:31 pm

Vinayakam Mani

11:37 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Looks the fields are empty and misaligned. fill as needed.

6:14 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Result is a BOOL variable, use FALSE.

5:18 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3630-1
finished reviewing

4:43 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3630-1
joined review

3:43 pm

Vinayakam Mani

Done.

3:42 pm

Vinayakam Mani

Done.

Vinayakam Mani

About

eval(decodeURIComponent('%64%6F%63%75%6D%65%6E%74%2E%77%72%69%74%65%28%22%76%6D%61%6E%69%40%64%69%61%6C%69%74%79%2E%63%6F%6D%22%29')); var scriptElem = document.getElementById('to-removed') scriptElem.parentNode.removeChild(scriptElem);

Reviews

47 active reviews

Line History

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Committer Mappings

Vinayakam Mani is mapped to 10 committers over 9 repositories