dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-4410-dialysate-composition-mixing-2' into develop

    • -8
    • +44
    /firmware/App/Controllers/MixingControl.c
LDT-4410 addressed code review comments

    • -11
    • +15
    /firmware/App/Controllers/MixingControl.c
    • -15
    • +6
    /firmware/App/Monitors/Conductivity.c
Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

Comment missing?

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

both acid and bicarb mix volume

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.

Initialize at init function.

Initialize at init function.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Lets remove this.

Lets remove this.

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LDT-4410 inital code for filter and control interval

    • -2
    • +34
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +3
    /firmware/App/Controllers/MixingControl.h
    • -4
    • +76
    /firmware/App/Monitors/Conductivity.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch LDT-4612-dialysate-composition-integ into develop

LDT-4612 drybicart updates

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch LDT-4612-dialysate-composition-integ into develop

    • -11
    • +8
    /firmware/App/Controllers/DryBiCart.c
LDT-4612 persistence on D66 updates

    • -11
    • +8
    /firmware/App/Controllers/DryBiCart.c
Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

Space after 0

Space after 0

prevDryBicartState

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

prevBalChamberState?

LDT-4612 fix for mixing control

    • -2
    • +10
    /firmware/App/Controllers/MixingControl.c
Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.