Dashboard

LDT-4028:Addressed code review commens for Pre-Tx Install State

    • -11
    • +11
    /firmware/App/Services/TxParams.c
LDT-4072: Added MsgID for publish interval

LDT-4072: added publish interval override

    • -18
    • +55
    /firmware/App/Monitors/Battery.c
updated

updated

updated

updated

Now added function that return configuration folder path def configuration_folder_path(): """ Check for Path.home() is /home/denali then return configuration folder location else return Device conf...

Now added function that return configuration folder path
def configuration_folder_path():
"""
Check for Path.home() is /home/denali then return configuration folder location
else return Device configuration folder location
"""
home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

Now added function that return configuration folder path def configuration_folder_path(): """ Check for Path.home() is /home/denali then return configuration folder location else return Device conf...

Now added function that return configuration folder path
def configuration_folder_path():
"""
Check for Path.home() is /home/denali then return configuration folder location
else return Device configuration folder location
"""
home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

LDT-3155 Blood Set Auto-Load and Auto-Eject - SW - 02 - Q&R - 15: SIT - Software Integration Tests - Squish Qt

    • -1
    • +1
    /suite_leahi/tst_blood_set_auto/test.py
LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026 : Added test cases for ModePreGenDialysate.c file

Updated the test script with TDTreaRinsebackStates

Updated the test script with TDTreaRinsebackStates

As per suggestion using TDTreaRinsebackStates in test script

As per suggestion using TDTreaRinsebackStates in test script

LDT - 2953 Rinseback - SW - 02 - Q&R - 15: SIT - Software Integration Tests - Squish Qt

    • -12
    • +11
    /suite_leahi/tst_rinseback/test.py
I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

LDT -2280 Patient Vitals - SW - 02 - Q&R - 15: SIT - Software Integration Tests - Squish Qt

    • -4
    • +4
    /suite_leahi/tst_patient_vitals/test.py
LDT-2819 Edit Treatment Parameters During Treatment - SW - 02 - Edit Treatment Parameters During Treatment - Q&R

    • -18
    • +18
    /suite_leahi/tst_edit_parameters/test.py
Fixed payload

Fixed payload

    • -14
    • +33
    /firmware/App/Services/AlarmMgmtTD.c
LDT-4792 NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I - 05: DEV - Feature Implementation

address cr comments

    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +24
    /sources/model/td/data/MTDPowerOffWarning.cpp
    • -0
    • +55
    /sources/model/td/data/MTDPowerOffWarning.h
I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

LDT-3735: Update send handler for cal records

    • -114
    • +251
    /firmware/App/Services/NVMessagingDD.c
    • -90
    • +106
    /firmware/App/Services/NVRecordsDD.c
    • -24
    • +2
    /firmware/App/Services/NVRecordsDD.h
I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

Change the name to ArterialWindow, Art is so confusing.

Change the name to ArterialWindow, Art is so confusing.

added fp sensor chekup for records

i am good with the implementaiton

i am good with the implementaiton

Merge remote-tracking branch 'origin/feature/LDT-3208-Isolated-uf' into staging

    • -46
    • +94
    /suite_leahi/shared/scripts/names.py