Dashboard

LDT-3505: Added test config for syringe pump

    • -1
    • +1
    /leahi_dialin/common/test_config_defs.py
We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

LDT-1886: Add send event

SW fault here?

SW fault here?

Do we need this state if all it's doing is going to IDLE?

Do we need this state if all it's doing is going to IDLE?

Might have to wait for module to not be busy before getting the data.

Might have to wait for module to not be busy before getting the data.

I think we may need to give a get data command here.

I think we may need to give a get data command here.

Look for request flag to give measure command and transition to measure state.

Look for request flag to give measure command and transition to measure state.

Write private handle functions for each state and call them in each case.

Write private handle functions for each state and call them in each case.

Should we also check whether bpMeasurementReady is TRUE?

Should we also check whether bpMeasurementReady is TRUE?

Same.

Same.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state ...

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

Change comment to "Number of BP driver states."

Change comment to "Number of BP driver states."

LDT-4033-patient-vitals-fw-implementation

LDT-3505: Addressed review comments

    • -32
    • +90
    /firmware/App/Controllers/SyringePump.c
LDT-4033-patient-vitals-fw-implementation

Not really, I can change this to private

Not really, I can change this to private

Add a 5th enum for NUM_OF_BP_DRIVER_STATES. And, does this need to be public?

Add a 5th enum for NUM_OF_BP_DRIVER_STATES.
And, does this need to be public?

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

New module

    • -0
    • +199
    /firmware/App/Controllers/BPModule.c
    • -0
    • +45
    /firmware/App/Controllers/BPModule.h
    • -0
    • +216
    /firmware/App/Drivers/BPDriver.c
    • -0
    • +68
    /firmware/App/Drivers/BPDriver.h
if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

Remove extra blank line.

Remove extra blank line.

LDT-4033-patient-vitals-fw-implementation

LDT-4033-patient-vitals-fw-implementation

    • -114
    • +27
    /firmware/App/Services/FpgaTD.c
Is this the right time to zero this volume?

Is this the right time to zero this volume?