Dashboard

Merge branch 'staging' into develop

LDT-2030-added a function which enqueues emb mode broadcast

Merge branch 'staging' into LDT-2030-blood-leak-refactor---dd

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

LDT-2004-3 drybicart updates

LDT-2004-4 drybicart updates

    • -5
    • +15
    /firmware/App/Controllers/DryBiCart.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenDialysate.c
For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

Remove blank line.

Remove blank line.

LDT-2004 dry bicart test config updates

    • -2
    • +1
    /leahi_dialin/common/test_config_defs.py
When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

removed commented out line

removed commented out line

removed

LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

LDT-3222: Updated variable initialization for the function testBCValveStatesOverride

No longer needed since staging was changed.

No longer needed since staging was changed.

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

LDT-2004-3 dry bicart feature update

Yes

Yes

Updated.

Updated.

Updated.

Updated.

Based on the msg id, it should be here

Based on the msg id, it should be here

LDT-3197: Isolated UF - SW - 01 - R&I - 03: SDD - Design Diagram - plantuml

- Updated Isolated UF sequence diagram to fix MSG and specify which screen rejection reason is being displayed on.

    • binary
    /SDDs/TreatmentAdjustmentIsolatedUF.png
    • -5
    • +5
    /SDDs/TreatmentAdjustmentIsolatedUF.puml
It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

User waited too long would follow the same rejected behavior, do we still need to show the specific rejection path for the user waiting too long?

User waited too long would follow the same rejected behavior, do we still need to show the specific rejection path for the user waiting too long?