Dashboard

are we missing any value in (). If not remove the ( Same in line 298

are we missing any value in (). If not remove the (
Same in line 298

Please reserve the IDs in the shared excel and use the available IDs

Please reserve the IDs in the shared excel and use the available IDs

Add comment.

Add comment.

Set default publish interval to 1 sec.

Set default publish interval to 1 sec.

LDT-5186 dialin implementation for drybicart and mixing control

    • -2
    • +50
    /leahi_dialin/dd/modules/drybicart.py
    • -3
    • +104
    /leahi_dialin/dd/modules/mixing_cntrl.py
Merge branch 'staging' into develop

fixed td records import

LDT-5186 dry bicarb refactoring state machines

LDT-5186 dry bicarb refactoring state machines

    • -499
    • +413
    /firmware/App/Controllers/DryBiCart.c
Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

Can we remove this commented out line of code?

Can we remove this commented out line of code?

Why is this commented out?

Why is this commented out?

Why is state transition and publish removed?

Why is state transition and publish removed?

LEAHI-SW-PLUGINS-SIM-LDT-5152_[Dialin] Handler architecture refactor
LEAHI-SW-PLUGINS-SIM-LDT-5152_[Dialin] Handler architecture refactor
this was merged yesterday

this was merged yesterday

Use this instead: from leahi_dialin.common.msg_ids import MsgIds from leahi_dialin.common.constants import MSG_HEADER_SIZE

Use this instead:

from leahi_dialin.common.msg_ids import MsgIds
from leahi_dialin.common.constants import MSG_HEADER_SIZE

Create a readme file please beside the run.update.package.py suggested content: """ python3 run.update_package.py <path> <stack> <destination> path: location to the .bin file stack: 0 - TD 1 - D...

Create a readme file please beside the run.update.package.py

suggested content:
"""
python3 run.update_package.py <path> <stack> <destination>

path: location to the .bin file

stack:
0 - TD
1 - DD

destination:
0 - Firmware
1 - FPGA
"""

Use MSG_HEADER_SIZE instead

Use MSG_HEADER_SIZE instead

Use this instead: from leahi_dialin.common.msg_ids import MsgIds from leahi_dialin.common.constants import MSG_HEADER_SIZE

Use this instead:

from leahi_dialin.common.msg_ids import MsgIds
from leahi_dialin.common.constants import MSG_HEADER_SIZE

Please address the commented code.

Please address the commented code.

Should we remove the commented code?

Should we remove the commented code?

- Removal of MsgFieldPositions

    • -2
    • +3
    /TD_Advanced_Institutional_Records/loader.py
  1. … 16 more files in changeset.
We should manage the commented-out code.

We should manage the commented-out code.

break this line

break this line

break this line

break this line

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.