Dashboard

merged branch LDT-3963

Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

LDT-3978 addressed review comments

    • -2
    • +15
    /firmware/App/Controllers/DryBiCart.c
I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

LDT-4188 addressed review comments

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

Remove extra blank line.

Remove extra blank line.

Remove extra space before function name.

Remove extra space before function name.

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

Remove extra blank line.

Remove extra blank line.

As the fw haven't requested the gen dialysate it is expected to be in pre-gen mode

As the fw haven't requested the gen dialysate it is expected to be in pre-gen mode

LDT-3978-addressed review comments

    • -14
    • +24
    /firmware/App/Controllers/DryBiCart.c
Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-common into develop

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-fwcommon into develop

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

    • -0
    • +4
    /firmware/App/Drivers/BloodLeakDriver.c
remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

LDT-4188 rearranged variable declarations