Dashboard

LDT-2004: warning reductions for teensy driver

LEAHI-APPLICATION-LDT-3574_Misc SW Enhancements - SW - 01 - General Aesthetics - 02-S24 - R&I
LEAHI-APPLICATION-LDT-3574_Misc SW Enhancements - SW - 01 - General Aesthetics - 02-S24 - R&I
fixed in latest code

fixed in latest code

implemented

implemented

fixed

fixed

LDT-1903 Air Trap Addressed code review comments

    • -10
    • +1
    /firmware/App/Controllers/AirTrap.c
LDT-1903 Air Trap adding duty cycle out of range software fault alarm

added

added

added

added

LDT-3372: code review comments.

fixed.

fixed.

LDT-1903 removing ALARM_ID_TD_AIR_PUMP_DUTY_CYCLE_OUT_OF_RANGE

then we return false as expected

then we return false as expected

These are correct variable names based on their coefficient names in calculations of conductivity.

These are correct variable names based on their coefficient names in calculations of conductivity.

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

removed. thanks!

removed. thanks!

parameter check happens in getTeensyCondId

parameter check happens in getTeensyCondId

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

Not for this situation since its an array of structs and looks like a 2d array. Please see static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c static const DD_OP_MODE_T MODE_TRAN...

Not for this situation since its an array of structs and looks like a 2d array. Please see

static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c
static const DD_OP_MODE_T MODE_TRANSITION_TABLE in OperationModes.c
static PI_CONTROLLER_T piControllers in PIControllers.c ( FWCommon repo )

Bamboo Commit: Updated Branch develop For Project DD

    • binary
    /DD/BETA/DD_Debug_Beta_v0.0.0-70.out
    • binary
    /DD/BETA/DD_Debug_Beta_v0.0.0-71.out
    • binary
    /DD/BETA/DD_Release_Beta_v0.0.0-70.out
    • binary
    /DD/BETA/DD_Release_Beta_v0.0.0-71.out
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

LDT-3372: fixes to conductivity calculation.

LDT-1903 Air Trap adding duty cycle out of range alarm

LDT-3438 Water, Dialysate, and Blood Sampling - SW - 01 - Water sample & Dialysate Checks - R&I - 05: DEV - Feature Implementation

update msg id

LDT-1903 Adding Air pump duty cycle out of range alarm

LDT-3443 Water, Dialysate, and Blood Sampling - SW - 01 - Water sample & Dialysate Checks - R&I - 10: DVT - Simulator Implementation & Dev Test

update message id

LDT-3441 Water, Dialysate, and Blood Sampling - SW - 01 - Water sample & Dialysate Checks - R&I - 08: DEV - Dialin Implementation

update message id

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.