Dashboard

Welcome Message

Welcome to Atlassian Crucible with Fisheye .

To report a bug or suggest a feature please raise an issue in our public Jira.

Customize this welcome note.

Support

You are running Crucible 4.8.14 with Fisheye 4.8.14 (20240111091859 2024-01-11 09:20)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Friday 06 Mar
7:00 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:54 pm

Dara Navaei

Bamboo Commit: Updated Branch staging For Project TD

Options
    • -4
    • +4
    /TD/BETA/TD_BETA_Manifest.csv
    • binary
    /TD/BETA/TD_Debug_Beta_v0.0.0-29.out
    • binary
    /TD/BETA/TD_Debug_Beta_v0.0.0-30.out
    • binary
    /TD/BETA/TD_Release_Beta_v0.0.0-29.out
    • binary
    /TD/BETA/TD_Release_Beta_v0.0.0-30.out
3:26 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/TDCommon.h
3:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Services/SystemCommTD.c
    • -2
    • +2
    /firmware/App/TDCommon.h
    • -2
    • +2
    /firmware/App/Tasks/TaskBG.c
3:26 pm

Dara Navaei

3:24 pm

Dara Navaei

Merged LDT-3599

Options
2:53 pm

Nicholas Ramirez

removed and model now lives in c++

removed and model now lives in c++

2:52 pm

Nicholas Ramirez

model moved to c++

model moved to c++

2:52 pm

Nicholas Ramirez

updated and moved

updated and moved

2:50 pm

Nicholas Ramirez

LDT-3398 HDF - SW - 01 - Main-Tx HDF Tab - R&I - 05: DEV - Feature Implementation

address cr comments

Options
    • -0
    • +2
    /leahi.pro
    • -0
    • +1
    /sources/gui/GuiGlobals.cpp
    • -11
    • +3
    /sources/gui/qml/components/HeaderBar.qml
    • -0
    • +3
    /sources/gui/qml/main.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentHDF.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentHeparin.qml
    • -19
    • +19
    /sources/gui/qml/pages/treatment/sections/TreatmentHDFComponent.qml
    • -0
    • +31
    /sources/view/VListModel.cpp
    • -0
    • +59
    /sources/view/VListModel.h
    • -0
    • +1
    /sources/view/VView.h
2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:36 pm

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

2:29 pm

Sean Nash

2:29 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    /firmware/App/Monitors/Conductivity.c
2:27 pm

Sean Nash

Should this event be TD_EVENT_AIR_TRAP_FILL?

Should this event be TD_EVENT_AIR_TRAP_FILL?

2:25 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed.

fixed.

2:24 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/ConductivityTeensy.c
2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:22 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

2:22 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
2:21 pm

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)