Dashboard

LDT-1903 Air Trap feature updates

LDT-1903 Air Trap feature updates

    • -15
    • +3
    /firmware/App/Controllers/AirTrap.c
LDT-1903 addressed review comments

    • -48
    • +25
    /firmware/App/Controllers/AirTrap.c
LDT-3398 HDF - SW - 01 - Main-Tx HDF Tab - R&I - 05: DEV - Feature Implementation

address CR comments

    • -13
    • +22
    /sources/gui/qml/components/HeaderBar.qml
    • -16
    • +4
    /sources/gui/qml/components/MainMenu.qml
We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

Add blank line after declarations.

Add blank line after declarations.

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Add blank line after declarations.

Add blank line after declarations.

I think alarm should be handled inside the setAirPumpState() function.

I think alarm should be handled inside the setAirPumpState() function.

Should we have alarm here?

Should we have alarm here?

duty misspelled.

duty misspelled.

Can we remove inclusion of fpga here? It shouldn't be needed.

Can we remove inclusion of fpga here? It shouldn't be needed.

LDT-1903 Air Trap Feature updates

    • -1
    • +20
    /firmware/App/Controllers/AirTrap.c
Added

Added

Updated

Updated

Removed and replaced

Removed and replaced

Added

Added

Updated

Updated

Updated

Updated

Updated

Updated

Assigned new variable

Assigned new variable

Removed

Removed

Removed

Removed

Added

Added