Dashboard

Welcome Message

Welcome to Atlassian Crucible with Fisheye .

To report a bug or suggest a feature please raise an issue in our public Jira.

Customize this welcome note.

Support

You are running Crucible 4.8.14 with Fisheye 4.8.14 (20240111091859 2024-01-11 09:20)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
1 min ago

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

2 mins ago

Sean Nash

Why commented out?

Why commented out?

9 mins ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
24 mins ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
39 mins ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
54 mins ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
1 hr ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
1 hr ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
1 hr ago

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

1 hr ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
1 hr ago

Sean Nash

Why?

Why?

1 hr ago

Dara Navaei

LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
LEAHI-DRYDEMO-LDT-5303_SW Misc & Enhc - SW - 01 - Dry-Demo - HDF - R&I
1 hr ago

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

1 hr ago

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

2 hrs ago

suresh

LDT:4049- addressed review comments

Options
    • -0
    • +1
    /MessagePayloads.h
2 hrs ago

suresh

LDT:4049- addressed review comments

Options
    • -12
    • +0
    /AlarmDefs.h
    • -2
    • +0
    /DDDefs.h
    • -6
    • +1
    /MsgDefs.h
2 hrs ago

suresh

LDT:4049- addressed review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/RotaryValve.h
    • -5
    • +7
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.h
    • -11
    • +13
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +3
    /firmware/App/Services/DDInterface.c
    • -1
    • +1
    /firmware/App/Services/DDInterface.h
    • -8
    • +0
    /firmware/App/Services/Messaging.h
3 hrs ago

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

3 hrs ago

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

3 hrs ago

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

3 hrs ago

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

3 hrs ago

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

3 hrs ago

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

3 hrs ago

Sean Nash

Align comment.

Align comment.

3 hrs ago

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

3 hrs ago

Nicholas Ramirez

LDT-5248 System Interface for Users - SW - 01 - Bicarb/Acid Low Replacement - R&I - 02: SDD - Design Diagram - plantuml & Review

sdd

Options
    • binary
    /SDDs/LowBicardWorkflow.png
    • -0
    • +81
    /SDDs/lowBicarb.puml
Tuesday 21 Jul
10:23 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

New message ID decleartion for air pump override

Options
    • -0
    • +1
    /MsgDefs.h
10:13 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Messaging ID configuration

Options
    • -0
    • +1
    /firmware/App/Controllers/AirPump.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
9:15 pm

suresh

LDT:4072-addressed review comments

Options
    • -4
    • +8
    /firmware/App/Drivers/BatteryDriver.c
    • -2
    • +2
    /firmware/App/Drivers/BatteryDriver.h
    • -10
    • +17
    /firmware/App/Monitors/Battery.c
8:48 pm

suresh

LDT:4049 Addressed review comments

Options
    • -317
    • +11
    /firmware/App/Modes/ModeStandby.c