Dashboard

Welcome Message

Welcome to Atlassian Crucible with Fisheye .

To report a bug or suggest a feature please raise an issue in our public Jira.

Customize this welcome note.

Support

You are running Crucible 4.8.14 with Fisheye 4.8.14 (20240111091859 2024-01-11 09:20)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
16 mins ago

Vendor - TEL - Varshini Nagabooshanam

Added comments

Options
    • -7
    • +60
    /AlarmDefs.h
    • -3
    • +15
    /MsgDefs.h
    • -22
    • +25
    /TDDefs.h
26 mins ago

Zoltan Miskolci

Removed Denali reference

Options
    • -2
    • +2
    /CHANGELOG.md
    • -1
    • +1
    /README.md
    • -3
    • +3
    /leahi_dialin/common/msg_defs.py
    • -9
    • +9
    /leahi_dialin/common/override_templates.py
    • -12
    • +12
    /leahi_dialin/dd/dialysate_delivery.py
    • -10
    • +10
    /leahi_dialin/dd/modules/alarms.py
    • -9
    • +9
    /leahi_dialin/dd/modules/balancing_chamber.py
    • -12
    • +12
    /leahi_dialin/dd/modules/blood_leak.py
    • -11
    • +11
    /leahi_dialin/dd/modules/concentrate_pump.py
    • -11
    • +11
    /leahi_dialin/dd/modules/conductivity_sensors.py
    • -7
    • +7
    /leahi_dialin/dd/modules/dd_test_configs.py
    • -11
    • +11
    /leahi_dialin/dd/modules/dialysate_pump.py
    • -10
    • +10
    /leahi_dialin/dd/modules/drybicart.py
    • -5
    • +5
    /leahi_dialin/dd/modules/events.py
    • -10
    • +10
    /leahi_dialin/dd/modules/gen_dialysate.py
  16. … 61 more files in changeset.
30 mins ago

Sean Nash

Do we not need the module error alarm?

Do we not need the module error alarm?

31 mins ago

Sean Nash

This is not an atomic assignment, so we have to consider thread safety. If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec w...

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

34 mins ago

Sean Nash and Vendor - TEL - Jashwant Gantyada

35 mins ago

Vendor - TEL - Varshini Nagabooshanam

LDT-3215-measured-venous-pressure-decreases

Options
    • -44
    • +184
    /AlarmDefs.h
35 mins ago

Vendor - TEL - Varshini Nagabooshanam

LDT-3215-measured-venous-pressure-decreases

Options
    • -10
    • +39
    /firmware/App/Controllers/AirPump.c
    • -4
    • +8
    /firmware/App/Controllers/AirPump.h
    • -6
    • +14
    /firmware/App/Drivers/GLXferPump.h
    • -3
    • +28
    /firmware/App/Services/FpgaTD.c
    • -2
    • +4
    /firmware/App/Services/FpgaTD.h
36 mins ago

Dara Navaei

LEAHI-COMMON-LDT-2004_Dialysate Composition - DD
LEAHI-COMMON-LDT-2004_Dialysate Composition - DD
36 mins ago

Dara Navaei

LEAHI-COMMON-LDT-2004_Dialysate Composition - DD
LEAHI-COMMON-LDT-2004_Dialysate Composition - DD
36 mins ago

Dara Navaei

LEAHI-FWCOMMON-LDT-2004_Dialysate Composition - DD
LEAHI-FWCOMMON-LDT-2004_Dialysate Composition - DD
36 mins ago

Dara Navaei

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
37 mins ago

Sean Nash

same.

same.

37 mins ago

Sean Nash

same.

same.

37 mins ago

Sean Nash

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

38 mins ago

Sean Nash

How do we get out of Idle state?

How do we get out of Idle state?

39 mins ago

Sean Nash

This should be called in all states (so in controller's exec function).

This should be called in all states (so in controller's exec function).

40 mins ago

Sean Nash

I don't think we want to zero this count here.

I don't think we want to zero this count here.

41 mins ago

Sean Nash

We need to call the driver exec function from this exec function - either before or after the switch statement.

We need to call the driver exec function from this exec function - either before or after the switch statement.

42 mins ago

Vendor - TEL - Praneeth Bunne

LDT-1886: Update event related code

Options
    • -10
    • +11
    /firmware/App/Services/StateServices/TubeSetAutoEject.c
    • -10
    • +11
    /firmware/App/Services/StateServices/TubeSetInstall.c
48 mins ago

Vendor - TEL - Sameer Poyil

48 mins ago

Sean Nash

We need to call this from ModeTreatment transition function.

We need to call this from ModeTreatment transition function.

48 mins ago

Sean Nash

We need to call this function from ModeTreatment exec function.

We need to call this function from ModeTreatment exec function.

50 mins ago

Sean Nash

Remove blank line.

Remove blank line.

58 mins ago

Nicholas Ramirez

LDT-4456 Edit Treatment Parameters During Treatment - SW - 01 - Integration - R&I - 05: DEV - Feature Implementation

update venous window ranges

Options
    • -3
    • +3
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
58 mins ago

Sean Nash

s/w fault needs alarm data. See other examples.

s/w fault needs alarm data. See other examples.

1 hr ago

Sean Nash

Why do you have { here?

Why do you have { here?

1 hr ago

Sean Nash

For init function, just say "BPModule variables initialized."

For init function, just say "BPModule variables initialized."

1 hr ago

Sean Nash

The driver has one of these too. Does the controller need to store the results when it can ask the driver for them?

The driver has one of these too. Does the controller need to store the results when it can ask the driver for them?

1 hr ago

Sean Nash

I'm not sure we need these "Detected" functions. I would expect that when this controller gets new readings, it will check for these alarm conditions in the check state and trigger alarm if appropr...

I'm not sure we need these "Detected" functions. I would expect that when this controller gets new readings, it will check for these alarm conditions in the check state and trigger alarm if appropriate. So if we are triggering alarms in this controller, there is no need for outside code to ask if these alarms are detected.

1 hr ago

Sean Nash

I think these will eventually be coming from institutional settings, so maybe put a TODO comment to remove these when institutional settings are available.

I think these will eventually be coming from institutional settings, so maybe put a TODO comment to remove these when institutional settings are available.