Dashboard

Welcome Message

Welcome to Atlassian Crucible with Fisheye .

To report a bug or suggest a feature please raise an issue in our public Jira.

Customize this welcome note.

Support

You are running Crucible 4.8.14 with Fisheye 4.8.14 (20240111091859 2024-01-11 09:20)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
3 mins ago

Dara Navaei

LDT-3239 updated the script to prevent a traceback if the user interrupted the update process

Options
    • -14
    • +22
    /scripts/update_package_script/update_package.py
9 mins ago

Sean Nash

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

16 mins ago

Sean Nash

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

19 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

22 mins ago

Dara Navaei

LDT-3272 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Services/Messaging.c
    • -16
    • +0
    /firmware/App/Services/SystemCommDD.h
    • -16
    • +16
    /firmware/DD.dil
    • -10
    • +10
    /firmware/source/can.c
24 mins ago

Sean Nash

Where is call to HDF controller?

Where is call to HDF controller?

24 mins ago

Sean Nash

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

25 mins ago

Sean Nash

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

26 mins ago

Sean Nash

What about initHDF?

What about initHDF?

26 mins ago

Sean Nash

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

31 mins ago

Sean Nash

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?

40 mins ago

Vendor - TEL - Varshini Nagabooshanam

LDT-4033-patient-vitals-fw-implementation

Options
    • -0
    • +97
    /firmware/App/Controllers/BPModule.c
    • -0
    • +1
    /firmware/App/Controllers/BPModule.h
    • -0
    • +2
    /firmware/App/Services/Messaging.c
41 mins ago

Sean Nash

This macro is already defined in Common.h.

This macro is already defined in Common.h.

41 mins ago

Sean Nash

Align all "=" or none of them.

Align all "=" or none of them.

42 mins ago

Sean Nash

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

44 mins ago

Sean Nash

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given b...

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given by TD f/w.
HDF volume should be calculated by TD f/w by integrating commanded Qsub over time.

47 mins ago

Sean Nash

Remove blank line.

Remove blank line.

47 mins ago

Sean Nash

Refactor so that only one return statement at end of function. This is in our coding standards.

Refactor so that only one return statement at end of function. This is in our coding standards.

47 mins ago

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

48 mins ago

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

48 mins ago

Sean Nash

I think TD should be handling all of these rules before setting Qsub and sending to DD.

I think TD should be handling all of these rules before setting Qsub and sending to DD.

49 mins ago

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

49 mins ago

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

50 mins ago

Dara Navaei

Done

Done

50 mins ago

Dara Navaei

Done

Done

1 hr ago

Sean Nash

Generally, DD shouldn't need TMP. TD is calculating TMP. TD is using TMP to calculate Qsub. DD is just getting Qsub from TD and controlling the pump to that rate.

Generally, DD shouldn't need TMP. TD is calculating TMP. TD is using TMP to calculate Qsub. DD is just getting Qsub from TD and controlling the pump to that rate.

1 hr ago

Sean Nash

Indent declarations.

Indent declarations.

1 hr ago

Sean Nash

How can we help you with this?

How can we help you with this?

1 hr ago

Dara Navaei

LDT-3259 addressed the code review comments

Options
    • -2
    • +2
    /CommBuffers.h
1 hr ago

Sean Nash

Doesn't match file name. Why do we have a redundant file name with ~ suffix for your new units? If these are backup files from your editor, please do not add these to the git repo (delete them befo...

Doesn't match file name. Why do we have a redundant file name with ~ suffix for your new units? If these are backup files from your editor, please do not add these to the git repo (delete them before commit).