Dashboard

Welcome Message

Welcome to Atlassian Crucible with Fisheye .

To report a bug or suggest a feature please raise an issue in our public Jira.

Customize this welcome note.

Support

You are running Crucible 4.8.14 with Fisheye 4.8.14 (20240111091859 2024-01-11 09:20)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
31 mins ago

Michael Garthwaite

32 mins ago

Michael Garthwaite

tip: use the logger and set the statement to error level and you can see it in runtime

tip: use the logger and set the statement to error level and you can see it in runtime

42 mins ago

Sean Nash

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

43 mins ago

Sean Nash

Fix alignment of "=".

Fix alignment of "=".

44 mins ago

Sean Nash

Add a param line in this header.

Add a param line in this header.

45 mins ago

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

45 mins ago

Sean Nash

Add a params line in function header.

Add a params line in function header.

46 mins ago

Sean Nash

Why did we change this spelling? Now it's wrong.

Why did we change this spelling? Now it's wrong.

47 mins ago

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

48 mins ago

Sean Nash

Keep this blank line.

Keep this blank line.

50 mins ago

Sean Nash

Should be before ModeStandby.

Should be before ModeStandby.

51 mins ago

Sean Nash

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

54 mins ago

Sean Nash

Remove blank line.

Remove blank line.

54 mins ago

Sean Nash

Remove blank line.

Remove blank line.

55 mins ago

Sean Nash

Should assign a local variable to this equation and then return the variable. Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int. Al...

Should assign a local variable to this equation and then return the variable.
Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int.
Also, do we want to do any rounding when converting float to integer?

59 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

1 hr ago

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
1 hr ago

Zoltan Miskolci

Merge branch 'LDT-3600-new_td_testconfig' into develop

Options
1 hr ago

Zoltan Miskolci

Merge branch 'LDT-3629-fp_dd_valve_states_enum_fix' into develop

Options
    • -1
    • +1
    /leahi_dialin/fp/modules/ro_pump.py
    • -1
    • +1
    /leahi_dialin/fp/modules/temperatures.py
    • -8
    • +8
    /leahi_dialin/fp/modules/valves.py
1 hr ago

Raghu Kallala

pressure limit will be unsigned int not signed int with LDT-473..beta CR Add a TODO to update once the 473 is ready to merge

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

1 hr ago

Raghu Kallala

Are these print statements add for debugging? If not, is this allowed

Are these print statements add for debugging?
If not, is this allowed

1 hr ago

Raghu Kallala

typo, PUMP_ON_STATE

typo, PUMP_ON_STATE

1 hr ago

Raghu Kallala

1 hr ago

Vendor - TEL - Jashwant Gantyada

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

2 hrs ago

Raghu Kallala

LDT-3603 addressed review comments and added missing code

Options
    • -0
    • +62
    /firmware/App/Modes/FPModes/FPModeFault.c
    • -1
    • +4
    /firmware/App/Modes/FPModes/FPModeFault.h
    • -0
    • +52
    /firmware/App/Modes/FPModes/FPModeStandby.c
    • -1
    • +2
    /firmware/App/Modes/FPModes/FPModeStandby.h
    • -88
    • +103
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -48
    • +55
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -2
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeate.h
    • -50
    • +55
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
    • -3
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h
    • -61
    • +67
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -3
    • +3
    /firmware/App/Modes/FPModes/ModePreGenPermeate.h
    • -51
    • +57
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -2
    • +2
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h
2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

4 hrs ago

Raghu Kallala

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

4 hrs ago

Raghu Kallala

Updated

Updated

4 hrs ago

Raghu Kallala

Updated

Updated

4 hrs ago

Raghu Kallala

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit