LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

Activity

LEAHI-DD-FIRMWARE-LDT-2004-9 72

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 45h 31m 15 Its static function and not used by external API to pass ...
    Reviewer - Complete 1h 37m 43 So I think this compiler will give you 64 bit if you ask ...
    Reviewer - 5% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 2h 8m 14 Same comment applies here (removing resetPIController).
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   49h 17m 72  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.../Controllers/BalancingChamber.c Changed 5
    Open in IDE #permalink
    /firmware/.../Controllers/ConcentratePumps.h Changed 2
    Open in IDE #permalink
    /firmware/App/Controllers/DryBiCart.c Changed 46
    Open in IDE #permalink
    /firmware/App/Controllers/DryBiCart.h Changed 4
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.c Changed 2
    Open in IDE #permalink
    /firmware/App/Monitors/Level.c Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /MsgDefs.h Changed 2
    Open in IDE #permalink
    /Common.h Changed 6
    Open in IDE #permalink
    /PIControllers.c Changed 4
    Open in IDE #permalink
    /PIControllers.h Changed 1
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time