Vendor - TEL - Sameer Poyil

About
  • First commit 20 November 2025
  • Latest commit 11 December 2025
Last Week All Time
Commits: 3 23

Reviews

14 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Vendor - TEL - Sameer Poyil is mapped to 4 committers over 3 repositories
Username ven.spoyil is mapped to:
Thursday 11 Dec
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

6:55 am

Vendor - TEL - Sameer Poyil

LDT-2185 Alpha Refinement Updates, inlet pressurecheck for all varaints, RO duticycle monitoring

Options
    • -19
    • +48
    /firmware/App/Modes/FPModes/InletPressureCheck.c
    • -10
    • +3
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -15
    • +39
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -3
    • +35
    /firmware/App/Monitors/WaterQualityMonitor.c
Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

Tuesday 09 Dec
11:20 am

Vendor - TEL - Sameer Poyil

11:12 am

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Monday 08 Dec
7:02 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

7:00 pm

Vendor - TEL - Sameer Poyil

Let public function on top

Let public function on top

6:53 pm

Vendor - TEL - Sameer Poyil

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

6:52 pm

Vendor - TEL - Sameer Poyil

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

6:50 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

6:46 pm

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

8:58 am

Vendor - TEL - Sameer Poyil

LDT-2936 iofp update for verify permeate conductivity timeout LDT-1236

Options
    • -9
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
8:43 am

Vendor - TEL - Sameer Poyil

LDT-2936-iofp RO permeate flush timeout LDT-1755

Options
    • -4
    • +4
    /firmware/App/Modes/FPModes/FlushPermeate.c
Friday 05 Dec
8:52 am

Vendor - TEL - Sameer Poyil

structure packing missing

structure packing missing

8:48 am

Vendor - TEL - Sameer Poyil

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Thursday 04 Dec
3:26 pm

Vendor - TEL - Sameer Poyil

LDT-2936- iofp update changing variable name from flowRateSeventyFivePercent to adjustedFlowRRate

Options
    • -5
    • +5
    /firmware/App/Controllers/ROPump.c
3:05 pm

Vendor - TEL - Sameer Poyil

LDT:2936 changing the variable name from targtetFlowRate to flowRateSeventyFivePercent LDT-1925

Options
    • -5
    • +5
    /firmware/App/Controllers/ROPump.c
2:43 pm

Vendor - TEL - Sameer Poyil

LDT-2936: Add timeout for if flow rate doesn’t reach 75% of target permeate flow rate within 10 seconds

Options
    • -2
    • +18
    /firmware/App/Controllers/ROPump.c
2:33 pm

Vendor - TEL - Sameer Poyil

LDT:2936-iofp flow rate doesn't reach 75% of target flow LDT-1925

Options
    • -4
    • +4
    /AlarmDefs.h
12:07 pm

Vendor - TEL - Sameer Poyil

Merge branch 'LDT-2936-iofp---update-m12-and-boost-pum' of bitbucket.org:diality-cloud/dd-firmware into LDT-2936-iofp---update-m12-and-boost-pum

Options
    • -2
    • +0
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
12:06 pm

Vendor - TEL - Sameer Poyil

LDT-2936-iofp implementation for LDT-1240 and LDT-2135

Options
    • -0
    • +1
    /firmware/App/Modes/FPModes/FlushFilter.c
    • -0
    • +4
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -0
    • +3
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
Wednesday 03 Dec
5:58 pm

Vendor - TEL - Sameer Poyil

Small letter used

Small letter used

3:00 pm

Vendor - TEL - Sameer Poyil

LDT:2936: moving permeate low flow alarm timeout

Options
    • -0
    • +1
    /firmware/App/Monitors/WaterQualityMonitor.c
2:56 pm

Vendor - TEL - Sameer Poyil

LDT-2936: moving permeate low flow alarm initialization initialization

Options
    • -3
    • +0
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -0
    • +2
    /firmware/App/Monitors/WaterQualityMonitor.c
2:03 pm

Vendor - TEL - Sameer Poyil

LDT-2936: removing typo

Options
    • -1
    • +1
    /firmware/App/Monitors/WaterQualityMonitor.c
2:00 pm

Vendor - TEL - Sameer Poyil

LDT2936: moving the checkPermeateLowFlow to WaterQualityMonitor

Options
    • -22
    • +3
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -1
    • +22
    /firmware/App/Monitors/WaterQualityMonitor.c
    • -1
    • +3
    /firmware/App/Monitors/WaterQualityMonitor.h