Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

let public function on top

let public function on top

Let all public functions come on top for all files

Let all public functions come on top for all files

LDT-2185 Alpha Refinement Updates, inlet pressurecheck for all varaints, RO duticycle monitoring

is it merge issue ?

is it merge issue ?

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

comments should start with capital letter

comments should start with capital letter

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

Let public function on top

Let public function on top

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

Mixing static and public function , let public function comes on top

Mixing static and public function , let public function comes on top

comment should start with capital letter

comment should start with capital letter

comments should start with capital letter

comments should start with capital letter

LDT-2936 iofp update for verify permeate conductivity timeout LDT-1236

LDT-2936-iofp RO permeate flush timeout LDT-1755

structure packing missing

structure packing missing

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

LDT-2936- iofp update changing variable name from flowRateSeventyFivePercent to adjustedFlowRRate

LDT:2936 changing the variable name from targtetFlowRate to flowRateSeventyFivePercent LDT-1925

LDT-2936: Add timeout for if flow rate doesn’t reach 75% of target permeate flow rate within 10 seconds

LDT:2936-iofp flow rate doesn't reach 75% of target flow LDT-1925

Merge branch 'LDT-2936-iofp---update-m12-and-boost-pum' of bitbucket.org:diality-cloud/dd-firmware into LDT-2936-iofp---update-m12-and-boost-pum

    • -2
    • +0
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
LDT-2936-iofp implementation for LDT-1240 and LDT-2135

    • -0
    • +1
    /firmware/App/Modes/FPModes/FlushFilter.c
    • -0
    • +4
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
Small letter used

Small letter used

LDT:2936: moving permeate low flow alarm timeout

LDT-2936: moving permeate low flow alarm initialization initialization

    • -3
    • +0
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
LDT-2936: removing typo

LDT2936: moving the checkPermeateLowFlow to WaterQualityMonitor

    • -22
    • +3
    /firmware/App/Modes/FPModes/ModeGenPermeate.c