LEAHI-RO-FIRMWARE-LDT-2116_IOFP - Evaluate closing P39 during tank full state

Activity

LEAHI-RO-FIRMWARE-LDT-2116-1 59

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 45m 10 This is for alpha
    Reviewer - 0% reviewed 42m    
    jpaguio  (deleted user)
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 2h 19m 15 Once Dara enable the copyright script, that will handle it
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 9m    
    Reviewer - 100% reviewed 51m 26 Is this code for alpha or beta? getCurrentOperationMode()...
    Reviewer - 100% reviewed 1h 38m 8 comments should start with capital letter
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   6h 26m 59  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/PermeateTank.c Changed 6
    Open in IDE #permalink
    /firmware/App/Controllers/ROPump.c Changed 8
    Open in IDE #permalink
    /firmware/App/Drivers/FluidPump.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/FPModeStandby.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/FlushConcentrate.c Changed 11
    Open in IDE #permalink
    /firmware/App/Modes/FlushFilter.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/FlushPermeate.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenPermeate.c Changed 15
    Open in IDE #permalink
    /firmware/App/Modes/ModePreGenPermeate.c Changed 2
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.c Changed 8
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.h Changed 3
    Open in IDE #permalink
    /firmware/.../Monitors/WaterQualityMonitor.c Changed
    Open in IDE #permalink
    /firmware/.../Monitors/WaterQualityMonitor.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 6
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time