leahi-common

Clone Tools

Stats

Commits this week: 33
Total Committers: 19
Last Commit: 12 Aug
Commits this week: 33

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Aug
3:59 pm

Sean Nash

Are we done testing? Can we remote test variables and code?

Are we done testing? Can we remote test variables and code?

3:29 pm

Vinayakam Mani

Remove Sequence step states if not being used.

Remove Sequence step states if not being used.

3:27 pm

Vinayakam Mani

Update comments ( remove start/end states)

Update comments ( remove start/end states)

3:26 pm

Vinayakam Mani

Update TD to DD.

Update TD to DD.

3:26 pm

Vinayakam Mani

Update alarm properties (DD fault, Priority eti,.)

Update alarm properties (DD fault, Priority eti,.)

3:23 pm

Vinayakam Mani

Remove the empty line.

Remove the empty line.

3:20 pm

Vinayakam Mani

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

3:15 pm

Vendor - TEL - Vijay Pamula

Merge branch 'staging' into LDT-4029-pre-treatment---fw-implementation

Options
    • -41
    • +41
    /AlarmDefs.h
3:14 pm

Vinayakam Mani

Remove commented code.

Remove commented code.

3:14 pm

Vinayakam Mani

Remove D34 valve close.

Remove D34 valve close.

3:13 pm

Vinayakam Mani

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

3:11 pm

Vinayakam Mani

void inside paranthesis.

void inside paranthesis.

3:01 pm

Vinayakam Mani

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that ...

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.

3:00 pm

suresh

added alarm ID

Options
    • -4
    • +4
    /AlarmDefs.h
2:25 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Updated alarm property

Options
    • -1
    • +1
    /AlarmDefs.h
2:19 pm

Vinayakam Mani

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

2:15 pm

Vinayakam Mani

Open D80, not D85.

Open D80, not D85.

2:11 pm

Vinayakam Mani

Remove the commented code.

Remove the commented code.

2:06 pm

Vinayakam Mani

Update description across the file.

Update description across the file.

1:59 pm

Vinayakam Mani

Update description.

Update description.

1:57 pm

Vinayakam Mani

update the description.

update the description.

1:46 pm

Vinayakam Mani

You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

1:35 pm

Vinayakam Mani

Add TODO comment that it should be removed later.

Add TODO comment that it should be removed later.

11:25 am

Vinayakam Mani

Add comment.

Add comment.

11:20 am

Vinayakam Mani

Set default publish interval to 1 sec.

Set default publish interval to 1 sec.

10:51 am

Vendor - TEL - Sameer Poyil

LDT-5186 dry bicarb refactoring state machines

Options
    • -4
    • +4
    /AlarmDefs.h
    • -33
    • +37
    /DDDefs.h
    • -0
    • +2
    /MsgDefs.h
10:26 am

Sean Nash

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

10:25 am

Sean Nash

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

10:21 am

Sean Nash

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

10:11 am

Sean Nash

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.