LEAHI-TD-FIRMWARE-LDT-2240-1 LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD

open for 4 months

Author

Moderator

Reviewers

LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 20

leahi-common 0
- File AlarmDefs.h 4 Remove
- File MsgDefs.h 6 Remove
- File TDDefs.h 3 Remove
leahi-fwcommon 0
- File PIControllers.c 2 Remove
- File TestSupport.h 0 Remove
td-firmware 0
- Folder firmware/App 0
  - Folder Modes 0
    - File ModePreTreat.c 13 Remove
    - File ModePreTreat.h 1 Remove
    - File StatePreTxDrySelfTests.c 24 Remove
    - File StatePreTxDrySelfTests.h 1 Remove
  - Folder Services 0
    - Folder StateServices 0
      - File DrySelfTests.c 7 Remove
      - File DrySelfTests.h 0 Remove
    - File AlarmMgmtSWFaults.h 0 Remove
    - File DDInterface.c 0 Remove
    - File DrySelfTests.c 40 Remove
    - File DrySelfTests.h 2 Remove
    - File FpgaTD.c 1 Remove
    - File Messaging.c 6 Remove
    - File TxDrySelfTests.c 5 Remove
    - File TxDrySelfTests.h 1 Remove
  - File TDCommon.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Vendor - TEL - Varshini Nagabooshanam	Author & Moderator	14h 15m	28	I missed updating this earlier, I’ll push the updated code.
Dara Navaei	Reviewer - 0% reviewed
Sean Nash	Reviewer - 100% reviewed	6h 28m	83	I would keep blank line between library includes and regu...
Nicholas Ramirez	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 83% reviewed	36m	5	Bubble status, Low and high level level sensors.
Raghu Kallala	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Zoltan Miskolci	Reviewer - 36% reviewed	38m
Vendor - TEL - Arpita Srivastava	Reviewer - 0% reviewed	5m
Total		22h 4m	116

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/.../Modes/StatePreTxDrySelfTests.c Deleted 24 (0)

Click to load diff

/firmware/.../Modes/StatePreTxDrySelfTests.h Deleted 1 (0)

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-TD-FIRMWARE-LDT-2240-1

LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD

LEAHI-TD-FIRMWARE-LDT-2240-1 116

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD

LEAHI-TD-FIRMWARE-LDT-2240-1 116

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time