LEAHI-DD-FIRMWARE-LDT-2030_Blood Leak - DD

Activity

LEAHI-DD-FIRMWARE-LDT-2030-2 114

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 6h 9m 45 done
    Reviewer - 6% reviewed 1h 4m 7 It is defined in line 937.
    Reviewer - 0% reviewed      
    Reviewer - 6% reviewed 32m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 1h 43m 37 Can these be done without loop (just fix the size to cove...
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 1h 36m 10 Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?
    Reviewer - 0% reviewed 6m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 3h 35m 15 implement it in a single structure packing by moving all ...
    Total   14h 49m 114  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Drivers/BloodLeakDriver.c Added 41
    Open in IDE #permalink
    /firmware/App/Drivers/BloodLeakDriver.h Added 9
    Open in IDE #permalink
    /firmware/App/Monitors/BloodLeak.c Changed 56
    Open in IDE #permalink
    /firmware/App/Monitors/BloodLeak.h Changed 6
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 2

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time