Clone
 

“raghu <“rkallala@diality.com”> in ro-firmware

LDT-1809 merge into staging

LDT-1809 Resolved conflicts while merging staging

    • -16
    • +35
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
LDT-1809 latest from staging

    • -1
    • +8
    /firmware/App/Modes/ModePreGenPermeate.c
LDT-1928 merge into staging

LDT-1928 latest from staging

Updated ToDo check for inletpressurecheck init call

    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Fixed indentation and review comments

    • -18
    • +18
    /firmware/App/Controllers/ROPump.c
Addressed review comment to remove flag assignment in paused state.

    • -1
    • +0
    /firmware/App/Modes/InletPressureCheck.c
fixed review comments

    • -30
    • +53
    /firmware/App/Controllers/ROPump.c
Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

    • -100
    • +62
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
removed commented code per review comments

Addressed review comments.

    • -7
    • +7
    /firmware/App/Modes/InletPressureCheck.c
    • -4
    • +5
    /firmware/App/Modes/InletPressureCheck.h
    • -0
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Addressed review comments to remove unwanted code lines and handled state assignment.

    • -4
    • +1
    /firmware/App/Modes/InletPressureCheck.c
    • -1
    • +0
    /firmware/App/Modes/InletPressureCheck.h
    • -0
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
declared result at the top of the scope for test functions

Removed commented code lines

Addressed review comments and modified the override behavior as discussed.

    • -174
    • +161
    /firmware/App/Controllers/ROPump.c
Implemented Inlet Pressure check functionality with Boost Pump

    • -0
    • +371
    /firmware/App/Modes/InletPressureCheck.c
    • -0
    • +53
    /firmware/App/Modes/InletPressureCheck.h
    • -1
    • +6
    /firmware/App/Modes/ModePreGenPermeate.c
Addressed review comments to remove blank lines

Fix for RO Pump override set and reset.

    • -75
    • +239
    /firmware/App/Controllers/ROPump.c
Modified handlers to change state based on data value rather than using get functions.

    • -11
    • +11
    /firmware/App/Controllers/ROPump.c
Fixed the override reset behavior in test function

Changes for RO pump override reset.

    • -31
    • +10
    /firmware/App/Controllers/ROPump.c
Updated code for multiple override.

    • -61
    • +153
    /firmware/App/Controllers/ROPump.c
WIP for setting multiple overrides

removed check for zero flow rate

Added backup variable for pump data and fixed set function behavior

    • -74
    • +154
    /firmware/App/Controllers/ROPump.c