RO-LDT-1928_Inlet Pressure Check ST

Activity

RO-LDT-1928-3 24

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 32m 11 Calling it regardless of hardware
    Reviewer - Complete 25m 8 Follow up with Eliza on TODO question.
    Reviewer - Complete 20m 5 Current builds of the FP are not triggering alarms. Alarm...
    Reviewer - 0% reviewed 3m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Total   1h 22m 24  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Modes/InletPressureCheck.c Added 14
    Open in IDE #permalink
    /firmware/App/Modes/InletPressureCheck.h Added 6
    Open in IDE #permalink
    /firmware/App/Modes/ModePreGenPermeate.c Changed 4
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /firmware/source/sys_main.c Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time