leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

Done.

Done.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Why comment this out? fault ID should probably be more specific (i.e. which message payload length is invalid?)

Why comment this out? fault ID should probably be more specific (i.e. which message payload length is invalid?)

Why isn't this TRUE == ?

Why isn't this TRUE == ?

LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Fix comment.

Fix comment.

Done

Done

Done

Done

This file was updated automatically using HALCoGen.

This file was updated automatically using HALCoGen.

Missing other test functions in the substitution pump (publish, target speed.)?

Missing other test functions in the substitution pump (publish, target speed.)?

update original author name and date.

update original author name and date.

update all test functions header and descriptions, Input, outputs and param sections.

update all test functions header and descriptions, Input, outputs and param sections.

Are we missing the publish function for the substitution pump?

Are we missing the publish function for the substitution pump?

are we checking any range here? if not, remove the above comment.

are we checking any range here? if not, remove the above comment.

Substitution pump. replace across the file.

Substitution pump. replace across the file.

Remove blank line

Remove blank line

Ramp to target speed state is missing?

Ramp to target speed state is missing?

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

Done

Done

Done

Done