LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD

Activity

LEAHI-TD-FIRMWARE-LDT-3126-1 121

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 12h 50m 59 Added
    Reviewer - 48% reviewed 3h 20m 62 Add a blank line after declarations.
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 42% reviewed 8m    
    Reviewer - 48% reviewed 11m    
    Reviewer - 0% reviewed      
    Total   16h 31m 121  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /MsgDefs.h Changed 2
    /TDDefs.h Changed
    /TestSupport.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Valves.h Changed 4
    Open in IDE #permalink
    /firmware/App/Modes/BloodPrime.c Deleted 8
    Open in IDE #permalink
    /firmware/App/Modes/BloodPrime.h Deleted
    Open in IDE #permalink
    /firmware/App/Modes/ModeTreatment.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeTreatment.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/StateTxBloodPrime.c Changed 94
    Open in IDE #permalink
    /firmware/App/Modes/StateTxBloodPrime.h Changed 8
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 5
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time