LEAHI-TD-FIRMWARE-LDT-3126

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- add duplicate function for 2010

    • -0
    • +35
    /sources/device/DeviceController.cpp
DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

Address CR comments

    • -1
    • +9
    /sources/cloudsync/CloudSyncController.h
DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- Add new error message for cloudsync for log duplicates

- Add more parameters to 2010 signal

- add Switch case logic for 2010 reject reason. Logic to be implemented and discussed

    • -1351
    • +1369
    /sources/cloudsync/CloudSyncController.cpp
    • -331
    • +333
    /sources/cloudsync/CloudSyncController.h
    • -4
    • +12
    /sources/device/DeviceController.cpp
Added

Added

Updated

Updated

Removed and updated

Removed and updated

Removed and updated

Removed and updated

Added

Added

Combine set/reset for the 2 override functions. And use the helper functions in TestSupport.h (like over override handling functions do). f32Override() for the prime volume override and u32Broadcas...

Combine set/reset for the 2 override functions. And use the helper functions in TestSupport.h (like over override handling functions do). f32Override() for the prime volume override and u32BroadcastIntervalOverride() for the broadcast interval override.

Remove "Set" from override function names. These 2 override functions should handle both set and reset (from msg payload).

Remove "Set" from override function names. These 2 override functions should handle both set and reset (from msg payload).

Remove reset override functions. Reset should be handled in the single (general) override command handler.

Remove reset override functions. Reset should be handled in the single (general) override command handler.

Just 2 messages here. See comment from MsgDefs.h.

Just 2 messages here. See comment from MsgDefs.h.

Only need 2 message IDs here. In Leahi, we don't have separate messages for set vs. reset. Both set and reset are handled in the same message.

Only need 2 message IDs here. In Leahi, we don't have separate messages for set vs. reset. Both set and reset are handled in the same message.

Removed

Removed

Added

Added

Updated

Updated

Updated

Updated

Changed

Changed

Added

Added

Updated

Updated

I believe this function only takes 1 param in Leahi.

I believe this function only takes 1 param in Leahi.

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes a...

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes are missing as well (check bottom of compiler warnings list).

Change BloodPrime to StateTxBloodPrime here too.

Change BloodPrime to StateTxBloodPrime here too.

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there ...

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when documentation is generated.

Add a details line for Message Sent for the broadcast data message.

Add a details line for Message Sent for the broadcast data message.

I don't see these override message handler functions being added to table in Messages.c. And I don't see new Dialin message IDs added to enum in MsgDefs.h.

I don't see these override message handler functions being added to table in Messages.c. And I don't see new Dialin message IDs added to enum in MsgDefs.h.

It looks like it's still here.

It looks like it's still here.

Removed

Removed