LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

Activity

LEAHI-DD-FIRMWARE-LDT-2004-1 96

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 5h 13m 35 fixed. Removed ifdef as well as it is no longer applies h...
    Reviewer - 0% reviewed 4m    
    Reviewer - 98% reviewed 13h 3m    
    Reviewer - 0% reviewed 0m    
    Reviewer - 98% reviewed 31m    
    Reviewer - 0% reviewed      
    Reviewer - 81% reviewed 49m 6 error count or reading temperature?
    Reviewer - Complete 2h 17m 55 I think using filtered values for alarms makes sense.
    Reviewer - 0% reviewed 7m    
    Reviewer - 80% reviewed 1h 5m    
    Total   23h 12m 96  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/Heaters.c Changed 2
    Open in IDE #permalink
    /firmware/.../Drivers/ConductivitySensors.c Changed 6
    Open in IDE #permalink
    /firmware/.../Drivers/ConductivitySensors.h Changed
    Open in IDE #permalink
    /firmware/App/Drivers/ConductivityTeensy.c Added 39
    Open in IDE #permalink
    /firmware/App/Drivers/ConductivityTeensy.h Added 20
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed 6
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.c Changed 7
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.h Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Temperature.c Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed 1
    Open in IDE #permalink
    /firmware/App/Services/Interrupts.c Changed 6
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 4
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed
    Open in IDE #permalink
    /firmware/include/sci.h Changed
    Open in IDE #permalink
    /firmware/source/sci.c Changed
    Open in IDE #permalink
    /firmware/DD.dil Changed
    Open in IDE #permalink
    /MsgDefs.h Changed
    Open in IDE #permalink
    /Comm.c Changed 3
    Open in IDE #permalink
    /Comm.h Changed 2
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time