LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

Activity

LEAHI-DD-FIRMWARE-LDT-2004-2 39

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 20m    
    Reviewer - 100% reviewed 54m 20 Comment seems backward. Uncommenting would enable the Tee...
    Reviewer - 2% reviewed 51m    
    Reviewer - 0% reviewed      
    Reviewer - 21% reviewed 1m    
    Reviewer - 23% reviewed 10h 7m 19 space required. check all other if condition and while st...
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed 1m    
    Total   12h 18m 39  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/Heaters.c Changed 1
    Open in IDE #permalink
    /firmware/.../Drivers/ConductivitySensors.c Changed 6
    Open in IDE #permalink
    /firmware/.../Drivers/ConductivitySensors.h Changed
    Open in IDE #permalink
    /firmware/App/Drivers/ConductivityTeensy.c Added 22
    Open in IDE #permalink
    /firmware/App/Drivers/ConductivityTeensy.h Added 2
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed 1
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.c Changed 3
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.h Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Temperature.c Changed
    Open in IDE #permalink
    /firmware/App/Services/Interrupts.c Changed 2
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 1
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed 1
    Open in IDE #permalink
    /firmware/include/sci.h Changed
    Open in IDE #permalink
    /firmware/source/sci.c Changed
    Open in IDE #permalink
    /firmware/DD.dil Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time