LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed

Activity

LEAHI-DD-FIRMWARE-LDT-3103-1 100

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 2h 10m 8 Looks the fields are empty and misaligned. fill as needed.
    Reviewer - 0% reviewed 0m    
    Reviewer - Complete 1h 29m 36 Why did this move? It needs to be in the nth row of the t...
    Reviewer - 80% reviewed 10m    
    Reviewer - 0% reviewed 1m    
    Reviewer - 95% reviewed 1h 18m    
    Reviewer - 78% reviewed 23m 4 align
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - Complete 6h 7m 52 done changed it.
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   11h 41m 100  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.settings/com.ti.ccstudio.project.core.prefs Deleted 2
    Open in IDE #permalink
    /firmware/.../Controllers/BalancingChamber.c Changed 55
    Open in IDE #permalink
    /firmware/.../Controllers/BalancingChamber.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/DialysatePumps.c Changed 2
    Open in IDE #permalink
    /firmware/App/Controllers/DialysatePumps.h Changed 2
    Open in IDE #permalink
    /firmware/App/Controllers/Valves.c Changed 8
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed 18
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.h Changed 2
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Changed 5
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed 2
    Open in IDE #permalink
    /AlarmDefs.h Changed 4
    Open in IDE #permalink
    /TestSupport.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time