LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD

Activity

LEAHI-DD-FIRMWARE-LDT-1473-1 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 59m 4 Done.
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 23m 5 So shouldn't we stop trimmer heater here then?
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 27% reviewed 1m    
    Reviewer - 0% reviewed 8m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   1h 33m 9  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.../Controllers/BalancingChamber.c Changed 2
    Open in IDE #permalink
    /firmware/.../Controllers/BalancingChamber.h Changed
    Open in IDE #permalink
    /firmware/.../Controllers/ConcentratePumps.c Changed 2
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.c Changed
    Open in IDE #permalink
    /firmware/.../Controllers/Ultrafiltration.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Valves.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed 3
    Open in IDE #permalink
    /firmware/App/Monitors/Temperature.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.h Changed
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed
    Open in IDE #permalink
    /TestSupport.h Changed 2
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time