MAlarmVolumeData.cpp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-8058_Alarm Volume Brightness
UI-DEN-8058_Alarm Volume Brightness
RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

Done

Done

Fixed

Fixed

Done

Done

That works too. No need for tee here. I've updated it

That works too. No need for tee here. I've updated it

I think VDateTime.h is less safe in this case. It should be updated to match if (_process.state() != QProcess::NotRunning) { return; } to prevent re-starting the process when its already in the "S...

I think VDateTime.h is less safe in this case. It should be updated to match

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    }; 
I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

AlarmVolumeTemp has been removed

AlarmVolumeTemp has been removed

It is removed now

It is removed now

Done

Done

The one which has been used in the VDateTime is much cleaner: if (_process.state() == QProcess::Running) { return; }

The one which has been used in the VDateTime is much cleaner:

if (_process.state() == QProcess::Running) {
    return;
}
Please don't use "%0" as we discussed.

Please don't use "%0" as we discussed.

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

Was there a reason the tee command is being used, instead of simply using > like : echo "$1" > /sys/class/backlight/backlight-mipi/brightness ?

Was there a reason the tee command is being used, instead of simply using > like :

echo "$1" > /sys/class/backlight/backlight-mipi/brightness

?

What is this line used for?

What is this line used for?

Interesting. Why it is a broadcast instead of a request/response? Why does UI need a broadcast message while it will always be adjusted by UI?

Interesting.
Why it is a broadcast instead of a request/response?
Why does UI need a broadcast message while it will always be adjusted by UI?