Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
not clear what it means.

not clear what it means.

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

where do you use this ctor?

where do you use this ctor?

I remember and and can we use reconnect as a Paired State.

I remember and and can we use reconnect as a Paired State.

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

when do we know if that is paired, I think the ticket wants that one, right?

when do we know if that is paired, I think the ticket wants that one, right?

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

move these two in the same location it was, to keep the order.

move these two in the same location it was, to keep the order.

make them one-liner in front of the if/else and align.

make them one-liner in front of the if/else and align.

make it bool isPaired();

make it
bool isPaired();

please use the shorter constructor provided. the error needs to be initialized as well, then it becomes the simple one.

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.

RESOLVED

RESOLVED

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

her. => here.

her. => here.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

fixed

fixed

thank you, fixed.

thank you,
fixed.

removed

removed

It currently has.

It currently has.

It currently has.

It currently has.

it is being used and tend to be the bool. being alias of what? it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

it is being used and tend to be the bool.
being alias of what?
it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
typo

typo

typo

typo

This property is not being used. Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

This property is not being used.

Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

if statement indentation

if statement indentation

If statement - needs indentation

If statement - needs indentation