application / sources

model

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 10 Feb
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 Sep 2023
2:09 pm

Behrouz NematiPour

not clear what it means.

not clear what it means.

2:09 pm

vduong  (deleted user)

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

2:08 pm

vduong  (deleted user)

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

2:08 pm

Behrouz NematiPour

where do you use this ctor?

where do you use this ctor?

2:07 pm

Behrouz NematiPour

I remember and and can we use reconnect as a Paired State.

I remember and and can we use reconnect as a Paired State.

2:03 pm

vduong  (deleted user)

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

2:02 pm

Behrouz NematiPour

when do we know if that is paired, I think the ticket wants that one, right?

when do we know if that is paired, I think the ticket wants that one, right?

2:02 pm

vduong  (deleted user)

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

1:52 pm

Behrouz NematiPour

move these two in the same location it was, to keep the order.

move these two in the same location it was, to keep the order.

1:43 pm

Behrouz NematiPour

make them one-liner in front of the if/else and align.

make them one-liner in front of the if/else and align.

1:41 pm

Behrouz NematiPour

make it bool isPaired();

make it
bool isPaired();

1:35 pm

Behrouz NematiPour

please use the shorter constructor provided. the error needs to be initialized as well, then it becomes the simple one.

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.

Thursday 31 Aug 2023
4:54 pm

vduong  (deleted user)

RESOLVED

RESOLVED

11:28 am

vduong  (deleted user)

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

11:26 am

vduong  (deleted user)

her. => here.

her. => here.

11:26 am

vduong  (deleted user)

RESOLVED

RESOLVED

11:25 am

vduong  (deleted user)

RESOLVED

RESOLVED

11:25 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:57 am

Behrouz NematiPour

fixed

fixed

10:57 am

Behrouz NematiPour

thank you, fixed.

thank you,
fixed.

10:56 am

Behrouz NematiPour

removed

removed

Wednesday 30 Aug 2023
5:10 pm

Behrouz NematiPour

It currently has.

It currently has.

5:10 pm

Behrouz NematiPour

It currently has.

It currently has.

5:09 pm

Behrouz NematiPour

it is being used and tend to be the bool. being alias of what? it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

it is being used and tend to be the bool.
being alias of what?
it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

2:06 pm

Dara Navaei

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
5:11 am

vduong  (deleted user)

typo

typo

5:10 am

vduong  (deleted user)

typo

typo

5:08 am

vduong  (deleted user)

This property is not being used. Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

This property is not being used.

Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

Monday 28 Aug 2023
9:20 am

msuleiman  (deleted user)

if statement indentation

if statement indentation

9:18 am

msuleiman  (deleted user)

If statement - needs indentation

If statement - needs indentation