Clone
Behrouz NematiPour
committed
on 17 Jan 24
DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm
DENBUG-185: UI shows version without period in between (ECO-11648, ECO-11Show more
DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

DENBUG-185: UI shows version without period in between (ECO-11648, ECO-11616)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

Addressing Code Review comments

Addressing code review comments

compatibility needs the separator before the value

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

- the order of the QML PROPERTYs cannot exactly predicted therefore setting them if not needed has to be avoided.

- a new method _init has been added to the PROPERTY_BASE to reset the property value without triggering the changed method so the property will get updated on the next round if the same value as before has been sent. ( the issue could be if code return after the alarmID = 0 on next alarm if the same ID send since the value is the same the QML will not get any signal to update, by changing the private property the signal will be triggered.)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

- the order of the QML PROPERTYs cannot exactly predicted therefore setting them if not needed has to be avoided.

- set the alarmID to 0 to trigger the next change since we skip the property updated if the alarmID is 0.

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

Show less

model_unit_test_fix + 12 more
v1.0.0-1-ui-release/p1_staging