bootloader

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3259 work in progress. Updating the FPGA module to Leahi

LDT-3259 work in progress added a new broadcast channel from FFU

    • -21
    • +24
    /firmware/App/Services/SystemComm.c
else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.

else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

We can't jump to app if fpga ID is bad? Why not?

We can't jump to app if fpga ID is bad? Why not?

Where is this function defined?

Where is this function defined?

Align comments

Align comments

Why 2 conditions? Are there 2 ways to initiate an update? And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

Why 2 conditions? Are there 2 ways to initiate an update?

And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

LDT-3259 work in progress updated the stack and destination payloads

    • -42
    • +51
    /firmware/App/Services/Download.c
LDT-3259 cleaned up the code

    • -13
    • +10
    /firmware/App/Services/Download.c
LDT-3259 work in progress. Completed firmware remote update.

    • -11
    • +62
    /firmware/App/Services/CommBuffers.c
    • -15
    • +12
    /firmware/App/Services/Download.c
LDT-3259 work in progress

    • -47
    • +31
    /firmware/App/Services/Download.c
LDT-3259 imported the code changes from LEAH-1415

    • -6
    • +222
    /firmware/App/Modes/ModeStandby.c
    • -6
    • +171
    /firmware/App/Modes/ModeUpdate.c
    • -0
    • +122
    /firmware/App/Modes/OperationModes.c
    • -0
    • +25
    /firmware/App/Modes/OperationModes.h
    • -0
    • +68
    /firmware/App/Services/Comm.c
  1. … 39 more files in changeset.
LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
LEAH-1415 updated the bootloader code to be more comaptible with Leahi

TODO

TODO

TODO

TODO

TODO should be all caps.

TODO should be all caps.

TODO should be all caps for consistency (so we know what to search for).

TODO should be all caps for consistency (so we know what to search for).

I think it should be restored even if it's not used anywhere yet.

I think it should be restored even if it's not used anywhere yet.

Do we need an end of group marker down here?

Do we need an end of group marker down here?

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

LEAH-1415 addressed the code review comments

    • -18
    • +10
    /firmware/App/Modes/ModeStandby.c
    • -10
    • +7
    /firmware/App/Services/CommBuffers.c
It will be implemented in the new branch.

It will be implemented in the new branch.

Done

Done

Done

Done

Done

Done

Done

Done