dd-firmware / firmware / App / Modes

FPModes

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 12 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 May
10:22 am

Raghu Kallala

LDT-4413 fixed the order how data1 and data2 parsed in FP event calls

Options
    • -0
    • +2
    ./FPOperationModes.c
    • -1
    • +1
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./ModePreGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeateDefeatured.c
Wednesday 06 May
9:26 am

Michael Garthwaite

Merge branch 'staging' into LDT-3975-Boost-Pump

Options
    • -4
    • +4
    ./ModePreGenPermeate.c
    • -5
    • +5
    ./StateFlushConcentrate.c
    • -6
    • +5
    ./StateFlushPermeate.c
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Thursday 30 Apr
8:27 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1' into develop

Options
    • -2
    • +2
    ./ModePreGenPermeate.c
    • -2
    • +2
    ./StateFlushPermeate.c
  3. … 6 more files in changeset.
2:23 pm

Vendor - TEL - Sameer Poyil

1:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePreGenPermeate.c
    • -2
    • +2
    ./StateFlushConcentrate.c
    • -2
    • +2
    ./StateFlushPermeate.c
  4. … 10 more files in changeset.
1:42 pm

Sean Nash

10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Tuesday 28 Apr
11:55 am

Raghu Kallala

LDT-3975 WIP initial draft for boost pump refactor

Options
    • -2
    • +2
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
    • -3
    • +3
    ./StateFlushConcentrate.c
    • -1
    • +1
    ./StateFlushFilter.c
    • -3
    • +3
    ./StateFlushPermeate.c
    • -1
    • +1
    ./StateInletPressureCheck.c
  7. … 3 more files in changeset.
11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Monday 27 Apr
1:22 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

10:51 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-3978-switch-chamber-f-conductive-lev into develop

Options
    • -2
    • +2
    ./ModePreGenPermeate.c
    • -4
    • +3
    ./StateFlushPermeate.c
  3. … 5 more files in changeset.
10:36 am

Vendor - TEL - Sameer Poyil

LDT-3978 fix for conductive level sensor

Options
    • -1
    • +0
    ./StateFlushPermeate.c
  2. … 4 more files in changeset.
Sunday 26 Apr
12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?

12:31 pm

Sean Nash

Remove blank line.

Remove blank line.

12:30 pm

Sean Nash

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

12:30 pm

Sean Nash

Remove blank line.

Remove blank line.

12:29 pm

Sean Nash

Remove blank line.

Remove blank line.

Friday 24 Apr
10:17 pm

Vinayakam Mani