dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 38
Total Committers: 14
Last Commit: 07:39
Commits this week: 38

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

11:32 am

Sean Nash

Add space before ).

Add space before ).

11:32 am

Sean Nash

Add space between if and (.

Add space between if and (.

11:31 am

Sean Nash

Be consistent on whether you have a blank line between break and next case.

Be consistent on whether you have a blank line between break and next case.

11:30 am

Sean Nash

Keep blank line here.

Keep blank line here.

11:12 am

Sean Nash

What are these coefficients for? At least describe in comments, if not the names.

What are these coefficients for? At least describe in comments, if not the names.

11:10 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:09 am

Sean Nash

11:08 am

Sean Nash

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

10:17 am

Vendor - TEL - Jashwant Gantyada

I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

10:16 am

Vendor - TEL - Jashwant Gantyada

Done. Thank you.

Done. Thank you.

10:15 am

Vendor - TEL - Jashwant Gantyada

Changed. Thank you.

Changed. Thank you.

9:13 am

Dara Navaei

We still need this if statement.

We still need this if statement.

8:23 am

Raghu Kallala

Add a 1 second persistence on this alarm

Add a 1 second persistence on this alarm

7:26 am

Raghu Kallala

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

7:24 am

Raghu Kallala

Need to remove this handler

Need to remove this handler

7:22 am

Raghu Kallala

Add blank line before return statement

Add blank line before return statement

7:21 am

Raghu Kallala

Remove handlePreGenPDefInletWaterState

Remove handlePreGenPDefInletWaterState

7:20 am

Raghu Kallala

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

7:19 am

Raghu Kallala

Call this in both Pre Gen: Verify Water and Gen Permeate

Call this in both Pre Gen: Verify Water and Gen Permeate

7:17 am

Raghu Kallala

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

7:15 am

Raghu Kallala

Put quadratic and linear terms in parentheses.

Put quadratic and linear terms in parentheses.

6:56 am

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions