Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 04 Apr 2022

9:11 am

Dara Navaei

More
a096685
changed 3 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the fill mode and the drain mode and added build switches

- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -2
- +4
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -10
- +8
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

Sunday 03 Apr 2022

7:14 pm

Dara Navaei

More
1722e97
changed 5 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the concentrate pumps, temperature sensors, mode drain and fill

- -2
- +2
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -1
- +0
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -19
- +25
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -69
- +54
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -3
- +10
/firmware/App/Modes/ModeFill.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.h

Friday 01 Apr 2022

1:48 pm

Dara Navaei

More
ec51d99
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

1:48 pm

Dara Navaei

More
1e71ee2
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Disabled build switches

- -2
- +2
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

Thursday 31 Mar 2022

9:07 pm

Dara Navaei

More
66cc826
changed 13 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 merged staging

- -19
- +45
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -12
- +4
/firmware/App/Controllers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -22
- +16
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -14
- +25
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -2
- +3
/firmware/App/Controllers/ROPump.h
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.h
- -9
- +41
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -2
- +6
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -4
- +16
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -53
- +306
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -2
- +6
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -5
- +66
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -4
- +101
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -1
- +10
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

2:44 pm

Dara Navaei

More
c3d6651
changed 1 file
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 updated the flush drain RPM

- -1
- +1
/firmware/App/Modes/ModeFlush.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFlush.c

2:27 pm

Dara Navaei

More
34afdc9
changed 1 file
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 200 more DG-DEN-12224-7

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

2:27 pm

Dara Navaei

More
604d8aa
changed 17 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 200 more DG-DEN-12224-7

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -2
- +2
/firmware/App/Controllers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -1
- +1
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -1
- +1
/firmware/App/Controllers/Pressures.h
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.h
- -1
- +1
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/Controllers/ROPump.h
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.h
- -1
- +1
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -2
- +2
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -1
- +1
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -1
- +1
/firmware/App/Modes/ModeFill.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.h
- -1
- +1
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -1
- +1
/firmware/App/Modes/ModeGenIdle.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.h
- -1
- +1
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -2
- +2
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +2
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

2:24 pm

Dara Navaei

More
DG-DEN-11928-1
Closed

2:08 pm

Sean Nash

More
DG-DEN-11928-1
finished reviewing

1:55 pm

Dara Navaei

More
c7ed4f9
changed 16 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 merged staging

- -53
- +29
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -4
- +26
/firmware/App/Controllers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -4
- +5
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -1
- +1
/firmware/App/Controllers/Pressures.h
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.h
- -29
- +25
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -4
- +4
/firmware/App/Controllers/ROPump.h
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.h
- -18
- +27
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -30
- +32
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -5
- +7
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c
- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -2
- +2
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -1
- +1
/firmware/App/Modes/ModeGenIdle.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.h
- -116
- +103
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c
- -8
- +78
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -23
- +231
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +21
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

1:35 pm

Dara Navaei

More
ddeff95
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-12224 addressed the code review comments

- -10
- +11
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

1:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:23 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:22 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:21 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:20 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

1:18 pm

Sean Nash

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

12:46 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to Sean Nash

It is zeroed in transition function and it is not used until the acid state.

It is zeroed in transition function and it is not used until the acid state.

11:10 am

Dara Navaei

More
960a204
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

11:09 am

Dara Navaei

More
df73b89
changed 2 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -1
- +1
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c

9:09 am

Dara Navaei

More
674e18b
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 addressed the code review comments

- -3
- +1
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -2
- +27
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -23
- +28
/firmware/App/Modes/ModeGenIdle.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.c
- -0
- +3
/firmware/App/Modes/ModeGenIdle.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenIdle.h

Wednesday 30 Mar 2022

9:38 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to Sean Nash

Done.

Done.

9:33 pm

Dara Navaei

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

It is initialized in the init function and it is staggered.

It is initialized in the init function and it is staggered.

8:55 pm

Dara Navaei

More
6f62e99
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 updated the fill mode and the RO pump

- -7
- +7
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -0
- +1
/firmware/App/Controllers/ROPump.h
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.h
- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -8
- +3
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

7:41 pm

Hung Nguyen <hnguyen@diality.com>

More
1786636
changed 1 file
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Corrected logic errors

- -2
- +2
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-05 10:40 -0700