dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 May 2023
4:31 pm

Dara Navaei

Merged DEN-15462

Options
3:20 pm

jtaylor  (deleted user)

3:19 pm

jtaylor  (deleted user)

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.

11:54 am

Sean Nash

11:35 am

Dara Navaei

DEN-15462 added to be able to disable the voltages monitor with the software configurations

Options
    • -2
    • +7
    /firmware/App/Controllers/Voltages.c
11:27 am

Dara Navaei

DG-DEN-15462_Nelson Support With Alarm 77
DG-DEN-15462_Nelson Support With Alarm 77
Thursday 25 May 2023
10:08 am

Dara Navaei

DEN-15367, DEN-15404 updated the code

Options
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -0
    • +10
    /firmware/App/Modes/ModeROPermeateSample.c
    • -1
    • +0
    /firmware/App/Modes/OperationModes.c
Wednesday 24 May 2023
9:02 pm

Dara Navaei

DEN-15367, DEN-15404 worked on the treatment recovery. Initial commit of the RO permeate sample mode

Options
    • -1
    • +6
    /firmware/App/Modes/ModeDrain.c
    • -7
    • +72
    /firmware/App/Modes/ModeFill.c
    • -0
    • +1
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +2
    /firmware/App/Modes/ModeHeatDisinfectActiveCool.c
    • -0
    • +191
    /firmware/App/Modes/ModeROPermeateSample.c
    • -0
    • +29
    /firmware/App/Modes/ModeROPermeateSample.h
    • -1
    • +62
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +2
    /firmware/App/Modes/ModeStandby.h
    • -22
    • +33
    /firmware/App/Modes/OperationModes.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +6
    /firmware/App/Services/SystemComm.c
    • -2
    • +35
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Tuesday 23 May 2023
10:20 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:14 am

Dara Navaei

DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
10:12 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15369-fw-dg-framing-error-generates-incorrect-alarm' into develop

Options
10:12 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
10:12 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Services/FPGA.c
10:10 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15369-fw-dg-framing-error-generates-incorrect-alarm' into staging

Options
Sunday 21 May 2023
4:31 pm

Dara Navaei

Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

Options
    • -9
    • +27
    /firmware/App/Controllers/Heaters.c
    • -1
    • +3
    /firmware/App/Services/SystemComm.c
    • -1
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +3
    /firmware/App/Services/SystemCommMessages.h
Saturday 20 May 2023
3:54 pm

Dara Navaei

3:53 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
3:53 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/FlowSensors.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
3:52 pm

Dara Navaei

Merged DEN-15375

Options
3:44 pm

Sean Nash

3:26 pm

Dara Navaei

DEN-15375, DEN-15374, DEN-15378 fixed release build software fault

Options
    • -1
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +1
    /firmware/App/Controllers/FlowSensors.c
    • -5
    • +8
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/Valves.c
    • -0
    • +2
    /firmware/App/Services/SystemComm.c
    • -0
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +2
    /firmware/App/Services/SystemCommMessages.h
10:28 am

Dara Navaei

DEN-15375 updated the heaters control

Options
    • -1
    • +11
    /firmware/App/Controllers/Heaters.c
Friday 19 May 2023
4:58 pm

Dara Navaei

DEN-15375 updated the code

Options
    • -3
    • +3
    /firmware/App/Controllers/Heaters.c
12:39 pm

Dara Navaei

DEN-15375 updated the code

Options
    • -3
    • +3
    /firmware/App/Services/Reservoirs.c
12:31 pm

Dara Navaei

DEN-15375 addressed the heaters fixes

Options
    • -3
    • +8
    /firmware/App/Controllers/Heaters.c
    • -1
    • +4
    /firmware/App/Services/Reservoirs.c
12:19 pm

Dara Navaei

DG-DEN-15375_Dialysate Heating Fixes
DG-DEN-15375_Dialysate Heating Fixes
11:40 am

Dara Navaei

DEN-15367 worked on the treatment recovery

Options
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/ROPump.c
    • -6
    • +9
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +6
    /firmware/App/Modes/ModeFault.c
    • -0
    • +5
    /firmware/App/Modes/OperationModes.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +24
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
8:41 am

Michael Garthwaite

Thursday 18 May 2023
12:02 pm

Dara Navaei

DG-DEN-15369_FW DG Framing Error Generates Incorrect Alarm
DG-DEN-15369_FW DG Framing Error Generates Incorrect Alarm
11:37 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15369 Correct framing error alarm ID

Options
    • -1
    • +1
    /firmware/App/Services/FPGA.c