dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Aug 2023
2:14 pm

Sean Nash

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:09 pm

Sean Nash

Put declarations at top of function. Use our BOOL type. Put ternary in ().

Put declarations at top of function. Use our BOOL type. Put ternary in ().

2:07 pm

Sean Nash

No point to having non-zero clear persistence - it's a fault.

No point to having non-zero clear persistence - it's a fault.

Tuesday 22 Aug 2023
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

4:05 pm

Dara Navaei

DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
2:54 pm

Michael Garthwaite

1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

12:26 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash

11:27 am

Michael Garthwaite

11:24 am

wbracken  (deleted user) and Sean Nash

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

jtaylor  (deleted user)

Suggest aligning comments in the block above

Suggest aligning comments in the block above

Friday 18 Aug 2023
1:49 pm

Dara Navaei

1:48 pm

Sean Nash and wbracken  (deleted user)

12:35 pm

Michael Garthwaite

Removed #define. Thanks!

Removed #define. Thanks!

11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Sean Nash

Add blank line between functions.

Add blank line between functions.

10:35 am

Sean Nash

Add blank line between banner comment and prototype.

Add blank line between banner comment and prototype.

10:13 am

Sean Nash

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

9:58 am

Sean Nash

I don't see where this #define is ever used. Remove if not needed.

I don't see where this #define is ever used. Remove if not needed.