dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
9:02 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -1
    • +1
    ./ModeFlush.c
  2. … 1 more file in changeset.
9:01 am

Dara Navaei

DEN-11750 added a build switch for heat disinfect

Options
    • -6
    • +3
    ./ModeChemicalDisinfect.c
    • -0
    • +4
    ./ModeHeatDisinfect.c
  3. … 1 more file in changeset.
8:49 am

Sean Nash

Seems like this should be an alarm.

Seems like this should be an alarm.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:04 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:02 am

Dara Navaei

Done.

Done.

8:00 am

Dara Navaei

Done.

Done.

7:57 am

Dara Navaei

I will test this in DEN-12224.

I will test this in DEN-12224.

7:57 am

Dara Navaei

Done.

Done.

Tuesday 01 Mar 2022
8:16 pm

Dara Navaei

DG-DEN-12121_SW Dev Sprint 65
DG-DEN-12121_SW Dev Sprint 65
6:13 pm

hnguyen  (deleted user)

Removed the lines requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID ); requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB ); The concentrate pumps are already OFF prior to transitioning to ...

Removed the lines
requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID );
requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB );

The concentrate pumps are already OFF prior to transitioning to produce dialysate state.

5:47 pm

hnguyen  (deleted user)

According Blain's PowerPoint, for bicard, the RO Pump speed is 400mL/min. 800mL/min is for acid.

According Blain's PowerPoint, for bicard, the RO Pump speed is 400mL/min. 800mL/min is for acid.

5:47 pm

hnguyen  (deleted user)

Done.

Done.

5:25 pm

hnguyen  (deleted user)

Added param: testValue, baseValue, percentFactor

Added param: testValue, baseValue, percentFactor

5:06 pm

hnguyen  (deleted user)

RO pump rate is already set in the previous state.

RO pump rate is already set in the previous state.

4:47 pm

hnguyen  (deleted user)

Done.

Done.

4:14 pm

hnguyen  (deleted user)

Added requestNewOperationMode( DG_MODE_GENE );

Added requestNewOperationMode( DG_MODE_GENE );

3:55 pm

hnguyen  (deleted user)

Renamed roPumpSpeed to roPumpFlushBubblesSpeed and updated comments

Renamed roPumpSpeed to roPumpFlushBubblesSpeed and updated comments

3:23 pm

hnguyen  (deleted user)

Added high and low temperature check BOOL isWaterTempTooHigh = ( temperature > MAX_WATER_TEMPERATURE_ALARM ); BOOL isWaterTempTooLow = ( temperature < MIN_WATER_TEMPERATURE_ALARM );

Added high and low temperature check
BOOL isWaterTempTooHigh = ( temperature > MAX_WATER_TEMPERATURE_ALARM );

BOOL isWaterTempTooLow = ( temperature < MIN_WATER_TEMPERATURE_ALARM );

3:21 pm

hnguyen  (deleted user)

Renamed #define to #define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U #define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U #define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U #define MAX_WATER_TE...

Renamed #define to

#define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U
#define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U
#define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U
#define MAX_WATER_TEMPERATURE_WARNING_HIGH_RANGE 39U
#define MIN_WATER_TEMPERATURE_ALARM 22U
#define MAX_WATER_TEMPERATURE_ALARM 39U

3:20 pm

hnguyen  (deleted user)

Renamed #define to #define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U #define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U #define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U #define MAX_WATER_TE...

Renamed #define to

#define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U
#define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U
#define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U
#define MAX_WATER_TEMPERATURE_WARNING_HIGH_RANGE 39U
#define MIN_WATER_TEMPERATURE_ALARM 22U
#define MAX_WATER_TEMPERATURE_ALARM 39U

1:58 pm

hnguyen  (deleted user)

Changed CONCENTRATE_PUMP_MAX_SPEED from 40.0 to 48.0.

Changed CONCENTRATE_PUMP_MAX_SPEED from 40.0 to 48.0.

1:55 pm

hnguyen  (deleted user)

Added a blank line. Asked Dara to add acid and bicard values to the calibration record on 2/8/2022.

Added a blank line.
Asked Dara to add acid and bicard values to the calibration record on 2/8/2022.

1:49 pm

hnguyen  (deleted user)

Checked with Systems. Conductivity min value is 100. #define COND_SENSOR_CPI_MAX_VALUE 2200 #define COND_SENSOR_CPI_WARNING_HIGH 2200 #define COND_SENSOR_CPI_WARNING_LOW 2000 #define COND_SENSOR_CP...

Checked with Systems. Conductivity min value is 100.
#define COND_SENSOR_CPI_MAX_VALUE 2200
#define COND_SENSOR_CPI_WARNING_HIGH 2200
#define COND_SENSOR_CPI_WARNING_LOW 2000
#define COND_SENSOR_CPI_MIN_VALUE 100

1:45 pm

hnguyen  (deleted user)

Updated code to include checking for high conductivity

Updated code to include checking for high conductivity

1:03 pm

hnguyen  (deleted user)

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 158, ///< Inlet water conductivity too high in AlarmDefs.h

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 158, ///< Inlet water conductivity too high in AlarmDefs.h

11:03 am

Sean Nash

Do we need to fix this?

Do we need to fix this?

10:59 am

Sean Nash

This doesn't look like a get - status is being set. I don't think we should be setting .ovData here at all - should only be set via an override cmd message. I think .data should always be set here ...

This doesn't look like a get - status is being set. I don't think we should be setting .ovData here at all - should only be set via an override cmd message. I think .data should always be set here (no if).